[Wikidata-bugs] [Maniphest] [Commented On] T167127: Standard UI for including statements in constraint violation messages

2018-06-12 Thread Jan_Dittrich
Jan_Dittrich added a comment. @Jan_Dittrich what should it look like if there’s a line break in one of the labels? Hmm, good point. I would suggest to have it end bluntly and keep it display:inline (or a behavior like that. ) F22145080: image.png ↑rough exampleTASK DETAILhttps://phabricator.wikim

[Wikidata-bugs] [Maniphest] [Commented On] T167127: Standard UI for including statements in constraint violation messages

2018-06-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. @Jan_Dittrich what should it look like if there’s a line break in one of the labels?TASK DETAILhttps://phabricator.wikimedia.org/T167127EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jan_Dittrich, Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] [Commented On] T167127: Standard UI for including statements in constraint violation messages

2018-05-30 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. You can see some example violations here (I’m not sure if you need to be logged in or not) and play with the CSS in dev tools.TASK DETAILhttps://phabricator.wikimedia.org/T167127EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreference

[Wikidata-bugs] [Maniphest] [Commented On] T167127: Standard UI for including statements in constraint violation messages

2018-05-30 Thread Jan_Dittrich
Jan_Dittrich added a comment. Is this online somewhere? Just I case I or some other dev might have an awesome idea :-) (Not a must, just in case it seems to be a good idea-exchange-thing)TASK DETAILhttps://phabricator.wikimedia.org/T167127EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/

[Wikidata-bugs] [Maniphest] [Commented On] T167127: Standard UI for including statements in constraint violation messages

2018-05-14 Thread Jan_Dittrich
Jan_Dittrich added a comment. I created some inital designs F18249337: image.png It is tricky to get the contrast right: enough to see it, but not too much to make reading hard. I can spec it more and try more, but I wonder: If the suggestions below could build upon the same code, we do two itera

[Wikidata-bugs] [Maniphest] [Commented On] T167127: Standard UI for including statements in constraint violation messages

2018-05-09 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Some example messages following a subject-predicate object pattern can be found on https://wikidata-constraints.wmflabs.org/index.php/Item:Q35#P20 (and my hacky border CSS is in P5557).TASK DETAILhttps://phabricator.wikimedia.org/T167127EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Commented On] T167127: Standard UI for including statements in constraint violation messages

2018-05-08 Thread Jan_Dittrich
Jan_Dittrich added a comment. Sorry – that got quite stuck. Let's sync on this in person in the next days and get it going again.TASK DETAILhttps://phabricator.wikimedia.org/T167127EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jan_DittrichCc: James_Budday, P

[Wikidata-bugs] [Maniphest] [Commented On] T167127: Standard UI for including statements in constraint violation messages

2017-08-02 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.Herald added a subscriber: PokestarFan. Currently, the following roles are defined: subject, the subject (item or property) of a statement predicate, the predicate (property) of a statement object, the object (value) of a statement constraint-property, the p

[Wikidata-bugs] [Maniphest] [Commented On] T167127: Standard UI for including statements in constraint violation messages

2017-06-28 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. @Jan_Dittrich did you get a chance to play with the CSS?TASK DETAILhttps://phabricator.wikimedia.org/T167127EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Lydia_Pintscher, Jan_Dittri

[Wikidata-bugs] [Maniphest] [Commented On] T167127: Standard UI for including statements in constraint violation messages

2017-06-28 Thread gerritbot
gerritbot added a comment. Change 357779 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add semantic tags to values rendered into messages https://gerrit.wikimedia.org/r/357779TASK DETAILhttps://phabricator.wikimedia.org/T167127EMAIL PREFERENCEShttps://phabricator.

[Wikidata-bugs] [Maniphest] [Commented On] T167127: Standard UI for including statements in constraint violation messages

2017-06-08 Thread gerritbot
gerritbot added a comment. Change 357779 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add semantic tags to values rendered into messages https://gerrit.wikimedia.org/r/357779TASK DETAILhttp

[Wikidata-bugs] [Maniphest] [Commented On] T167127: Standard UI for including statements in constraint violation messages

2017-06-07 Thread Jan_Dittrich
Jan_Dittrich added a comment. The big advantage of a “pill-like” solution over the punctuation, in my opinion, is that it’s independent of language. We can also change it easier, which is nice for design.TASK DETAILhttps://phabricator.wikimedia.org/T167127EMAIL PREFERENCEShttps://phabricator.wikim

[Wikidata-bugs] [Maniphest] [Commented On] T167127: Standard UI for including statements in constraint violation messages

2017-06-06 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. The big advantage of a “pill-like” solution over the punctuation, in my opinion, is that it’s independent of language. For the punctuation, we have to change the English message texts, which will invalidate all the existing translations, and there might also

[Wikidata-bugs] [Maniphest] [Commented On] T167127: Standard UI for including statements in constraint violation messages

2017-06-06 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Quick’n’dirty mockup for the punctuation and pill suggestions: F8390596: Screen Shot 2017-06-06 at 14.41.00.pngTASK DETAILhttps://phabricator.wikimedia.org/T167127EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Wer