[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2018-09-18 Thread Addshore
Addshore added a comment. @Lucas_Werkmeister_WMDE It might be nice to wrap this task up and close it filing a new with the remaining JsonEntityLookup and tagging with #wikidata-campsite ready to be picked up in future iterations.TASK DETAILhttps://phabricator.wikimedia.org/T168240EMAIL PREFERENCESh

[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2018-02-13 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. We still have some uses of JsonEntityLookup in the tests, so that part of the original task description is still open. Apart from that, I’ve kinda been using this task as a catch-all for various stuff I did in the tests… not sure if that makes sense.TASK DETA

[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2018-02-13 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. Anything left to do here or can this be closed?TASK DETAILhttps://phabricator.wikimedia.org/T168240EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, Lydia_PintscherCc: Lydia_Pintscher, Jonas, gerritbot, Lu

[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2018-01-24 Thread gerritbot
gerritbot added a comment. Change 404715 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Use InMemoryEntityLookup instead of JsonFileEntityLookup https://gerrit.wikimedia.org/r/404715TASK DETAILhttps://phabricator.wikimedia.org/T168240EMAIL PREFERENCEShttps://phabri

[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2018-01-24 Thread gerritbot
gerritbot added a comment. Change 405897 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Don’t use NewStatement to build standalone snaks https://gerrit.wikimedia.org/r/405897TASK DETAILhttps://phabricator.wikimedia.org/T168240EMAIL PREFERENCEShttps://phabricator.wi

[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2018-01-24 Thread gerritbot
gerritbot added a comment. Change 405893 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Expand ReferenceContextTest::testGetSnakGroup https://gerrit.wikimedia.org/r/405893TASK DETAILhttps://phabricator.wikimedia.org/T168240EMAIL PREFERENCEShttps://phabricator.wikim

[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2018-01-23 Thread gerritbot
gerritbot added a comment. Change 405897 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Don’t use NewStatement to build standalone snaks https://gerrit.wikimedia.org/r/405897TASK DETAILhttps:

[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2018-01-23 Thread gerritbot
gerritbot added a comment. Change 405893 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Expand ReferenceContextTest::testGetSnakGroup https://gerrit.wikimedia.org/r/405893TASK DETAILhttps://p

[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2018-01-23 Thread gerritbot
gerritbot added a comment. Change 405874 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Remove not needed …->withSomeGuid() calls from tests https://gerrit.wikimedia.org/r/405874TASK DETAILhttps://phabricator.wikimedia.org/T168240EMAIL PREFERENCEShttps://phabricato

[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2018-01-23 Thread gerritbot
gerritbot added a comment. Change 405032 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Rewrite ValueCountChecker tests https://gerrit.wikimedia.org/r/405032TASK DETAILhttps://phabricator.wikimedia.org/T168240EMAIL PREFERENCEShttps://phabricator.wikimedia.org/setti

[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2018-01-23 Thread gerritbot
gerritbot added a comment. Change 405724 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Rename @dataProvider methods to provide…() https://gerrit.wikimedia.org/r/405724TASK DETAILhttps://phabricator.wikimedia.org/T168240EMAIL PREFERENCEShttps://phabricator.wikimedi

[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2018-01-23 Thread gerritbot
gerritbot added a comment. Change 405874 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Remove not needed …->withSomeGuid() calls from tests https://gerrit.wikimedia.org/r/405874TASK DETAILhttps://phab

[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2018-01-22 Thread gerritbot
gerritbot added a comment. Change 405724 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Rename @dataProvider methods to provide…() https://gerrit.wikimedia.org/r/405724TASK DETAILhttps://phab

[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2018-01-18 Thread gerritbot
gerritbot added a comment. Change 405032 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Rewrite ValueCountChecker tests https://gerrit.wikimedia.org/r/405032TASK DETAILhttps://phabricator.wik

[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2018-01-17 Thread gerritbot
gerritbot added a comment. Change 404715 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Use InMemoryEntityLookup instead of JsonFileEntityLookup https://gerrit.wikimedia.org/r/404715TASK DETA

[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2017-11-27 Thread gerritbot
gerritbot added a comment. Change 393055 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Don’t use JsonFileEntityLookup in QualifiersCheckerTest https://gerrit.wikimedia.org/r/393055TASK DETAILhttps://phabricator.wikimedia.org/T168240EMAIL PREFERENCEShttps://phabric

[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2017-11-23 Thread gerritbot
gerritbot added a comment. Change 393055 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Don’t use JsonFileEntityLookup in QualifiersCheckerTest https://gerrit.wikimedia.org/r/393055TASK DETAI

[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2017-11-21 Thread gerritbot
gerritbot added a comment. Change 392040 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Don’t use JsonFileEntityLookup in RangeCheckerTest https://gerrit.wikimedia.org/r/392040TASK DETAILhttps://phabricator.wikimedia.org/T168240EMAIL PREFERENCEShttps://phabricator.

[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2017-11-17 Thread gerritbot
gerritbot added a comment. Change 392040 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Don’t use JsonFileEntityLookup in RangeCheckerTest https://gerrit.wikimedia.org/r/392040TASK DETAILhttp

[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2017-08-31 Thread gerritbot
gerritbot added a comment. Change 374841 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Remove SnakSerializer use from OneOfCheckerTest https://gerrit.wikimedia.org/r/374841TASK DETAILhttps://phabricator.wikimedia.org/T168240EMAIL PREFERENCEShttps://phabricator.wik

[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2017-08-30 Thread gerritbot
gerritbot added a comment. Change 374841 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Remove SnakSerializer use from OneOfCheckerTest https://gerrit.wikimedia.org/r/374841TASK DETAILhttps:/

[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2017-07-17 Thread gerritbot
gerritbot added a comment. Change 365060 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Use NewItem NewStatement in DiffWithinRangeCheckerTest https://gerrit.wikimedia.org/r/365060TASK DETAILhttps://phabricator.wikimedia.org/T168240EMAIL PREFERENCEShttps://phabrica

[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2017-07-13 Thread gerritbot
gerritbot added a comment. Change 365060 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Use NewItem NewStatement in DiffWithinRangeCheckerTest https://gerrit.wikimedia.org/r/365060TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2017-07-03 Thread gerritbot
gerritbot added a comment. Change 362984 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Use NewStatement in tests https://gerrit.wikimedia.org/r/362984TASK DETAILhttps://phabricator.wikimedia.org/T168240EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/pa

[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2017-07-03 Thread gerritbot
gerritbot added a comment. Change 362984 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Use NewStatement in tests https://gerrit.wikimedia.org/r/362984TASK DETAILhttps://phabricator.wikimedia

[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2017-06-30 Thread gerritbot
gerritbot added a comment. Change 362395 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add {class,relation}Parameter to ConstraintParameters https://gerrit.wikimedia.org/r/362395TASK DETAILh

[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2017-06-28 Thread gerritbot
gerritbot added a comment. Change 359911 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Start using NewItem in tests https://gerrit.wikimedia.org/r/359911TASK DETAILhttps://phabricator.wikimedia.org/T168240EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2017-06-19 Thread gerritbot
gerritbot added a comment. Change 359911 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Start using NewItem in tests https://gerrit.wikimedia.org/r/359911TASK DETAILhttps://phabricator.wikime