[Wikidata-bugs] [Maniphest] [Commented On] T170887: Updater seems to get stuck on "no changes" even though there are changes
gerritbot added a comment. Change 366752 merged by jenkins-bot: [wikidata/query/rdf@master] Fix TailPoller & sleep behavior https://gerrit.wikimedia.org/r/366752TASK DETAILhttps://phabricator.wikimedia.org/T170887EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Smalyshev, gerritbotCc: PokestarFan, gerritbot, Liuxinyu970226, Aklapper, Smalyshev, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, Avner, Lewizho99, Maathavan, debt, Gehel, Liridon, Jonas, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T170887: Updater seems to get stuck on "no changes" even though there are changes
gerritbot added a comment. Change 366752 had a related patch set uploaded (by Smalyshev; owner: Smalyshev): [wikidata/query/rdf@master] Fix TailPoller & sleep behavior https://gerrit.wikimedia.org/r/366752TASK DETAILhttps://phabricator.wikimedia.org/T170887EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Smalyshev, gerritbotCc: gerritbot, Liuxinyu970226, Aklapper, Smalyshev, GoranSMilovanovic, QZanden, EBjune, merbst, Avner, debt, Gehel, Jonas, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T170887: Updater seems to get stuck on "no changes" even though there are changes
Smalyshev added a comment. This seems to be the result of the following issue: Load on server rises and the updates get behind the flow Tail poller continues to keep up and gets in front of regular poller (since it is based off real time, not position of the RC poller!) Since the code does not check the queue if RC poller is behind, the changes are not pulled from the queue Since the changes are processed by TailPoller, RC poller does not see them and thus thinks there are no changes, triggering poll delay sleep. In this situation, Tail Poller is ahead of RC poller but no updates happen because RC poller is behind and is not catching up because of excessive sleeps. The immediate solution is to always empty the queue and to not sleep if there are more changes to process, even if they are not supplied to the updater. More proper solution is also not allowing the Tail Poller to get ahead of RC poller, but that may be challenging to ensure always.TASK DETAILhttps://phabricator.wikimedia.org/T170887EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Liuxinyu970226, Aklapper, Smalyshev, GoranSMilovanovic, QZanden, EBjune, merbst, Avner, debt, Gehel, Jonas, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
