gerritbot added a comment.
Change 463980 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Sort Forms in FormSet based on their numeric IDs
https://gerrit.wikimedia.org/r/463980TASK DETAILhttps://phabricator.wikimedia.org/T176405EMAIL
gerritbot added a comment.
Change 463980 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/WikibaseLexeme@master] Sort Forms in FormsView
https://gerrit.wikimedia.org/r/463980TASK DETAILhttps://phabricator.wikimedia.org/T176405EMAIL
Lydia_Pintscher added a comment.
Ok let's do the first necessary fix now and switch to numerical sorting. And then we do more research around how to improve beyond that.TASK DETAILhttps://phabricator.wikimedia.org/T176405EMAIL
Jan_Dittrich added a comment.
First fix would be getting away from alphabetical sorting of numbers
I think that sorting by meaning (here: grammatical features) makes the most sense.
Caveat: We need to provide a solution for the problem that adding a new form happens at the end of the list, but
Smalyshev added a comment.
Right now the order is kind of weird - e.g. F10 follows F1. See e.g. https://www.wikidata.org/wiki/Lexeme:L666TASK DETAILhttps://phabricator.wikimedia.org/T176405EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc:
daniel added a comment.
Order by grammatical feature (but how? Is that like "adverbs" are before "adjectives"? Will there be a table for the order somewhere?)
"adverb" and "adjective" are not grammatical feature, they are lexical categories. Grammatical features would be "2nd person" + "plural"
Lydia_Pintscher added a comment.
I believe sorting by form ID is not a good idea because the form ID does not have an inherent meaning to the user. It is just randomly assigned by when the form was added. I expect the case where someone looks up a form by its ID in the UI to be extremely rare.TASK
Lydia_Pintscher added a comment.
"Create at end of list and keep it there after creation while loaded. On reload order the new item into the list properly." <- This is already happening and should be kept as it is the same behavior as for statement adding on items.TASK
Jan_Dittrich added a comment.
@Lydia_Pintscher @daniel please supplement.TASK DETAILhttps://phabricator.wikimedia.org/T176405EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jan_DittrichCc: Lydia_Pintscher, daniel, Aklapper, Jan_Dittrich, Cinemantique,
