Lydia_Pintscher added a comment.
Can this be closed?TASK DETAILhttps://phabricator.wikimedia.org/T177764EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, Lydia_PintscherCc: Lydia_Pintscher, gerritbot, WMDE-leszek, Aleksey_WMDE, Addshore, hoo, aude,
WMDE-leszek added a comment.
The release and new build including it https://gerrit.wikimedia.org/r/#/c/383816/ apparently didn't help: https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit-jessie/42516/consoleTASK DETAILhttps://phabricator.wikimedia.org/T177764EMAIL
gerritbot added a comment.
Change 383806 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update ValueView dependency to 0.21.0
https://gerrit.wikimedia.org/r/383806TASK DETAILhttps://phabricator.wikimedia.org/T177764EMAIL
gerritbot added a comment.
Change 383806 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Update ValueView dependency to 0.21.0
https://gerrit.wikimedia.org/r/383806TASK
WMDE-leszek added a comment.
Apparently I can't push tags to https://gerrit.wikimedia.org/r/#/admin/projects/data-values/value-view, so cannot release it now...TASK DETAILhttps://phabricator.wikimedia.org/T177764EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
gerritbot added a comment.
Change 383786 merged by jenkins-bot:
[data-values/value-view@master] Switch from setup/teardown to before/afterEach in QUnit tests
https://gerrit.wikimedia.org/r/383786TASK DETAILhttps://phabricator.wikimedia.org/T177764EMAIL
WMDE-leszek added a comment.
Sorry for the noise, I've changed my mind. I don't want to be a bottleneck here. Let's release it now @thiemowmde , so it is pulled in today's build and we unblock QUnit upgrade work. npm package will be 0.22 then.TASK
gerritbot added a comment.
Change 383786 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[data-values/value-view@master] Switch from setup/teardown to before/afterEach in QUnit tests
https://gerrit.wikimedia.org/r/383786TASK
WMDE-leszek added a comment.
@Krinkle I am currently preparing the release of this component (as part of npmizing Wikibase JS stuff). This is going to include fixes @thiemowmde made (plus some teardown -> afterEach changes I spotted yesterday). Hopefully we'll get this released today.TASK
Krinkle added a comment.
@thiemowmde The tests still fail with QUnit 2 at https://gerrit.wikimedia.org/r/#/c/367838/13. Failures come from data-values/value-view.
In T177764#3674594, @gerritbot wrote:
Change 383383 merged by jenkins-bot:
[data-values/value-view@master] Remove QUnit.Parameterize
gerritbot added a comment.
Change 383383 merged by jenkins-bot:
[data-values/value-view@master] Remove QUnit.Parameterize dependency and make tests pass with QUnit 2
https://gerrit.wikimedia.org/r/383383TASK DETAILhttps://phabricator.wikimedia.org/T177764EMAIL
gerritbot added a comment.
Change 383363 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Make tests compatible with QUnit 2
https://gerrit.wikimedia.org/r/383363TASK DETAILhttps://phabricator.wikimedia.org/T177764EMAIL
gerritbot added a comment.
Change 383383 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[data-values/value-view@master] Remove QUnit.Parameterize dependency and make tests pass with QUnit 2
https://gerrit.wikimedia.org/r/383383TASK
gerritbot added a comment.
Change 383363 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Make tests compatible with QUnit 2
https://gerrit.wikimedia.org/r/383363TASK
gerritbot added a comment.
Change 370300 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make tests QUnit 2 compatible
https://gerrit.wikimedia.org/r/370300TASK DETAILhttps://phabricator.wikimedia.org/T177764EMAIL
gerritbot added a comment.
Change 383117 merged by jenkins-bot:
[data-values/value-view@master] Simplify QUnit assertions a little
https://gerrit.wikimedia.org/r/383117TASK DETAILhttps://phabricator.wikimedia.org/T177764EMAIL
gerritbot added a comment.
Change 383117 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[data-values/value-view@master] Simplify QUnit assertions a little
https://gerrit.wikimedia.org/r/383117TASK DETAILhttps://phabricator.wikimedia.org/T177764EMAIL
gerritbot added a comment.
Change 370300 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Krinkle):
[mediawiki/extensions/Wikibase@master] Make tests QUnit 2 compatible
https://gerrit.wikimedia.org/r/370300TASK DETAILhttps://phabricator.wikimedia.org/T177764EMAIL
18 matches
Mail list logo
