[Wikidata-bugs] [Maniphest] [Commented On] T178745: Highlight statement(s) when using "#P" in URL

Lucas_Werkmeister_WMDE added a comment. In T178745#5467875 , @abian wrote: > The highlighting of statement groups ("properties") is now available on Wikidata . The highlighting of individual

[Wikidata-bugs] [Maniphest] [Commented On] T178745: Highlight statement(s) when using "#P" in URL

Lydia_Pintscher added a comment. \o/ TASK DETAIL https://phabricator.wikimedia.org/T178745 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: abian, Lydia_Pintscher Cc: Lucas_Werkmeister_WMDE, jeblad, Ivanhercaz, Jd3main, abian,

[Wikidata-bugs] [Maniphest] [Commented On] T178745: Highlight statement(s) when using "#P" in URL

abian added a comment. The highlighting of statement groups ("properties") is now available on Wikidata . The highlighting of individual statements still needs approval on Gerrit. TASK DETAIL https://phabricator.wikimedia.org/T178745 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T178745: Highlight statement(s) when using "#P" in URL

abian added a comment. In T178745#5459066 , @Lucas_Werkmeister_WMDE wrote: > What’s volatile about them? We’ve preserved the capitalization of `q1$21f31f42-4f4d-79b0-0380-92039776e884` for a long time, for example (notice how the

[Wikidata-bugs] [Maniphest] [Commented On] T178745: Highlight statement(s) when using "#P" in URL

Lucas_Werkmeister_WMDE added a comment. What’s volatile about them? We’ve preserved the capitalization of `q1$21f31f42-4f4d-79b0-0380-92039776e884` for a long time, for example (notice how the entity ID is in lowercase). TASK DETAIL https://phabricator.wikimedia.org/T178745 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T178745: Highlight statement(s) when using "#P" in URL

gerritbot added a comment. Change 533917 had a related patch set uploaded (by Abián; owner: Abián): [mediawiki/extensions/Wikibase@master] Highlight :target individual statements https://gerrit.wikimedia.org/r/533917 TASK DETAIL https://phabricator.wikimedia.org/T178745 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T178745: Highlight statement(s) when using "#P" in URL

abian added a comment. In T178745#5458939 , @Lucas_Werkmeister_WMDE wrote: > In my opinion it would also be nice to make this work for individual statements, e. g. not only https://www.wikidata.org/wiki/Q1#P793 but also

[Wikidata-bugs] [Maniphest] [Commented On] T178745: Highlight statement(s) when using "#P" in URL

Lucas_Werkmeister_WMDE added a comment. In my opinion it would also be nice to make this work for individual statements, e. g. not only https://www.wikidata.org/wiki/Q1#P793 but also https://www.wikidata.org/wiki/Q1#Q1$e70e289c-471e-36b8-50ff-25612cf24e70. As far as I can tell, the above

[Wikidata-bugs] [Maniphest] [Commented On] T178745: Highlight statement(s) when using "#P" in URL

gerritbot added a comment. Change 530339 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Highlight :target statements https://gerrit.wikimedia.org/r/530339 TASK DETAIL https://phabricator.wikimedia.org/T178745 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T178745: Highlight statement(s) when using "#P" in URL

gerritbot added a comment. Change 530339 had a related patch set uploaded (by Abián; owner: Abián): [mediawiki/extensions/Wikibase@master] Highlight :target statements https://gerrit.wikimedia.org/r/530339 TASK DETAIL https://phabricator.wikimedia.org/T178745 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T178745: Highlight statement(s) when using "#P" in URL

Lydia_Pintscher added a comment. Does anyone want to give a patch a try? TASK DETAIL https://phabricator.wikimedia.org/T178745 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: jeblad, Ivanhercaz, Jd3main, abian,

[Wikidata-bugs] [Maniphest] [Commented On] T178745: Highlight statement(s) when using "#P" in URL

Sjoerddebruin added a comment. Looks good to me, "box-sizing:border-box;" might be needed in the CSS to keep the padding the same. TASK DETAIL https://phabricator.wikimedia.org/T178745 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Commented On] T178745: Highlight statement(s) when using "#P" in URL

abian added a comment. In T178745#4970482 , @Ivanhercaz wrote: > Although the Jan's and Hanna's suggestion seems very attractive and useful. Abian, hat do you think about it? Hanna's solution looks great to me! Anyway, my

[Wikidata-bugs] [Maniphest] [Commented On] T178745: Highlight statement(s) when using "#P" in URL

Ivanhercaz added a comment. In T178745#4941639, @abian wrote: An option similar to the one @Ivanhercaz suggests would be choosing the accent color #eaf3ff instead of the base color #eaecf0 for the background; this color is documented on M101. Thank you for your recommendation, @abian! In

[Wikidata-bugs] [Maniphest] [Commented On] T178745: Highlight statement(s) when using "#P" in URL

Hanna_Petruschat_WMDE added a comment. Thanks for following up on that @Ivanhercaz and giving input @abian. I think going for highlights is the right direction. I would argue though changing the background color could have two disadvantages We use blue as a background color for things being in

[Wikidata-bugs] [Maniphest] [Commented On] T178745: Highlight statement(s) when using "#P" in URL

jeblad added a comment. Highlighting is used in Flow (Structured Discussions), it is probably a good idea to do something similar. I've been toying with locality-sensitive hashing for similar linking, it would make links usable even if the target change slightly. Not sure whether that would work

[Wikidata-bugs] [Maniphest] [Commented On] T178745: Highlight statement(s) when using "#P" in URL

Jan_Dittrich added a comment. If we do this it should be very subtle; I looked at some other pages and did not see any highlighting in Wikipedia articles or e.g. at this handbook. We could just enable the browser defaults as on this page (I think this is the browser style; on Firefox it is black

[Wikidata-bugs] [Maniphest] [Commented On] T178745: Highlight statement(s) when using "#P" in URL

Ivanhercaz added a comment. That's a nice idea and easy to implement. I would do it, but as @thiemowmde and @Jan_Dittrich note, it is necessary to have a concern about it. Could we agree a basic style and then request comments about it? F28163655: target-wikidata-property.png Something like

[Wikidata-bugs] [Maniphest] [Commented On] T178745: Highlight statement(s) when using "#P" in URL

Jan_Dittrich added a comment. I agree that this would be a useful feature. It is also used on other sites, so having it won't cause confusion. My largest concern is that we don't have a styleguide or anything like that now and it is hard to determine a color (or other means of highlighting) that