[Wikidata-bugs] [Maniphest] [Commented On] T179663: What happens if the Wikibase project specifies a version of a library outside of the range included in mediawiki-vendor?
gerritbot added a comment. Change 560413 abandoned by Hashar: dockerfile for mediawiki-vendor version checker script Reason: Seems that better suited inside mediawiki/vendor or in mediawiki/tools/release :) https://gerrit.wikimedia.org/r/560413 TASK DETAIL https://phabricator.wikimedia.org/T179663 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, bd808, Aklapper, Legoktm, greg, Lydia_Pintscher, thiemowmde, WMDE-leszek, Aleksey_WMDE, Jonas, hoo, aude, Agabi10, Lucas_Werkmeister_WMDE, Jdforrester-WMF, VColeman, Ricordisamoa, Addshore, Alter-paule, Beast1978, Un1tY, Hook696, darthmon_wmde, Kent7301, holger.knust, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Pchelolo, Wikidata-bugs, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T179663: What happens if the Wikibase project specifies a version of a library outside of the range included in mediawiki-vendor?
gerritbot added a comment. Change 560413 had a related patch set uploaded (by Addshore; owner: Addshore): [integration/config@master] dockerfile for mediawiki-vendor version checker script https://gerrit.wikimedia.org/r/560413 TASK DETAIL https://phabricator.wikimedia.org/T179663 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, bd808, Aklapper, Legoktm, greg, Lydia_Pintscher, thiemowmde, WMDE-leszek, Aleksey_WMDE, Jonas, hoo, aude, Agabi10, Lucas_Werkmeister_WMDE, Jdforrester-WMF, VColeman, Ricordisamoa, Addshore, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, holger.knust, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Pchelolo, Wikidata-bugs, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T179663: What happens if the Wikibase project specifies a version of a library outside of the range included in mediawiki-vendor?
gerritbot added a comment. Change 460287 abandoned by Reedy: DNM WIP crappy build checking stuff https://gerrit.wikimedia.org/r/460287 TASK DETAIL https://phabricator.wikimedia.org/T179663 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, bd808, Aklapper, Legoktm, greg, Lydia_Pintscher, thiemowmde, WMDE-leszek, Aleksey_WMDE, Jonas, hoo, aude, Agabi10, Lucas_Werkmeister_WMDE, Jdforrester-WMF, VColeman, Ricordisamoa, Addshore, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, holger.knust, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Pchelolo, Wikidata-bugs, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T179663: What happens if the Wikibase project specifies a version of a library outside of the range included in mediawiki-vendor?
Addshore added a comment. I wrote a crappy script that we can try to modify and work into a daily jenkins job. The run today after I finished writing it identified 3 differences between the libs (all minor) > composer-lock-diff --from ./../mw/composer.lock --to ./../current-composer.lock | grep -v "| REMOVED" | grep -v "| NEW" | sed 's/From/Master/g' | sed 's/To/Vendor/g' +---+-+-+-+ | Production Changes| Master| Vendor | Compare | +---+-+-+-+ | james-heinrich/getid3 | v1.9.15 | v1.9.14 | https://github.com/JamesHeinrich/getID3/compare/v1.9.15...v1.9.14 | | justinrainbow/json-schema | 5.2.7 | 5.2.6 | https://github.com/justinrainbow/json-schema/compare/5.2.7...5.2.6 | | pear/pear-core-minimal| v1.10.6 | v1.10.3 | https://github.com/pear/pear-core-minimal/compare/v1.10.6...v1.10.3 | +---+-+-+-+TASK DETAILhttps://phabricator.wikimedia.org/T179663EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: gerritbot, bd808, Aklapper, Legoktm, greg, Lydia_Pintscher, thiemowmde, WMDE-leszek, Aleksey_WMDE, Jonas, hoo, aude, Agabi10, Lucas_Werkmeister_WMDE, Jdforrester-WMF, VColeman, demon, Jrbranaa, Ricordisamoa, Addshore, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Liudvikas, Luke081515, Fjalapeno, Wikidata-bugs, zeljkofilipin, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T179663: What happens if the Wikibase project specifies a version of a library outside of the range included in mediawiki-vendor?
gerritbot added a comment. Change 460287 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/vendor@master] DNM WIP crappy build checking stuff https://gerrit.wikimedia.org/r/460287TASK DETAILhttps://phabricator.wikimedia.org/T179663EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, bd808, Aklapper, Legoktm, greg, Lydia_Pintscher, thiemowmde, WMDE-leszek, Aleksey_WMDE, Jonas, hoo, aude, Agabi10, Lucas_Werkmeister_WMDE, Jdforrester-WMF, VColeman, demon, Jrbranaa, Ricordisamoa, Addshore, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Liudvikas, Luke081515, Fjalapeno, Wikidata-bugs, zeljkofilipin, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T179663: What happens if the Wikibase project specifies a version of a library outside of the range included in mediawiki-vendor?
Addshore added a comment. This sort of happened a week or so when mediawiki-vendor was actually running versions of libraries that som extensions were not listed as being compatible with. As a result https://gerrit.wikimedia.org/r/#/c/mediawiki/vendor/+/453581/ downgraded the libraries again, but no element of CI or huma checking caught the issue.TASK DETAILhttps://phabricator.wikimedia.org/T179663EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: bd808, Aklapper, Legoktm, greg, Lydia_Pintscher, daniel, thiemowmde, WMDE-leszek, Aleksey_WMDE, Jonas, hoo, aude, Agabi10, Lucas_Werkmeister_WMDE, Jdforrester-WMF, VColeman, demon, Jrbranaa, Ricordisamoa, Addshore, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Liudvikas, Luke081515, Fjalapeno, Wikidata-bugs, zeljkofilipin, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T179663: What happens if the Wikibase project specifies a version of a library outside of the range included in mediawiki-vendor?
Addshore added a comment. I'm going to link to https://gerrit.wikimedia.org/r/#/c/424278/ here which adds a simple command that would identify differences. This could be added to Wikibase too (and other extensions that use composer libs). As part of the branch cut this command could be run for all extensions (where it exists) and package differences between mediawiki-vendor and the extensions could be identified.TASK DETAILhttps://phabricator.wikimedia.org/T179663EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: bd808, Aklapper, Legoktm, greg, Lydia_Pintscher, daniel, thiemowmde, WMDE-leszek, Aleksey_WMDE, Jonas, hoo, aude, Agabi10, Lucas_Werkmeister_WMDE, Jdforrester-WMF, VColeman, demon, Jrbranaa, Ricordisamoa, Addshore, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Liudvikas, Luke081515, Wikidata-bugs, Anomie, zeljkofilipin, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T179663: What happens if the Wikibase project specifies a version of a library outside of the range included in mediawiki-vendor?
Addshore added a comment. Just tested with the gate-submit jobs too and they also gave it the green light on https://gerrit.wikimedia.org/r/#/c/391632. Looks like we have to add or alter a job.TASK DETAILhttps://phabricator.wikimedia.org/T179663EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: bd808, Aklapper, Legoktm, greg, Lydia_Pintscher, daniel, thiemowmde, WMDE-leszek, Aleksey_WMDE, Jonas, hoo, aude, Agabi10, Lucas_Werkmeister_WMDE, Jdforrester-WMF, VColeman, demon, Jrbranaa, Ricordisamoa, Addshore, Lahi, SandraF_WMF, GoranSMilovanovic, QZanden, Liudvikas, Luke081515, Wikidata-bugs, Anomie, zeljkofilipin, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T179663: What happens if the Wikibase project specifies a version of a library outside of the range included in mediawiki-vendor?
Jdforrester-WMF added a comment. @Addshore, is this Resolved (given the title's question is answered) or do you see changes we need to do based on the answer which will now be done under this task?TASK DETAILhttps://phabricator.wikimedia.org/T179663EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jdforrester-WMFCc: bd808, Aklapper, Legoktm, greg, Lydia_Pintscher, daniel, thiemowmde, WMDE-leszek, Aleksey_WMDE, Jonas, hoo, aude, Agabi10, Lucas_Werkmeister_WMDE, Jdforrester-WMF, VColeman, demon, Liuxinyu970226, Jrbranaa, Ricordisamoa, Addshore, Lahi, SandraF_WMF, GoranSMilovanovic, QZanden, Liudvikas, Luke081515, Wikidata-bugs, Anomie, zeljkofilipin, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T179663: What happens if the Wikibase project specifies a version of a library outside of the range included in mediawiki-vendor?
Legoktm added a comment. If Wikibase uses a feature of ~2.0 that is incompatible with 1.0.0, it'll blow up in production. The CI that currently runs on mediawiki/extensions/Wikidata pulls in only "require-dev" via composer, and uses mediawiki/vendor for the rest, so if there's a mismatch that is executed by tests, it'll get caught. We probably want to apply the same CI to Wikibase (using mediawiki/vendor instead of composer). Then if you want to update a library, you'll submit a patch to mediawiki/vendor, then a patch to Wikibase with Depends-On so CI is testing against the new library, and then merge both at the same time whenever ready.TASK DETAILhttps://phabricator.wikimedia.org/T179663EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LegoktmCc: bd808, Aklapper, Legoktm, greg, Lydia_Pintscher, daniel, thiemowmde, WMDE-leszek, Aleksey_WMDE, Jonas, hoo, aude, Agabi10, Lucas_Werkmeister_WMDE, Jdforrester-WMF, VColeman, demon, Liuxinyu970226, Jrbranaa, Ricordisamoa, Addshore, Lahi, SandraF_WMF, GoranSMilovanovic, QZanden, Liudvikas, Luke081515, Wikidata-bugs, Anomie, zeljkofilipin, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
