[Wikidata-bugs] [Maniphest] [Commented On] T180874: Ignore deprecated constraints in constraint tool

2018-01-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.
We also need to update Help:Property constraints portal. But I would’ve waited with that until the code to ignore deprecated constraints is actually deployed (hopefully next Wednesday).TASK DETAILhttps://phabricator.wikimedia.org/T180874EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: thiemowmde, Lydia_Pintscher, gerritbot, Sjoerddebruin, Lucas_Werkmeister_WMDE, Aklapper, Multichill, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T180874: Ignore deprecated constraints in constraint tool

2018-01-12 Thread Multichill
Multichill added a comment.
Thanks for implementing this. What's left is updating https://www.wikidata.org/wiki/Module:Property_documentation to make use of the deprecated rank. Left a message about that on https://www.wikidata.org/wiki/Template_talk:Property_documentation#Handle_property_constraint_with_rank_deprecatedTASK DETAILhttps://phabricator.wikimedia.org/T180874EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, MultichillCc: thiemowmde, Lydia_Pintscher, gerritbot, Sjoerddebruin, Lucas_Werkmeister_WMDE, Aklapper, Multichill, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T180874: Ignore deprecated constraints in constraint tool

2018-01-12 Thread gerritbot
gerritbot added a comment.
Change 403641 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Ignore deprecated constraints

https://gerrit.wikimedia.org/r/403641TASK DETAILhttps://phabricator.wikimedia.org/T180874EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: thiemowmde, Lydia_Pintscher, gerritbot, Sjoerddebruin, Lucas_Werkmeister_WMDE, Aklapper, Multichill, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T180874: Ignore deprecated constraints in constraint tool

2018-01-11 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.
I don’t think the “best statement” interpretation makes sense for property constraints. Constraint statements don’t hold a list of values of the same kind, of which one is (in whatever way) determined to be the best; they define special characteristics of a property, which are mainly identified by the constraint type, and the fact that they’re all statements of a single “property constraint” property is mainly a technical detail of the encoding IMHO. I don’t see why it would make sense not to check a “single value” constraint just because there is a “format” constraint with preferred rank. And if you take constraint scope into account as well, I think this interpretation gets even stranger.TASK DETAILhttps://phabricator.wikimedia.org/T180874EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: thiemowmde, Lydia_Pintscher, gerritbot, Sjoerddebruin, Lucas_Werkmeister_WMDE, Aklapper, Multichill, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T180874: Ignore deprecated constraints in constraint tool

2018-01-11 Thread gerritbot
gerritbot added a comment.
Change 403641 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Ignore deprecated constraints

https://gerrit.wikimedia.org/r/403641TASK DETAILhttps://phabricator.wikimedia.org/T180874EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Sjoerddebruin, Lucas_Werkmeister_WMDE, Aklapper, Multichill, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T180874: Ignore deprecated constraints in constraint tool

2017-12-15 Thread Sjoerddebruin
Sjoerddebruin added a comment.
I think it should just support the ranks, that's what people expect how it should work.TASK DETAILhttps://phabricator.wikimedia.org/T180874EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SjoerddebruinCc: Sjoerddebruin, Lucas_Werkmeister_WMDE, Aklapper, Multichill, Lahi, Gq86, GoranSMilovanovic, QZanden, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T180874: Ignore deprecated constraints in constraint tool

2017-12-15 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.
Hm, I just noticed – once we have the constraint scope parameter, a constraint scope of no value could also be used to disable a constraint. Not sure which is better. Any thoughts?TASK DETAILhttps://phabricator.wikimedia.org/T180874EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, Multichill, Lahi, Gq86, GoranSMilovanovic, QZanden, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs