gerritbot added a comment.
Change 412675 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove plain message CPE serializations from cache map
https://gerrit.wikimedia.org/r/412675TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL
gerritbot added a comment.
Change 411309 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage in ConstraintParameterParser
https://gerrit.wikimedia.org/r/411309TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL
gerritbot added a comment.
Change 411308 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Support ViolationMessage in ConstraintParameterException
https://gerrit.wikimedia.org/r/411308TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL
gerritbot added a comment.
Change 411307 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessageRenderer in CheckConstraintParameters
https://gerrit.wikimedia.org/r/411307TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL
gerritbot added a comment.
Change 411306 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Extract ConstraintParameterException serialization
https://gerrit.wikimedia.org/r/411306TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL
gerritbot added a comment.
Change 411305 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Use ConstraintParameterException::getViolationMessage()
https://gerrit.wikimedia.org/r/411305TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL
gerritbot added a comment.
Change 412675 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove plain message CPE serializations from cache map
https://gerrit.wikimedia.org/r/412675TASK
gerritbot added a comment.
Change 411307 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessageRenderer in CheckConstraintParameters
https://gerrit.wikimedia.org/r/411307TASK
gerritbot added a comment.
Change 411308 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Support ViolationMessage in ConstraintParameterException
https://gerrit.wikimedia.org/r/411308TASK
gerritbot added a comment.
Change 411309 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage in ConstraintParameterParser
https://gerrit.wikimedia.org/r/411309TASK
gerritbot added a comment.
Change 411306 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Extract ConstraintParameterException serialization
https://gerrit.wikimedia.org/r/411306TASK
gerritbot added a comment.
Change 411305 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use ConstraintParameterException::getViolationMessage()
https://gerrit.wikimedia.org/r/411305TASK
Lucas_Werkmeister_WMDE added a comment.
Regarding the transition period… I’m not sure if we even need to have one. At some point we will have to throw out invalid CPEs, and just doing it up-front shouldn’t hurt too much, I think. We have plenty of other checks that always hit WDQS, so I think a
gerritbot added a comment.
Change 410420 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Inject ViolationMessageSerializer and -Deserializer
https://gerrit.wikimedia.org/r/410420TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL
gerritbot added a comment.
Change 410420 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Inject ViolationMessageSerializer and -Deserializer
https://gerrit.wikimedia.org/r/410420TASK
Lucas_Werkmeister_WMDE added a comment.
Actually, the transition period will have to be a bit longer, since we need to support pre-rendered messages out of the SparqlHelper regexp cache for at least the duration of one deployment. And in fact we might need to find some mechanism to explicitly
16 matches
Mail list logo
