thiemowmde added a comment.
Personally I don't think it makes sense to split this into subtasks. Either update all codebases the same way, or none.
I furthermore suggest to close this as "declined" (as this is what the lack of interest by the Wikidata team tells me) and wait till PHPUnit 4
Addshore added a comment.
This looks like it is stalled, and could probably do with being broken down into sub tasks?
@thiemowmde @Lucas_Werkmeister_WMDE thoughts?TASK DETAILhttps://phabricator.wikimedia.org/T188011EMAIL
thiemowmde added a comment.
@Legoktm wrote:
Please don't do this until someone fixes the structure test […]
As argued in https://gerrit.wikimedia.org/r/413731 I feel asking people to not do stuff isn't the best approach. The least thing needed would be a PHPCS sniff that enforces all code bases
Lucas_Werkmeister_WMDE added a comment.
It won't cause CI to fail, it just means that the structure test is no longer checking those files.
Okay, I see – the structure test uses this regex to find test classes, then runs tests on them. Thanks!
I’ve uploaded a proposed commit to update
Legoktm added a comment.
In T188011#4001997, @Lucas_Werkmeister_WMDE wrote:
WikibaseLexeme already used the non-namespaced version last week: https://gerrit.wikimedia.org/r/410795 – why is this suddenly a problem now? Because WikibaseLexeme isn’t part of some standard build yet?
I or no one
Lucas_Werkmeister_WMDE added a comment.
And where does this “structure test” run? I haven’t heard of it before, and it doesn’t seem part of the CI on each change, otherwise https://gerrit.wikimedia.org/r/414642 couldn’t have been merged.TASK DETAILhttps://phabricator.wikimedia.org/T188011EMAIL
Lucas_Werkmeister_WMDE added a comment.
WikibaseLexeme already used the non-namespaced version last week: https://gerrit.wikimedia.org/r/410795 – why is this suddenly a problem now? Because WikibaseLexeme isn’t part of some standard build yet?TASK
Legoktm added a comment.
The suggestion is to not replace … extends \PHPUnit_Framework_TestCase with … extends \PHPUnit\Framework\TestCase, but with … extends TestCase and an import in the use section above. This fits better to the code style the Wikidata team is used to, where full qualified
gerritbot added a comment.
Change 414642 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Don’t extend fully qualified class name for TestCase
https://gerrit.wikimedia.org/r/414642TASK DETAILhttps://phabricator.wikimedia.org/T188011EMAIL
gerritbot added a comment.
Change 414642 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Don’t extend fully qualified class name for TestCase
https://gerrit.wikimedia.org/r/414642TASK
10 matches
Mail list logo
