[Wikidata-bugs] [Maniphest] [Commented On] T189329: jquery.wikibase qunit tests are flaky (Pending Ajax requests)
Jdlrobson added a comment. Maybe something else is hitting the API? Is there anyway, we could update QUnit to report outgoing API requests? e.g. if mw.ajax is called log a warning message that shows up in the node report detailing the URL and the test/extension making it? This would help a lot with debugging...TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Krinkle, JdlrobsonCc: Tgr, hashar, gerritbot, Reedy, Krinkle, dcausse, Jdlrobson, hoo, Mbch331, Jonas, TerraCodes, Gilles, Daimona, WMDE-leszek, SBisson, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Huji, Mholloway, Legoktm, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Volker_E, Wikidata-bugs, aude, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T189329: jquery.wikibase qunit tests are flaky (Pending Ajax requests)
hashar added a comment.
@Jdlrobson the QUnit output is a bit scrambled apparently. I have encountered the issue with AdvancedSearch which report a failure under the wrong test:
WARN: 'AJAX request #4 (state: pending)', Object{url: '/api.php?action=""
jquery.color
✖ animate
The AJAX request has been made by another test ( ext.advancedSearch.ui.DeepCategoryFilter ).TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Krinkle, hasharCc: Tgr, hashar, gerritbot, Reedy, Krinkle, dcausse, Jdlrobson, hoo, Mbch331, Jonas, TerraCodes, Gilles, Daimona, WMDE-leszek, SBisson, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Huji, Mholloway, Legoktm, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Volker_E, Wikidata-bugs, aude, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T189329: jquery.wikibase qunit tests are flaky (Pending Ajax requests)
Jdlrobson added a comment. @Krinkle the ajax requests in MobileFrontend were causing the complaint in "ext.wikiEditor.toolbar" https://integration.wikimedia.org/ci/job/mediawiki-core-qunit-selenium-jessie/19909/console and I suspect before that the complaints against jquery.wikibase.sitelinkview (since both related to 3 ajax requests) So although there was a complaint in the QUnit report the complaint should have been made inside the MobileFrontend test (unless https://gerrit.wikimedia.org/r/#/c/430671/1/view/tests/qunit/jquery/wikibase/jquery.wikibase.sitelinkview.tests.js is also hitting the API in this manner?)TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: Tgr, hashar, gerritbot, Reedy, Krinkle, dcausse, Jdlrobson, hoo, Mbch331, Jonas, TerraCodes, Liuxinyu970226, Niharika, Gilles, Daimona, WMDE-leszek, SBisson, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Huji, Mholloway, Legoktm, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Volker_E, Wikidata-bugs, aude, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T189329: jquery.wikibase qunit tests are flaky (Pending Ajax requests)
Krinkle added a comment. it's unfortunate the unit tests didn't complain in this browser test. Anyway we can get these more isolated? I'm not sure I understand. What exactly didn't complain where?TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Tgr, hashar, gerritbot, Reedy, Krinkle, dcausse, Jdlrobson, hoo, Mbch331, Jonas, TerraCodes, Liuxinyu970226, Niharika, Gilles, Daimona, WMDE-leszek, SBisson, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Huji, Mholloway, Legoktm, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Volker_E, Wikidata-bugs, aude, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T189329: jquery.wikibase qunit tests are flaky (Pending Ajax requests)
Jdlrobson added a comment. I think this is the issue: https://gerrit.wikimedia.org/r/430633 Don't trigger API requests during Qunit execution @Krinkle it's unfortunate the unit tests didn't complain in this browser test. Anyway we can get these more isolated? I think once that patch is merged https://gerrit.wikimedia.org/r/430494 can probably be reverted..?TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: Tgr, hashar, gerritbot, Reedy, Krinkle, dcausse, Jdlrobson, hoo, Mbch331, Jonas, TerraCodes, Liuxinyu970226, Niharika, Gilles, Daimona, WMDE-leszek, SBisson, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Huji, Mholloway, Legoktm, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Volker_E, Wikidata-bugs, aude, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T189329: jquery.wikibase qunit tests are flaky (Pending Ajax requests)
Jdlrobson added a comment. Investigating this some more and given the new failures I think there is not a fault in Wikibase here but an extensions who's tests are alphabetically run earlier. I'm looking into that now and if I can I will revert the above patchset.TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: Tgr, hashar, gerritbot, Reedy, Krinkle, dcausse, Jdlrobson, hoo, Mbch331, Jonas, TerraCodes, Liuxinyu970226, Niharika, Gilles, Daimona, WMDE-leszek, SBisson, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Huji, Mholloway, Legoktm, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Volker_E, Wikidata-bugs, aude, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T189329: jquery.wikibase qunit tests are flaky (Pending Ajax requests)
Jdlrobson added a comment. Similar issues now showing up in ext.wikiEditor.toolbar https://integration.wikimedia.org/ci/job/mediawiki-core-qunit-selenium-jessie/19909/console It seems like there are some ajax requests being made during the unit tests.TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: Tgr, hashar, gerritbot, Reedy, Krinkle, dcausse, Jdlrobson, hoo, Mbch331, Jonas, TerraCodes, Liuxinyu970226, Niharika, Gilles, Daimona, WMDE-leszek, SBisson, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Huji, Mholloway, Legoktm, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Volker_E, Wikidata-bugs, aude, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T189329: jquery.wikibase qunit tests are flaky (Pending Ajax requests)
gerritbot added a comment. Change 430494 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Skip tests failing in CI https://gerrit.wikimedia.org/r/430494TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Tgr, hashar, gerritbot, Reedy, Krinkle, dcausse, Jdlrobson, hoo, Mbch331, Jonas, TerraCodes, Liuxinyu970226, Niharika, Gilles, Daimona, WMDE-leszek, SBisson, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Huji, Mholloway, Legoktm, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Volker_E, Wikidata-bugs, aude, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T189329: jquery.wikibase qunit tests are flaky (Pending Ajax requests)
gerritbot added a comment. Change 430494 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson): [mediawiki/extensions/Wikibase@master] Skip tests failing in CI https://gerrit.wikimedia.org/r/430494TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Tgr, hashar, gerritbot, Reedy, Krinkle, dcausse, Jdlrobson, hoo, Mbch331, Jonas, TerraCodes, Liuxinyu970226, Niharika, Gilles, Daimona, WMDE-leszek, SBisson, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Huji, Mholloway, Legoktm, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Volker_E, Wikidata-bugs, aude, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T189329: jquery.wikibase qunit tests are flaky (Pending Ajax requests)
Jdlrobson added a comment. This is blocking the merge of core change https://gerrit.wikimedia.org/r/#/c/424165/ and probably lots of other changes in core. Unbreak now..?TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: Tgr, hashar, gerritbot, Reedy, Krinkle, dcausse, Jdlrobson, hoo, Mbch331, Jonas, TerraCodes, Liuxinyu970226, Niharika, Gilles, Daimona, WMDE-leszek, SBisson, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Huji, Mholloway, Legoktm, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Volker_E, Wikidata-bugs, aude, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
