gerritbot added a comment.
Change 485577 merged by Krinkle:
[mediawiki/extensions/Wikibase@master] Remove redundant defined() checks
https://gerrit.wikimedia.org/r/485577TASK DETAILhttps://phabricator.wikimedia.org/T189538EMAIL
gerritbot added a comment.
Change 485577 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/Wikibase@master] Use require_once instead of include_once
https://gerrit.wikimedia.org/r/485577TASK DETAILhttps://phabricator.wikimedia.org/T189538EMAIL
Krinkle added a comment.
Looking much better:
F27969638: Screen Shot 2019-01-20 at 17.14.30.pngTASK DETAILhttps://phabricator.wikimedia.org/T189538EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Lydia_Pintscher, gerritbot, thiemowmde, WMDE-leszek,
Krinkle added a comment.
The remaining work here is to apply "Reduce indirection in resources files" to the rest of Wikibase. The above commit (https://gerrit.wikimedia.org/r/419334) was merely an example for one of the modules (view/wikibase-data-model).TASK
gerritbot added a comment.
Change 419334 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Reduce indirection in resources files for view/wikibase-{api,data-model}
https://gerrit.wikimedia.org/r/419334TASK DETAILhttps://phabricator.wikimedia.org/T189538EMAIL
gerritbot added a comment.
Change 419335 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Merge view/init.mw.php into view/WikibaseView.php
https://gerrit.wikimedia.org/r/419335TASK DETAILhttps://phabricator.wikimedia.org/T189538EMAIL
gerritbot added a comment.
Change 419333 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Module definition: Remove dynamic matching
https://gerrit.wikimedia.org/r/419333TASK DETAILhttps://phabricator.wikimedia.org/T189538EMAIL
gerritbot added a comment.
Change 419489 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Inline WikibaseView resource files directly accessing global vars
https://gerrit.wikimedia.org/r/419489TASK DETAILhttps://phabricator.wikimedia.org/T189538EMAIL
gerritbot added a comment.
Change 419489 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Wikibase@master] Inline WikibaseView resource files directly accessing global vars
https://gerrit.wikimedia.org/r/419489TASK
Krinkle added a comment.
@thiemowmde Sounds like a good point to start. I won't press on the file reduction for now.
I've published three patches to start the conversation. Feel free to take over at any moment as you see fit, e.g. by amending or by forking to a different change-id and abandoning
gerritbot added a comment.
Change 419335 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/Wikibase@master] [WIP] Module registration: Keep global var handling central
https://gerrit.wikimedia.org/r/419335TASK DETAILhttps://phabricator.wikimedia.org/T189538EMAIL
gerritbot added a comment.
Change 419334 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/Wikibase@master] [WIP] Module definition: Reduce some indirection in resources files
https://gerrit.wikimedia.org/r/419334TASK
gerritbot added a comment.
Change 419333 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/Wikibase@master] [WIP] Module definition: Remove dynamic matching
https://gerrit.wikimedia.org/r/419333TASK DETAILhttps://phabricator.wikimedia.org/T189538EMAIL
13 matches
Mail list logo
