gerritbot added a comment.
Change 420993 abandoned by Lucas Werkmeister (WMDE):
Revert "Work around CheckingResultsBuilder bug"
Reason:
CachingResultsBuilder has been removed and we never copied this workaround to its successor, CachingResultsSource.
https://gerrit.wikimedia.org/r/420993TASK
thiemowmde added a comment.
Guys, please communicate. This back-and-forth does not look like fun.TASK DETAILhttps://phabricator.wikimedia.org/T189842EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, thiemowmdeCc: thiemowmde, Jonas,
gerritbot added a comment.
Change 420993 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Revert "Work around CheckingResultsBuilder bug"
https://gerrit.wikimedia.org/r/420993TASK
gerritbot added a comment.
Change 420321 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Ensure that result is populated even for empty entities
https://gerrit.wikimedia.org/r/420321TASK DETAILhttps://phabricator.wikimedia.org/T189842EMAIL
gerritbot added a comment.
Change 420320 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add EntityContextCursor
https://gerrit.wikimedia.org/r/420320TASK DETAILhttps://phabricator.wikimedia.org/T189842EMAIL
gerritbot added a comment.
Change 420319 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Replace NullResult’s Context with ContextCursor
https://gerrit.wikimedia.org/r/420319TASK DETAILhttps://phabricator.wikimedia.org/T189842EMAIL
gerritbot added a comment.
Change 420010 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Work around CheckingResultsBuilder bug
https://gerrit.wikimedia.org/r/420010TASK DETAILhttps://phabricator.wikimedia.org/T189842EMAIL
gerritbot added a comment.
Change 420321 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Ensure that result is populated even for empty entities
https://gerrit.wikimedia.org/r/420321TASK
gerritbot added a comment.
Change 420319 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Replace NullResult’s Context with ContextCursor
https://gerrit.wikimedia.org/r/420319TASK
gerritbot added a comment.
Change 420320 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add EntityContextCursor
https://gerrit.wikimedia.org/r/420320TASK
Lucas_Werkmeister_WMDE added a comment.
This is already a violation of the wbcheckconstraints API, I think (consumers should probably be able to expect the entity ID and an empty claims array, at least)
Well, not quite… we actually work around this in CheckConstraints.php itself, so the API
Lucas_Werkmeister_WMDE added a comment.
I uploaded a workaround to fix the PHP warning at least; do you think this is serious enough to warrant a backport?TASK DETAILhttps://phabricator.wikimedia.org/T189842EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
gerritbot added a comment.
Change 420010 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Work around CheckingResultsBuilder bug
https://gerrit.wikimedia.org/r/420010TASK
13 matches
Mail list logo