[Wikidata-bugs] [Maniphest] [Commented On] T191981: Enable finding forms using wbsearchentities API

2018-04-26 Thread WMDE-leszek
WMDE-leszek added a comment. Very cool!TASK DETAILhttps://phabricator.wikimedia.org/T191981EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, WMDE-leszekCc: Lea_Lacroix_WMDE, Smalyshev, gerritbot, Lydia_Pintscher, Aklapper, thiemowmde, Jonas,

[Wikidata-bugs] [Maniphest] [Commented On] T191981: Enable finding forms using wbsearchentities API

2018-04-25 Thread Smalyshev
Smalyshev added a comment. Also https://wikidata-lexeme.wmflabs.org/api.php?action=""> works now.TASK DETAILhttps://phabricator.wikimedia.org/T191981EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, SmalyshevCc: Lea_Lacroix_WMDE, Smalyshev, gerritbot,

[Wikidata-bugs] [Maniphest] [Commented On] T191981: Enable finding forms using wbsearchentities API

2018-04-25 Thread WMDE-leszek
WMDE-leszek added a comment. Re documentation of API (description extended and example using Q-ID as a search term added https://www.wikidata.org/w/api.php?action="">)TASK DETAILhttps://phabricator.wikimedia.org/T191981EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T191981: Enable finding forms using wbsearchentities API

2018-04-25 Thread WMDE-leszek
WMDE-leszek added a comment. https://wikidata-lexeme.wmflabs.org/api.php?action="">TASK DETAILhttps://phabricator.wikimedia.org/T191981EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, WMDE-leszekCc: Lea_Lacroix_WMDE, Smalyshev, gerritbot,

[Wikidata-bugs] [Maniphest] [Commented On] T191981: Enable finding forms using wbsearchentities API

2018-04-25 Thread Lea_Lacroix_WMDE
Lea_Lacroix_WMDE added a comment. Can I haz testlink? TASK DETAILhttps://phabricator.wikimedia.org/T191981EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, Lea_Lacroix_WMDECc: Lea_Lacroix_WMDE, Smalyshev, gerritbot, Lydia_Pintscher, Aklapper,

[Wikidata-bugs] [Maniphest] [Commented On] T191981: Enable finding forms using wbsearchentities API

2018-04-20 Thread gerritbot
gerritbot added a comment. Change 427367 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Enabled finding forms using their IDs https://gerrit.wikimedia.org/r/427367TASK DETAILhttps://phabricator.wikimedia.org/T191981EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T191981: Enable finding forms using wbsearchentities API

2018-04-19 Thread WMDE-leszek
WMDE-leszek added a comment. @Smalyshev: sorry, I failed to leave the comment here yesterday. What you have shown would have worked for the search use case, but @Addshore made a more universal and there should be no more complaints about form not being an entity type. Please report back if there

[Wikidata-bugs] [Maniphest] [Commented On] T191981: Enable finding forms using wbsearchentities API

2018-04-18 Thread gerritbot
gerritbot added a comment. Change 427322 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Split EntityId SearchHelper From EntitySearchTermIndex https://gerrit.wikimedia.org/r/427322TASK DETAILhttps://phabricator.wikimedia.org/T191981EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T191981: Enable finding forms using wbsearchentities API

2018-04-18 Thread gerritbot
gerritbot added a comment. Change 427367 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek): [mediawiki/extensions/WikibaseLexeme@master] Enabled finding forms using their IDs https://gerrit.wikimedia.org/r/427367TASK DETAILhttps://phabricator.wikimedia.org/T191981EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T191981: Enable finding forms using wbsearchentities API

2018-04-18 Thread gerritbot
gerritbot added a comment. Change 427169 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Define form as a sub entity type of lexeme https://gerrit.wikimedia.org/r/427169TASK DETAILhttps://phabricator.wikimedia.org/T191981EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T191981: Enable finding forms using wbsearchentities API

2018-04-18 Thread gerritbot
gerritbot added a comment. Change 426936 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Provide a way to register sub entity types https://gerrit.wikimedia.org/r/426936TASK DETAILhttps://phabricator.wikimedia.org/T191981EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T191981: Enable finding forms using wbsearchentities API

2018-04-18 Thread gerritbot
gerritbot added a comment. Change 427322 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/Wikibase@master] Split EntityId SearchHelper From EntitySearchTermIndex https://gerrit.wikimedia.org/r/427322TASK DETAILhttps://phabricator.wikimedia.org/T191981EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T191981: Enable finding forms using wbsearchentities API

2018-04-17 Thread Smalyshev
Smalyshev added a comment. This patch works for me - though it introduces a subtle link between term helper dispatcher and the API. But otherwise it makes sense - search works for types that have search helpers defined. iff --git a/repo/Wikibase.php b/repo/Wikibase.php index 368a6ce..ebca90b

[Wikidata-bugs] [Maniphest] [Commented On] T191981: Enable finding forms using wbsearchentities API

2018-04-17 Thread gerritbot
gerritbot added a comment. Change 427169 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/WikibaseLexeme@master] WIP define form as a sub entity type of lexeme https://gerrit.wikimedia.org/r/427169TASK DETAILhttps://phabricator.wikimedia.org/T191981EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T191981: Enable finding forms using wbsearchentities API

2018-04-16 Thread gerritbot
gerritbot added a comment. Change 426902 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Update wbsearchentities description, it can also search IDs https://gerrit.wikimedia.org/r/426902TASK DETAILhttps://phabricator.wikimedia.org/T191981EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T191981: Enable finding forms using wbsearchentities API

2018-04-16 Thread gerritbot
gerritbot added a comment. Change 426900 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add wbsearchentities example for entity ID search https://gerrit.wikimedia.org/r/426900TASK DETAILhttps://phabricator.wikimedia.org/T191981EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T191981: Enable finding forms using wbsearchentities API

2018-04-16 Thread gerritbot
gerritbot added a comment. Change 426936 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/Wikibase@master] DNM WIP DRAFT Add seperate setting for enabling entity types https://gerrit.wikimedia.org/r/426936TASK

[Wikidata-bugs] [Maniphest] [Commented On] T191981: Enable finding forms using wbsearchentities API

2018-04-16 Thread gerritbot
gerritbot added a comment. Change 426902 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/Wikibase@master] Update wbsearchentities description, it can also search IDs https://gerrit.wikimedia.org/r/426902TASK

[Wikidata-bugs] [Maniphest] [Commented On] T191981: Enable finding forms using wbsearchentities API

2018-04-16 Thread gerritbot
gerritbot added a comment. Change 426900 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/Wikibase@master] Add wbsearchentities example for entity ID search https://gerrit.wikimedia.org/r/426900TASK DETAILhttps://phabricator.wikimedia.org/T191981EMAIL