gerritbot added a comment.
Change 427682 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/Wikibase@master] Add haswbstatement CirrusSearch query feature
https://gerrit.wikimedia.org/r/427682TASK DETAILhttps://phabricator.wikimedia.org/T192345EMAIL
gerritbot added a comment.
Change 427407 abandoned by Cparle:
Add haswbstatement feature
Reason:
Patch in the wrong repo
https://gerrit.wikimedia.org/r/427407TASK DETAILhttps://phabricator.wikimedia.org/T192345EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Smalyshev added a comment.
Hmm I think @Cparle is right, for search it doesn't matter whether it's string or Q-id.TASK DETAILhttps://phabricator.wikimedia.org/T192345EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Cparle, SmalyshevCc: gerritbot, Ramsey-WMF,
gerritbot added a comment.
Change 427407 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/CirrusSearch@master] Add haswbstatement feature
https://gerrit.wikimedia.org/r/427407TASK DETAILhttps://phabricator.wikimedia.org/T192345EMAIL
Cparle added a comment.
From a strictly searching perspective I can't see that it matters
Say for arguments sake that on commons we allow statements with the wikidata property 'depicts' P180 (contains a wikidata Q-ID) and 'MoMA artwork id' P2014 (contains an external id). We whitelist these for
Lydia_Pintscher added a comment.
There will be more and more 3rd party Wikibase installations. Some of them will be linked to in statements as external identifiers. They will also use Q-IDs. So you can not be sure that a Q-ID always represents an item on Wikidata.TASK
Cparle added a comment.
Statements are stored in the index as strings, just in the format X=Y right? Don't understand why we'd need different keywords for matching P999=Q888 and P777=some_stringTASK DETAILhttps://phabricator.wikimedia.org/T192345EMAIL
Smalyshev added a comment.
This seems to be mostly duplicate of T163642, only applied to File and Wikibase instance for Commons (MediaInfo?).
One question to resolve: P999=Q888 assumes the part after = is an entity ID. However, in T163642 and T99899 it could be a string. We will need syntax for
Cparle added a comment.
Nitpick: we might consider naming the keyword differently so that it aligns with what we already have (insomething or hassomething). Why not something like haswbstatement?
Cool, haswbstatement it isTASK DETAILhttps://phabricator.wikimedia.org/T192345EMAIL
dcausse added a comment.
This should be pretty straightforward to do.
Nitpick: we might consider naming the keyword differently so that it aligns with what we already have (insomething or hassomething). Why not something like haswbstatement?TASK DETAILhttps://phabricator.wikimedia.org/T192345EMAIL
10 matches
Mail list logo