[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
Multichill added a comment. In T194950#4420642, @Addshore wrote: There are still some bots and tools that are not setting appropriate maxlag values for their requests but we can follow up elsewhere with that. Please list them on https://www.wikidata.org/wiki/Wikidata:Administrators%27_noticeboard and the accounts will be blocked.TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, MultichillCc: Stashbot, Aklapper, gerritbot, pywikibot-bugs-list, ValterVB, Lea_Lacroix_WMDE, Legoktm, Addshore, MisterSynergy, Magnus, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Ricordisamoa, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
Addshore added a comment. Looks like this is all done, and it looks like yesterday for a couple of periods the dispatch lag was high and the maxlag as a result was higher. F23686506: image.png It looks like roughly ~6000 requests were stopped due to max lag out of ~20 made yesterday There are still some bots and tools that are not setting appropriate maxlag values for their requests but we can follow up elsewhere with that.TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, AddshoreCc: Stashbot, Aklapper, gerritbot, pywikibot-bugs-list, ValterVB, Lea_Lacroix_WMDE, Legoktm, Addshore, MisterSynergy, Magnus, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Ricordisamoa, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2018-07-05T18:21:19Z] Synchronized wmf-config/Wikibase-production.php: SWAT: [[gerrit:443939|Set dispatchLagToMaxLagFactor to 60 for wikidata]] T194950 (duration: 00m 51s)TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, StashbotCc: Stashbot, Aklapper, gerritbot, pywikibot-bugs-list, ValterVB, Lea_Lacroix_WMDE, Legoktm, Addshore, MisterSynergy, Magnus, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Ricordisamoa, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
gerritbot added a comment. Change 443939 merged by jenkins-bot: [operations/mediawiki-config@master] Set dispatchLagToMaxLagFactor to 60 for wikidata https://gerrit.wikimedia.org/r/443939TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: Aklapper, gerritbot, pywikibot-bugs-list, ValterVB, Lea_Lacroix_WMDE, Legoktm, Addshore, MisterSynergy, Magnus, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Ricordisamoa, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
gerritbot added a comment. Change 443939 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani): [operations/mediawiki-config@master] Set dispatchLagToMaxLagFactor to 60 for wikidata https://gerrit.wikimedia.org/r/443939TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: Aklapper, gerritbot, pywikibot-bugs-list, ValterVB, Lea_Lacroix_WMDE, Legoktm, Addshore, MisterSynergy, Magnus, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Andrewjhill, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Ricordisamoa, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
Magnus added a comment. In T194950#4391332, @Addshore wrote: In T194950#4322078, @Magnus wrote: Excellent, that means my existing code should Just Work (tm). I just checked some of the API logs and it looks like QuickStatementsBot isn't currently passing a maxlag? It's currently the biggest api caller for wikidata that isn't passing it. I should: https://bitbucket.org/magnusmanske/magnustools/src/c76cc1a06cbd015c12046755a58608cb2aa496d1/public_html/php/oauth.php#lines-416 Unless I'm using it wrong... It does look for the error anyway: https://bitbucket.org/magnusmanske/magnustools/src/c76cc1a06cbd015c12046755a58608cb2aa496d1/public_html/php/oauth.php#lines-516TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, MagnusCc: Aklapper, gerritbot, pywikibot-bugs-list, ValterVB, Lea_Lacroix_WMDE, Legoktm, Addshore, MisterSynergy, Magnus, daniel, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Ricordisamoa, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
Lea_Lacroix_WMDE added a comment. Small change: the feature will be activated on Thursday July 5th instead of today.TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, Lea_Lacroix_WMDECc: Aklapper, gerritbot, pywikibot-bugs-list, ValterVB, Lea_Lacroix_WMDE, Legoktm, Addshore, MisterSynergy, Magnus, daniel, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Ricordisamoa, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
Addshore added a comment. In T194950#4322078, @Magnus wrote: Excellent, that means my existing code should Just Work (tm). I just checked some of the API logs and it looks like QuickStatementsBot isn't currently passing a maxlag? It's currently the biggest api caller for wikidata that isn't passing it.TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, AddshoreCc: Aklapper, gerritbot, pywikibot-bugs-list, ValterVB, Lea_Lacroix_WMDE, Legoktm, Addshore, MisterSynergy, Magnus, daniel, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Ricordisamoa, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
Anomie added a comment. In T194950#4322078, @Magnus wrote: maxlag does not appear to be documented for the query action... That's because it's a parameter to the "main" module, not the query action.TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, AnomieCc: Aklapper, gerritbot, pywikibot-bugs-list, ValterVB, Lea_Lacroix_WMDE, Legoktm, Addshore, MisterSynergy, Magnus, daniel, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Ricordisamoa, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
Multichill added a comment. In T194950#4322078, @Magnus wrote: Excellent, that means my existing code should Just Work (tm). Is the "lag" value in the API reply in seconds? maxlag does not appear to be documented for the query action... Yes it is in seconds. See https://www.mediawiki.org/wiki/Manual:Maxlag_parameter for more infoTASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, MultichillCc: ValterVB, Lea_Lacroix_WMDE, Legoktm, Addshore, gerritbot, MisterSynergy, Magnus, Aklapper, daniel, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
Magnus added a comment. Excellent, that means my existing code should Just Work (tm). Is the "lag" value in the API reply in seconds? maxlag does not appear to be documented for the query action...TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, MagnusCc: Lea_Lacroix_WMDE, Legoktm, Addshore, gerritbot, MisterSynergy, Magnus, Aklapper, daniel, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
Lea_Lacroix_WMDE added a comment. Will be activated on July 3rd. Has been announced today.TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, Lea_Lacroix_WMDECc: Lea_Lacroix_WMDE, Legoktm, Addshore, gerritbot, MisterSynergy, Magnus, Aklapper, daniel, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
Ladsgroup added a comment. In T194950#4314787, @Addshore wrote: In T194950#4314730, @Ladsgroup wrote: The highest one only In which case without any sort of dedicated api endpoint it will be impossible for T196868 to track only the new maxlag that we have added. Instead the task will just have to track the maxlag of wikidata in general. Getting dispatch-related maxlag of wikidata is already done, You just get the value of median of dispatch lag and divide it by 60.TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Legoktm, Addshore, gerritbot, MisterSynergy, Magnus, Aklapper, daniel, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
Ladsgroup added a comment. The highest one onlyTASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Legoktm, Addshore, gerritbot, MisterSynergy, Magnus, Aklapper, daniel, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
Addshore added a comment. @Ladsgroup with the current implementation will a query with maxlag=-1 show both maxlag values, or just one?TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, AddshoreCc: Legoktm, Addshore, gerritbot, MisterSynergy, Magnus, Aklapper, daniel, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
Ladsgroup added a comment. ^ This enables it on beta cluster. We need to do similar thing for prod once the patch gets deployed (Wednesday afternoon)TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Legoktm, Addshore, gerritbot, MisterSynergy, Magnus, Aklapper, daniel, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
gerritbot added a comment. Change 441857 merged by jenkins-bot: [operations/mediawiki-config@master] labs: set dispatchLagToMaxLagFactor to 60 https://gerrit.wikimedia.org/r/441857TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: Legoktm, Addshore, gerritbot, MisterSynergy, Magnus, Aklapper, daniel, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
gerritbot added a comment. Change 441857 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani): [operations/mediawiki-config@master] labs: set dispatchLagToMaxLagFactor to 60 https://gerrit.wikimedia.org/r/441857TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: Legoktm, Addshore, gerritbot, MisterSynergy, Magnus, Aklapper, daniel, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
Ladsgroup added a comment. In T194950#4311445, @Addshore wrote: How can this maxlag be retrieved by the API? https://wikidata.beta.wmflabs.org/w/api.php?action=""> seems to just show the old max lag still We need to enable it. I do it right now (on beta)TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Legoktm, Addshore, gerritbot, MisterSynergy, Magnus, Aklapper, daniel, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
Addshore added a comment. How can this maxlag be retrieved by the API? https://wikidata.beta.wmflabs.org/w/api.php?action=""> seems to just show the old max lag stillTASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, AddshoreCc: Legoktm, Addshore, gerritbot, MisterSynergy, Magnus, Aklapper, daniel, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
gerritbot added a comment. Change 436561 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Include Wikibase dispatch lag in API "maxlag" enforcing https://gerrit.wikimedia.org/r/436561TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: Legoktm, Addshore, gerritbot, MisterSynergy, Magnus, Aklapper, daniel, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
Addshore added a comment. In T194950#4270985, @Legoktm wrote: In T194950#4270978, @Addshore wrote: I stand by what I said before in that exposing the dispatch lage is not as clear cut as exposing max DB lag. It requires clients to make the decision, at what point is the dispatch lag too much? when should I stop? The general advice is that clients should back off at maxlag=5. So Wikibase should determine some threshold of dispatch lag of when it wants clients to backoff, and then come up with a factor to scale it down to 5 "seconds". I don't think clients should make decisions here, aside from picking how many "seconds" (not really) to backoff at. Oh good, that's already been done in the patch :) I had this comment sitting here for a while but hadn't hit submit yet!TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, AddshoreCc: Legoktm, Addshore, gerritbot, MisterSynergy, Magnus, Aklapper, daniel, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
Legoktm added a comment. In T194950#4270978, @Addshore wrote: I stand by what I said before in that exposing the dispatch lage is not as clear cut as exposing max DB lag. It requires clients to make the decision, at what point is the dispatch lag too much? when should I stop? The general advice is that clients should back off at maxlag=5. So Wikibase should determine some threshold of dispatch lag of when it wants clients to backoff, and then come up with a factor to scale it down to 5 "seconds". I don't think clients should make decisions here, aside from picking how many "seconds" (not really) to backoff at.TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, LegoktmCc: Legoktm, Addshore, gerritbot, MisterSynergy, Magnus, Aklapper, daniel, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
Addshore added a comment. I stand by what I said before in that exposing the dispatch lage is not as clear cut as exposing max DB lag. It requires clients to make the decision, at what point is the dispatch lag too much? when should I stop?TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, AddshoreCc: Addshore, gerritbot, MisterSynergy, Magnus, Aklapper, daniel, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
gerritbot added a comment. Change 436543 merged by jenkins-bot: [mediawiki/core@master] Introduce ApiMaxLagInfo hook https://gerrit.wikimedia.org/r/436543TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: Addshore, gerritbot, MisterSynergy, Magnus, Aklapper, daniel, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
Ladsgroup added a comment. I get this done in my 20% campsite time TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Addshore, gerritbot, MisterSynergy, Magnus, Aklapper, daniel, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
Addshore added a comment. @Ladsgroup will you continue this as part of you 20% campsite time? or would you rather someone else take this over?TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, AddshoreCc: Addshore, gerritbot, MisterSynergy, Magnus, Aklapper, daniel, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
gerritbot added a comment. Change 436561 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani): [mediawiki/extensions/Wikibase@master] Include Wikibase dispatch lag in API "maxlag" enforcing https://gerrit.wikimedia.org/r/436561TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: gerritbot, MisterSynergy, Magnus, Aklapper, daniel, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
gerritbot added a comment. Change 436543 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani): [mediawiki/core@master] Introduce MaxLagInfo hook https://gerrit.wikimedia.org/r/436543TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: gerritbot, MisterSynergy, Magnus, Aklapper, daniel, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Lahi, Gq86, GoranSMilovanovic, lisong, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
Anomie added a comment. In T194950#4213723, @hoo wrote Alternatively Wikibase could overwrite ApiMain::checkMaxLag in its API subclasses… but that's probably the worse solution. To actually make that work you'd need to override the ApiMain object itself. That's probably a very bad idea.TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: Magnus, Aklapper, daniel, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
