[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

gerritbot added a comment. Change 460918 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Move ResultsSource to services https://gerrit.wikimedia.org/r/460918TASK DETAILhttps://phabricator.wikimedia.org/T196053EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settin

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

gerritbot added a comment. Change 460913 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Extract Wikibase services from default service wiring https://gerrit.wikimedia.org/r/460913TASK DETAILhttps://phabricator.wikimedia.org/T196053EMAIL PREFERENCEShttps://phabricat

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

gerritbot added a comment. Change 459802 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Move constraint checkers and DelegatingConstraintChecker to services https://gerrit.wikimedia.org/r/459802TASK DETAILhttps://phabricator.wikimedia.org/T196053EMAIL PREFERENCESht

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

Jonas added a comment. Is this done now?TASK DETAILhttps://phabricator.wikimedia.org/T196053EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, JonasCc: Jonas, Aklapper, gerritbot, Addshore, Lucas_Werkmeister_WMDE, Ladsgroup, Gaboe420, Vers

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

gerritbot added a comment. Change 460918 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Move ResultsSource to services https://gerrit.wikimedia.org/r/460918TASK DETAILhttps://phabricator.wiki

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

gerritbot added a comment. Change 460913 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Extract Wikibase services from default service wiring https://gerrit.wikimedia.org/r/460913TASK DETAILh

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

gerritbot added a comment. Change 459801 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Register two Wikibase services with MediaWikiServices https://gerrit.wikimedia.org/r/459801TASK DETAILhttps://phabricator.wikimedia.org/T196053EMAIL PREFERENCEShttps://phabricat

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

gerritbot added a comment. Change 459802 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Move constraint checkers and DelegatingConstraintChecker to services https://gerrit.wikimedia.org/r/459

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

gerritbot added a comment. Change 459801 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Register two Wikibase services with MediaWikiServices https://gerrit.wikimedia.org/r/459801TASK DETAILh

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

gerritbot added a comment. Change 441905 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Move four helper classes to services https://gerrit.wikimedia.org/r/441905TASK DETAILhttps://phabricator.wikimedia.org/T196053EMAIL PREFERENCEShttps://phabricator.wikimedia.org/

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

gerritbot added a comment. Change 457493 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Replace null SparqlHelper with DummySparqlHelper https://gerrit.wikimedia.org/r/457493TASK DETAILhttps://phabricator.wikimedia.org/T196053EMAIL PREFERENCEShttps://phabricator.wi

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

gerritbot added a comment. Change 457493 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Replace null SparqlHelper with DummySparqlHelper https://gerrit.wikimedia.org/r/457493TASK DETAILhttps:

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

Lucas_Werkmeister_WMDE added a comment. Well, it was blocked for a while on SparqlHelper, which can’t trivially be made into a service because it’s sometimes null. The result of the discussion on Discourse was that there are two ways forward: Hack: Add some kind of DummySparqlHelper which we use

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

Addshore added a comment. @Lucas_Werkmeister_WMDE what's the status of this one? It has been in doing on the campsite for quite some time, perhaps we should come up with a final list of the things that need to be moved to use MediaWikiServices and make some sub tasks so it is more manageable and ca

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

Addshore added a comment. In T196053#4272028, @Lucas_Werkmeister_WMDE wrote: I’m a bit confused about the use of MediaWikiServices there. Consider the following snippet of Cognate’s ServiceWiring.php: 'CognateRepo' => function ( MediaWikiServices $services ) { $repo = new CognateRepo( Cogna

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

gerritbot added a comment. Change 441905 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Move four helper classes to services https://gerrit.wikimedia.org/r/441905TASK DETAILhttps://phabricato

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

gerritbot added a comment. Change 439962 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Move ConstraintParameterParser to services https://gerrit.wikimedia.org/r/439962TASK DETAILhttps://phabricator.wikimedia.org/T196053EMAIL PREFERENCEShttps://phabricator.wikimedi

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

gerritbot added a comment. Change 439953 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Move ViolationMessageSerializer+Deserializer to services https://gerrit.wikimedia.org/r/439953TASK DETAILhttps://phabricator.wikimedia.org/T196053EMAIL PREFERENCEShttps://phabri

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

gerritbot added a comment. Change 439934 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Extract constants for service names https://gerrit.wikimedia.org/r/439934TASK DETAILhttps://phabricator.wikimedia.org/T196053EMAIL PREFERENCEShttps://phabricator.wikimedia.org/s

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

gerritbot added a comment. Change 439620 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Move CheckResultSerializer+Deserializer to services https://gerrit.wikimedia.org/r/439620TASK DETAILhttps://phabricator.wikimedia.org/T196053EMAIL PREFERENCEShttps://phabricator

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

gerritbot added a comment. Change 439962 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Move ConstraintParameterParser to services https://gerrit.wikimedia.org/r/439962TASK DETAILhttps://phab

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

Lucas_Werkmeister_WMDE added a comment. @Ladsgroup are you aware of any existing task to use MediaWikiServices in Wikibase itself? Because a lot of our services depend on Wikibase services, which we currently get from WikibaseRepo::getDefaultInstance().TASK DETAILhttps://phabricator.wikimedia.org/T

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

gerritbot added a comment. Change 439953 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Move ViolationMessageSerializer+Deserializer to services https://gerrit.wikimedia.org/r/439953TASK DETA

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

gerritbot added a comment. Change 439934 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Extract constants for service names https://gerrit.wikimedia.org/r/439934TASK DETAILhttps://phabricator

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

gerritbot added a comment. Change 439619 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Move ConstraintRepository+ConstraintLookup to services https://gerrit.wikimedia.org/r/439619TASK DETAILhttps://phabricator.wikimedia.org/T196053EMAIL PREFERENCEShttps://phabrica

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

gerritbot added a comment. Change 439618 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Set up ServiceWiring, add LoggingHelper service https://gerrit.wikimedia.org/r/439618TASK DETAILhttps://phabricator.wikimedia.org/T196053EMAIL PREFERENCEShttps://phabricator.wik

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

Lucas_Werkmeister_WMDE added a comment. I’ve started moving some services into service wiring. To solve the problem described above, the ConstraintsServices methods take an optional $services parameter to use that MediaWikiServices instance instead of the default one.TASK DETAILhttps://phabricator.

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

gerritbot added a comment. Change 439618 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Set up ServiceWiring, add LoggingHelper service https://gerrit.wikimedia.org/r/439618TASK DETAILhttps:/

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

gerritbot added a comment. Change 439620 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Move CheckResultSerializer+Deserializer to services https://gerrit.wikimedia.org/r/439620TASK DETAILhtt

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

gerritbot added a comment. Change 439619 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Move ConstraintRepository+ConstraintLookup to services https://gerrit.wikimedia.org/r/439619TASK DETAIL