Lydia_Pintscher added a comment.
From my side this is fine. @Addshore: I'll let you close it.TASK DETAILhttps://phabricator.wikimedia.org/T197212EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, Lydia_PintscherCc: Lydia_Pintscher, Ladsgroup, johl,
dbs added a comment.
At this point I would recommend looking at https://github.com/dbs/wikibase-docker/tree/wikibase-1.31 - I started again from current master. Much cleaner.TASK DETAILhttps://phabricator.wikimedia.org/T197212EMAIL
Addshore added a comment.
Thanks for the patches! we will try to get this reviewed asap.TASK DETAILhttps://phabricator.wikimedia.org/T197212EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: dbs, Aklapper, Addshore, Tarrow, Lahi, Gq86,
dbs added a comment.
Commit aca952fca15220e5bb39bad6fac76ec43c86be2f switches the fetch method to git and uses "git submodule update --init" to populate the required branches. Things seem to be working based on my early investigations!TASK DETAILhttps://phabricator.wikimedia.org/T197212EMAIL
dbs added a comment.
I experimented with building a 1.31 image in a simplistic fashion (https://github.com/dbs/wikibase-docker/tree/wikibase-1.31-attempt) but that relies on the zipped release from github, and as of 1.31 we're now relying on git submodules to get packages such as