[Wikidata-bugs] [Maniphest] [Commented On] T197274: Explorer functionality broken on query.wikidata.org
gerritbot added a comment. Change 440486 abandoned by Smalyshev: Fix ws-sensitivity in Explorer Reason: better fix checked in https://gerrit.wikimedia.org/r/440486TASK DETAILhttps://phabricator.wikimedia.org/T197274EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, prssanna, Lucas_Werkmeister_WMDE, Jonas, Aklapper, Smalyshev, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Salgo60, Lewizho99, Maathavan, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T197274: Explorer functionality broken on query.wikidata.org
gerritbot added a comment. Change 440523 merged by Smalyshev: [wikidata/query/gui-deploy@production] Merging from ddae966c88faf5f8d1342fcbd84bd3bc0e6ed87c: https://gerrit.wikimedia.org/r/440523TASK DETAILhttps://phabricator.wikimedia.org/T197274EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, prssanna, Lucas_Werkmeister_WMDE, Jonas, Aklapper, Smalyshev, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Salgo60, Lewizho99, Maathavan, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T197274: Explorer functionality broken on query.wikidata.org
gerritbot added a comment. Change 440512 merged by jenkins-bot: [wikidata/query/gui@master] Refactor handleExploreItem() and fix broken explorer functionality https://gerrit.wikimedia.org/r/440512TASK DETAILhttps://phabricator.wikimedia.org/T197274EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, prssanna, Lucas_Werkmeister_WMDE, Jonas, Aklapper, Smalyshev, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Salgo60, Lewizho99, Maathavan, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T197274: Explorer functionality broken on query.wikidata.org
gerritbot added a comment. Change 440512 had a related patch set uploaded (by Prssanna; owner: Prssanna): [wikidata/query/gui@master] Refactor handleExploreItem() and fix broken explorer functionality as well as positioning of the toolbar and edit query button on the explorer dialog. https://gerrit.wikimedia.org/r/440512TASK DETAILhttps://phabricator.wikimedia.org/T197274EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, prssanna, Lucas_Werkmeister_WMDE, Jonas, Aklapper, Smalyshev, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Salgo60, Lewizho99, Maathavan, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T197274: Explorer functionality broken on query.wikidata.org
Smalyshev added a comment. @prssanna Please feel free to submit the patch! My patch is just a stopgap measure to fix the breakage, if you have better ideas definitely let's improve it.TASK DETAILhttps://phabricator.wikimedia.org/T197274EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: gerritbot, prssanna, Lucas_Werkmeister_WMDE, Jonas, Aklapper, Smalyshev, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Salgo60, Lewizho99, Maathavan, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T197274: Explorer functionality broken on query.wikidata.org
prssanna added a comment. The above fix works, but using jQuery's clone() method will be a better approach. I'd like to make the changes recommended here. That will remove the need for the above fix and will also fix the parent issue.TASK DETAILhttps://phabricator.wikimedia.org/T197274EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: prssannaCc: gerritbot, prssanna, Lucas_Werkmeister_WMDE, Jonas, Aklapper, Smalyshev, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Salgo60, Lewizho99, Maathavan, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
