[Wikidata-bugs] [Maniphest] [Commented On] T198468: Integration of Lexeme page with 'popups' extension

2018-07-02 Thread Pablo-WMDE
Pablo-WMDE added a comment.
@Jdlrobson Hint for changing those links taken.

Conceptually... These are links that point to the same page (save for the anchor) that we are already on. Is it not a valid assumption that there is no value in previewing this? Could/should the check not be implemented in popups generally?TASK DETAILhttps://phabricator.wikimedia.org/T198468EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: WMDE-leszek, Jdlrobson, Jakob_WMDE, Lydia_Pintscher, Pablo-WMDE, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Ricordisamoa, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T198468: Integration of Lexeme page with 'popups' extension

2018-06-29 Thread Jdlrobson
Jdlrobson added a comment.
(With regards to the add Sense / addForm links I'd recommend converting those to buttons and/or removing the title attribute since they are _javascript_ only and that will confuse page previews into thinking they are links)TASK DETAILhttps://phabricator.wikimedia.org/T198468EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: Jdlrobson, Jakob_WMDE, Lydia_Pintscher, Pablo-WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Ricordisamoa, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs