[Wikidata-bugs] [Maniphest] [Commented On] T199855: WikidataPageBanner breaks Vector page subtitle

2018-08-31 Thread Stashbot
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2018-08-31T23:00:34Z] Synchronized php-1.32.0-wmf.19/extensions/WikidataPageBanner/: I9dc9a4c1fb62c4 - T199855 (duration: 00m 51s)TASK DETAILhttps://phabricator.wikimedia.org/T199855EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T199855: WikidataPageBanner breaks Vector page subtitle

2018-08-31 Thread gerritbot
gerritbot added a comment. Change 456757 merged by jenkins-bot: [mediawiki/extensions/WikidataPageBanner@wmf/1.32.0-wmf.19] Only move/restyle subtitle for pages where banner is present https://gerrit.wikimedia.org/r/456757TASK DETAILhttps://phabricator.wikimedia.org/T199855EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T199855: WikidataPageBanner breaks Vector page subtitle

2018-08-31 Thread gerritbot
gerritbot added a comment. Change 456757 had a related patch set uploaded (by Krinkle; owner: Jdlrobson): [mediawiki/extensions/WikidataPageBanner@wmf/1.32.0-wmf.19] Only move/restyle subtitle for pages where banner is present https://gerrit.wikimedia.org/r/456757TASK

[Wikidata-bugs] [Maniphest] [Commented On] T199855: WikidataPageBanner breaks Vector page subtitle

2018-08-31 Thread gerritbot
gerritbot added a comment. Change 452004 merged by jenkins-bot: [mediawiki/extensions/WikidataPageBanner@master] Only move/restyle subtitle for pages where banner is present https://gerrit.wikimedia.org/r/452004TASK DETAILhttps://phabricator.wikimedia.org/T199855EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T199855: WikidataPageBanner breaks Vector page subtitle

2018-08-10 Thread gerritbot
gerritbot added a comment. Change 452004 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson): [mediawiki/extensions/WikidataPageBanner@master] Only move/restyle subtitle for pages where banner is present https://gerrit.wikimedia.org/r/452004TASK

[Wikidata-bugs] [Maniphest] [Commented On] T199855: WikidataPageBanner breaks Vector page subtitle

2018-07-29 Thread Jdlrobson
Jdlrobson added a comment. I see 2 options here Only do the subtitle fix when a banner exists (e.g. add `&& banner``` to https://gerrit.wikimedia.org/g/mediawiki/extensions/WikidataPageBanner/+/7d39c374cc589d9ecd714976d5508ca5f6b133c9/includes/WikidataPageBanner.hooks.php#62) We disable the