[Wikidata-bugs] [Maniphest] [Commented On] T202097: Avoid invoking Parser in WikibaseClient ResourceLoaderJqueryMsgModuleMagicWords hook

2018-08-17 Thread gerritbot
gerritbot added a comment. Change 453410 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Don't parse i18n message for WBREPONAME magic word https://gerrit.wikimedia.org/r/453410TASK DETAILhttps://phabricator.wikimedia.org/T202097EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T202097: Avoid invoking Parser in WikibaseClient ResourceLoaderJqueryMsgModuleMagicWords hook

2018-08-17 Thread gerritbot
gerritbot added a comment. Change 453410 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/Wikibase@master] Don't parse i18n message for WBREPONAME magic word https://gerrit.wikimedia.org/r/453410TASK DETAILhttps://phabricator.wikimedia.org/T202097EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T202097: Avoid invoking Parser in WikibaseClient ResourceLoaderJqueryMsgModuleMagicWords hook

2018-08-16 Thread Krinkle
Krinkle added a comment. I'd recommend considering Message::text() instead of Message::parse(). This would disallow templates and parser functions, which aren't currently used in those messages.