[Wikidata-bugs] [Maniphest] [Commented On] T205958: Wikibase\Repo\Search\Elastic\Tests\EntitySearchElasticFulltextTest::testSearchElastic fails on PHP 7.1

2018-10-12 Thread gerritbot
gerritbot added a comment. Change 466982 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Use the same precision as in T205958 https://gerrit.wikimedia.org/r/466982TASK DETAILhttps://phabricator.wikimedia.org/T205958EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/pan

[Wikidata-bugs] [Maniphest] [Commented On] T205958: Wikibase\Repo\Search\Elastic\Tests\EntitySearchElasticFulltextTest::testSearchElastic fails on PHP 7.1

2018-10-12 Thread gerritbot
gerritbot added a comment. Change 466982 had a related patch set uploaded (by Smalyshev; owner: Smalyshev): [mediawiki/extensions/WikibaseLexeme@master] Use the same precision as in T205958 https://gerrit.wikimedia.org/r/466982TASK DETAILhttps://phabricator.wikimedia.org/T205958EMAIL PREFERENCESht

[Wikidata-bugs] [Maniphest] [Commented On] T205958: Wikibase\Repo\Search\Elastic\Tests\EntitySearchElasticFulltextTest::testSearchElastic fails on PHP 7.1

2018-10-12 Thread gerritbot
gerritbot added a comment. Change 466945 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Bump precision and use setIniSetting https://gerrit.wikimedia.org/r/466945TASK DETAILhttps://phabricator.wikimedia.org/T205958EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/ema

[Wikidata-bugs] [Maniphest] [Commented On] T205958: Wikibase\Repo\Search\Elastic\Tests\EntitySearchElasticFulltextTest::testSearchElastic fails on PHP 7.1

2018-10-12 Thread gerritbot
gerritbot added a comment. Change 466945 had a related patch set uploaded (by Smalyshev; owner: Smalyshev): [mediawiki/extensions/Wikibase@master] Bump precision and use setIniSetting https://gerrit.wikimedia.org/r/466945TASK DETAILhttps://phabricator.wikimedia.org/T205958EMAIL PREFERENCEShttps://

[Wikidata-bugs] [Maniphest] [Commented On] T205958: Wikibase\Repo\Search\Elastic\Tests\EntitySearchElasticFulltextTest::testSearchElastic fails on PHP 7.1

2018-10-12 Thread Smalyshev
Smalyshev added a comment. 2 is not enough with the weights arithmetic we're doing. We're lucky it works in this case, but in general it won't be enough.TASK DETAILhttps://phabricator.wikimedia.org/T205958EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshor

[Wikidata-bugs] [Maniphest] [Commented On] T205958: Wikibase\Repo\Search\Elastic\Tests\EntitySearchElasticFulltextTest::testSearchElastic fails on PHP 7.1

2018-10-12 Thread Addshore
Addshore added a comment. a precision of 2 seemed to work just fine for me locally. This should now be fixed with the above merged patch?TASK DETAILhttps://phabricator.wikimedia.org/T205958EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Ladsgroup,

[Wikidata-bugs] [Maniphest] [Commented On] T205958: Wikibase\Repo\Search\Elastic\Tests\EntitySearchElasticFulltextTest::testSearchElastic fails on PHP 7.1

2018-10-12 Thread gerritbot
gerritbot added a comment. Change 465578 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Reset serialize_precision in finally block, and set to 2 https://gerrit.wikimedia.org/r/465578TASK DETAILhttps://phabricator.wikimedia.org/T205958EMAIL PREFERENCEShttps://phabricator.wikimedia.or

[Wikidata-bugs] [Maniphest] [Commented On] T205958: Wikibase\Repo\Search\Elastic\Tests\EntitySearchElasticFulltextTest::testSearchElastic fails on PHP 7.1

2018-10-12 Thread Smalyshev
Smalyshev added a comment. Looks like serialize_precision=-1 is not working there. See: https://3v4l.org/AomKR We may try to set precision to "14" or see why exactly -1 is not good there.TASK DETAILhttps://phabricator.wikimedia.org/T205958EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Commented On] T205958: Wikibase\Repo\Search\Elastic\Tests\EntitySearchElasticFulltextTest::testSearchElastic fails on PHP 7.1

2018-10-10 Thread gerritbot
gerritbot added a comment. Change 465578 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/Wikibase@master] Reset serialize_precision in try block https://gerrit.wikimedia.org/r/465578TASK DETAILhttps://phabricator.wikimedia.org/T205958EMAIL PREFERENCEShttps://

[Wikidata-bugs] [Maniphest] [Commented On] T205958: Wikibase\Repo\Search\Elastic\Tests\EntitySearchElasticFulltextTest::testSearchElastic fails on PHP 7.1

2018-10-09 Thread gerritbot
gerritbot added a comment. Change 465474 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Set serialize_precision to fix tests on PHP 7.1+ https://gerrit.wikimedia.org/r/465474TASK DETAILhttps://phabricator.wikimedia.org/T205958EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settin

[Wikidata-bugs] [Maniphest] [Commented On] T205958: Wikibase\Repo\Search\Elastic\Tests\EntitySearchElasticFulltextTest::testSearchElastic fails on PHP 7.1

2018-10-09 Thread gerritbot
gerritbot added a comment. Change 465474 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani): [mediawiki/extensions/Wikibase@master] Set serialize_precision https://gerrit.wikimedia.org/r/465474TASK DETAILhttps://phabricator.wikimedia.org/T205958EMAIL PREFERENCEShttps://phabric

[Wikidata-bugs] [Maniphest] [Commented On] T205958: Wikibase\Repo\Search\Elastic\Tests\EntitySearchElasticFulltextTest::testSearchElastic fails on PHP 7.1

2018-10-02 Thread Legoktm
Legoktm added a comment. Looks like this is caused by https://wiki.php.net/rfc/precise_float_valueTASK DETAILhttps://phabricator.wikimedia.org/T205958EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LegoktmCc: Legoktm, Aklapper, Nandana, Lahi, Gq86, GoranSMilov