[Wikidata-bugs] [Maniphest] [Commented On] T209410: sameAs schema doesn't report dateModified if article has only one edit

[phuedx]

phuedx added a comment.


  I did some digging on this task during today's chores. Here's what I think I 
know:
  
  - We create the `dateModified` property using the server-local timestamp of 
the last revision (herein the "timestamp"; see here 
)
  - //We might not have that timestamp?!//
  - We get the timestamp from `OutputPage#getRevisionTimestamp` (see here 
)
  - The timestamp returned by that method is set by 
`OutputPage#setRevisionTimestamp` but there's //no fallback if the value is 
never set//
  - `OutputPage#setRevisionTimestamp` is invoked (in this context):
- When there's a parser cache hit and the cached parser output has a 
timestamp (see here 
)
- When there's a parser cache miss (see here 
)
  - The comment on that line doesn't make sense as `WikiPage#getTimestamp` 
//might// hit the DB to hydrate itself
  
  AFAICT we're seeing the result of a parser cache hit where the cached parser 
output doesn't have a timestamp.
  
  My recommendation would be to change this line 

 to:
  
$out->getWikiPage()->getTimestamp()
  
  Or reach out on wikitech about why the above circumstance may occur.

TASK DETAIL
  https://phabricator.wikimedia.org/T209410

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: phuedx
Cc: phuedx, Tbayer, ovasileva, Niedzielski, pmiazga, Aklapper, darthmon_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, Chicocvenancio, QZanden, LawExplorer, 
Winter, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T209410: sameAs schema doesn't report dateModified if article has only one edit

[Niedzielski]

Niedzielski added a comment.
Here's an odd example: https://pl.wikipedia.org/wiki/Shin_Seung-hun. When I'm logged in, I get dateModified. When I'm anonymous, I don't.TASK DETAILhttps://phabricator.wikimedia.org/T209410EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NiedzielskiCc: Niedzielski, pmiazga, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, Chicocvenancio, QZanden, LawExplorer, Winter, D3r1ck01, Wikidata-bugs, aude, Mbch331, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T209410: sameAs schema doesn't report dateModified if article has only one edit

[Niedzielski]

Niedzielski added a comment.
https://en.wikipedia.beta.wmflabs.org/wiki/Hanselman_sextuplets

I can no longer repro this.TASK DETAILhttps://phabricator.wikimedia.org/T209410EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NiedzielskiCc: Niedzielski, pmiazga, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, Chicocvenancio, QZanden, LawExplorer, Winter, D3r1ck01, Wikidata-bugs, aude, Mbch331, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T209410: sameAs schema doesn't report dateModified if article has only one edit

[Niedzielski]

Niedzielski added a comment.
Originally reported for: https://de.wikipedia.beta.wmflabs.org/wiki/Erde. However, this does not occur for all pages with single edits. For example: https://en.wikipedia.beta.wmflabs.org/wiki/Hanselman_sextuplets.TASK DETAILhttps://phabricator.wikimedia.org/T209410EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NiedzielskiCc: Niedzielski, pmiazga, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, Chicocvenancio, QZanden, LawExplorer, Winter, D3r1ck01, Wikidata-bugs, aude, Mbch331, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs