[Wikidata-bugs] [Maniphest] [Commented On] T209931: Glosses: display the language name also in edit mode
gerritbot added a comment. Change 477790 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Introduce LanguageSelectorWrapper Vue Widget https://gerrit.wikimedia.org/r/477790TASK DETAILhttps://phabricator.wikimedia.org/T209931EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, gerritbotCc: Addshore, Tarrow, Liuxinyu970226, gerritbot, Lea_Lacroix_WMDE, Lydia_Pintscher, CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, Jonas, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T209931: Glosses: display the language name also in edit mode
Addshore added a comment. Removing the subtask thenTASK DETAILhttps://phabricator.wikimedia.org/T209931EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, AddshoreCc: Addshore, Tarrow, Liuxinyu970226, gerritbot, Lea_Lacroix_WMDE, Lydia_Pintscher, CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T209931: Glosses: display the language name also in edit mode
Tarrow added a comment. It does not appear that deploying this patch without parser cache invalidation will cause cause frontend JS breakages. I tested this locally by: un-setting my value of $wgParserCacheType = CACHE_NONE. so $wgParserCacheType defaults to CACHE_ANYTHING loading current master loading a lexeme page with a sense updating to https://phabricator.wikimedia.org/rEWLEeb5a1879371b6c77d13e77a1e56f4b3411874082 reloading the page and confirming that it still has the old behaviour and no errors in the console purging the cache with action=""> and now confirming it has the new functionality I believe this is because the frontend JS remains backwards compatible with the old pages in the cache because the new widget simply isn't loaded and a plain is still there.TASK DETAILhttps://phabricator.wikimedia.org/T209931EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Tarrow, Liuxinyu970226, gerritbot, Lea_Lacroix_WMDE, Lydia_Pintscher, CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T209931: Glosses: display the language name also in edit mode
gerritbot added a comment. Change 477790 had a related patch set uploaded (by Tarrow; owner: Tarrow): [mediawiki/extensions/WikibaseLexeme@master] WIP Introduce LanguageSelectorWrapper Vue Widget https://gerrit.wikimedia.org/r/477790TASK DETAILhttps://phabricator.wikimedia.org/T209931EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, gerritbotCc: gerritbot, Lea_Lacroix_WMDE, Lydia_Pintscher, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T209931: Glosses: display the language name also in edit mode
Tarrow added a comment. extensions/Wikibase/view/lib/wikibase-data-values-value-view/lib/jquery.ui/jquery.ui.languagesuggester.js is what we want to useTASK DETAILhttps://phabricator.wikimedia.org/T209931EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Lydia_Pintscher, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs