[Wikidata-bugs] [Maniphest] [Commented On] T213889: WDQS UI fails on large queries

[gerritbot]

gerritbot added a comment.


  Change 494376 abandoned by Smalyshev:
  Merging from e9f3dd43523caa0878ca01f21b1e431c0b4b70be 
:
  
  Reason:
  superceded
  
  https://gerrit.wikimedia.org/r/494376

TASK DETAIL
  https://phabricator.wikimedia.org/T213889

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, NoInkling, Lucas_Werkmeister_WMDE, Aklapper, Smalyshev, 
alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Salgo60, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Xmlizer, jkroll, Wikidata-bugs, 
Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T213889: WDQS UI fails on large queries

[gerritbot]

gerritbot added a comment.


  Change 494282 **merged** by jenkins-bot:
  [wikidata/query/gui@master] Retry queries with POST if server indicates 
request was too large
  
  https://gerrit.wikimedia.org/r/494282

TASK DETAIL
  https://phabricator.wikimedia.org/T213889

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, NoInkling, Lucas_Werkmeister_WMDE, Aklapper, Smalyshev, 
alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Salgo60, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Xmlizer, jkroll, Wikidata-bugs, 
Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T213889: WDQS UI fails on large queries

[gerritbot]

gerritbot added a comment.


  Change 494282 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
owner: Lucas Werkmeister (WMDE)):
  [wikidata/query/gui@master] Retry queries with POST if server indicates 
request was too large
  
  https://gerrit.wikimedia.org/r/494282

TASK DETAIL
  https://phabricator.wikimedia.org/T213889

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, NoInkling, Lucas_Werkmeister_WMDE, Aklapper, Smalyshev, 
alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, merbst, 
LawExplorer, Salgo60, _jensen, rosalieper, Jonas, Xmlizer, jkroll, 
Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T213889: WDQS UI fails on large queries

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.
Yeah, the existing code only detects when the browser doesn’t send a request at all, so I guess there must now be some length that the browser still sends but the server rejects.

This would of course be easier to debug if the reporting user on Wikidata provided the failing query :/TASK DETAILhttps://phabricator.wikimedia.org/T213889EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, Smalyshev, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Salgo60, _jensen, D3r1ck01, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T213889: WDQS UI fails on large queries

[Smalyshev]

Smalyshev added a comment.
I see the code is:

if ( request.getAllResponseHeaders() === '' ) {
  // query might have been too long for GET, retry with POST
  settings.method = 'POST';
  $.ajax( self._serviceUri, settings ).done( done ).fail( fail );
}

I suspect when the server rejects it, the headers are not empty. It also can be a proxy on the way rejecting it, of course.TASK DETAILhttps://phabricator.wikimedia.org/T213889EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Lucas_Werkmeister_WMDE, Aklapper, Smalyshev, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Salgo60, _jensen, D3r1ck01, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T213889: WDQS UI fails on large queries

[Smalyshev]

Smalyshev added a comment.
Well, maybe there's some gap between client-side and server-side limits?TASK DETAILhttps://phabricator.wikimedia.org/T213889EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Lucas_Werkmeister_WMDE, Aklapper, Smalyshev, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Salgo60, _jensen, D3r1ck01, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T213889: WDQS UI fails on large queries

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.
This was implemented long ago (apparently without a Phabricator task, but see Ic770e25bb4 and Ic3ea53c50e), but I guess something is behaving differently now? I don’t recall seeing an HTTP 414 error back then, the request just wouldn’t be sent at all (client-side limit).TASK DETAILhttps://phabricator.wikimedia.org/T213889EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, Smalyshev, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Salgo60, _jensen, D3r1ck01, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs