gerritbot added a comment.
Change 488957 had a related patch set uploaded (by Bmansurov; owner: Bmansurov):
[mediawiki/core@master] Expose external link additions and deletions
https://gerrit.wikimedia.org/r/488957TASK DETAILhttps://phabricator.wikimedia.org/T214706EMAIL PREFERENCEShttps://phabric
Pchelolo added a comment.
We have discovered that we would need to update LinkUpdates class in the core to support this functionality, so it will take a little bit more time then we anticipated, but we're making progress.TASK DETAILhttps://phabricator.wikimedia.org/T214706EMAIL PREFERENCEShttps://p
Nuria added a comment.
@Samwalton9 we still need to see if urls are url encoded or not and hook publishing to one of the mediawiki events (I think @bmansurov is doing this with @Pchelolo .help?) Once events are flowing and looking OK they can be set to be published to the outside world.TASK DETAILh
Samwalton9 added a comment.
Thanks for your input, all - it's great to see how quickly new event streams can be set up!
What are the next steps for getting the event stream live and accessible from this schema?TASK DETAILhttps://phabricator.wikimedia.org/T214706EMAIL PREFERENCEShttps://phabricator
gerritbot added a comment.
Change 486521 merged by Ppchelko:
[mediawiki/event-schemas@master] Add page link changes schema
https://gerrit.wikimedia.org/r/486521TASK DETAILhttps://phabricator.wikimedia.org/T214706EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Pchelolo added a comment.
How should we handle the situation with long list of links? Is that really a problem? Should we create multiple events?
You should not worry about that unless you encounter a list of links that's > 4mb long :)TASK DETAILhttps://phabricator.wikimedia.org/T214706EMAIL PREFE
bmansurov added a comment.
@Nuria @Pchelolo I'm encoding the URL in the above patch. How should we handle the situation with long list of links? Is that really a problem? Should we create multiple events?TASK DETAILhttps://phabricator.wikimedia.org/T214706EMAIL PREFERENCEShttps://phabricator.wikime
gerritbot added a comment.
Change 486691 had a related patch set uploaded (by Bmansurov; owner: Bmansurov):
[mediawiki/extensions/EventBus@master] Send page-external-links-change event
https://gerrit.wikimedia.org/r/486691TASK DETAILhttps://phabricator.wikimedia.org/T214706EMAIL PREFERENCEShttps:/
Pchelolo added a comment.
Are links url encoded? (we probably want them to be so).
I agree with @Nuria on this. The 'meta.uri' is encoded, we need to be consistent. Whether the LinksUpdate in MW has encoded or not encoded links - needs to be tested.TASK DETAILhttps://phabricator.wikimedia.org/T214
gerritbot added a comment.
Change 486521 had a related patch set uploaded (by Bmansurov; owner: Bmansurov):
[mediawiki/event-schemas@master] Add page link changes schema
https://gerrit.wikimedia.org/r/486521TASK DETAILhttps://phabricator.wikimedia.org/T214706EMAIL PREFERENCEShttps://phabricator.wi
Nuria added a comment.
@bmansurov I think you need to consider also couple more things: a list of links can be very lengthy, do we have a limit for how much this field should occupy? Are links url encoded? (we probably want them to be so).TASK DETAILhttps://phabricator.wikimedia.org/T214706EMAIL PR
Pchelolo added a comment.
@Pchelolo yes, replacing "properties" with "links" should do it. I don't think we need the full list of links, just the changes.
Perfect. Just make a change request in gerrit with a new schema. I can point you to where to write the code for emitting the event, or I write
bmansurov added a comment.
@Pchelolo yes, replacing "properties" with "links" should do it. I don't think we need the full list of links, just the changes.
Also, any idea on if this will work with Wikidata?TASK DETAILhttps://phabricator.wikimedia.org/T214706EMAIL PREFERENCEShttps://phabricator.wik
Pchelolo added a comment.
@bmansurov look at the event schema for properties change I've linked, it contains all of the metadata you need and it's generated from the same hook. Will such a schema work for you if we replace removed_properties with removed_links and added_properties with added_links?
bmansurov added a comment.
@Pchelolo good to hear. Besides the links themselves, will we be able to extract metadata associated with the change too? We'll need the following:
Revision ID
Page ID
Timestamp of the change
possibly others
TASK DETAILhttps://phabricator.wikimedia.org/T214706EMAIL PREF
Pchelolo added a comment.
The task at hand is very easy. There's LinksUpdateComplete hook in MW core, it gets the LinksUpdate which contains the list of external links and methods to get links insertions and removals. Writing code in EventBus extension to use the hook is simple. The important part
Nuria added a comment.
@bmansurov ah I think I understand what you meant, now sorry: if mediawiki cannot generate the diff you are interested on at the time the page is edited you need to consume an event that happens later in the chain, ya, makes sense.TASK DETAILhttps://phabricator.wikimedia.org
Nuria added a comment.
Clarifying: ChnageProp consumes EventBus data just like EventStreams consumes EventBus data. So you cannot "use" changeprop rather you will be sending events to EventBus (soon to be called EventGate) and consuming them from elsewhere and in turn exposing them to the world.
18 matches
Mail list logo
