[Wikidata-bugs] [Maniphest] [Commented On] T221949: Remove uses of Title::moveTo
gerritbot added a comment. Change 560351 **merged** by jenkins-bot: [mediawiki/extensions/UserMerge@master] Replace deprecated Title::moveTo with MovePage method https://gerrit.wikimedia.org/r/560351 TASK DETAIL https://phabricator.wikimedia.org/T221949 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DannyS712, gerritbot Cc: Art-Baltai, Peter.ovchyn, daniel, DannyS712, Aklapper, Lucas_Werkmeister_WMDE, Simetrical, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, WDoranWMF, holger.knust, EvanProdromou, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Amorymeltzer, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, TheDragonFire, Adik2382, RazeSoldier, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Tuxxic, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Izno, MGChecker, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T221949: Remove uses of Title::moveTo
DannyS712 added a comment. Yes, since `Title::moveTo` defaults to `$wgUser`, I left the behavior the same by passing `$wgUser` for the move call. TASK DETAIL https://phabricator.wikimedia.org/T221949 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DannyS712 Cc: Art-Baltai, Peter.ovchyn, daniel, DannyS712, Aklapper, Lucas_Werkmeister_WMDE, Simetrical, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, WDoranWMF, holger.knust, EvanProdromou, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Amorymeltzer, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, TheDragonFire, Adik2382, RazeSoldier, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Tuxxic, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Izno, MGChecker, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T221949: Remove uses of Title::moveTo
Art-Baltai added a comment. I close my patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UserMerge/+/566838 note about global var https://3v4l.org/MpY9D https://3v4l.org/hjYJo -- https://phabricator.wikimedia.org/T221949 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DannyS712, Art-Baltai Cc: Art-Baltai, Peter.ovchyn, daniel, DannyS712, Aklapper, Lucas_Werkmeister_WMDE, Simetrical, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, WDoranWMF, holger.knust, EvanProdromou, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Amorymeltzer, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, TheDragonFire, Adik2382, RazeSoldier, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Tuxxic, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Izno, MGChecker, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T221949: Remove uses of Title::moveTo
gerritbot added a comment. Change 566838 abandoned by Art-Baltai: component: Refactofing of Title::moveTo to MovePageFactory->MovePage Reason: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UserMerge/ /560351 https://gerrit.wikimedia.org/r/566838 TASK DETAIL https://phabricator.wikimedia.org/T221949 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DannyS712, gerritbot Cc: Art-Baltai, Peter.ovchyn, daniel, DannyS712, Aklapper, Lucas_Werkmeister_WMDE, Simetrical, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, WDoranWMF, holger.knust, EvanProdromou, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Amorymeltzer, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, TheDragonFire, Adik2382, RazeSoldier, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Tuxxic, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Izno, MGChecker, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T221949: Remove uses of Title::moveTo
Art-Baltai added a comment. Oh, sorry, @DannyS712 :) We get the same code, so it looks correct. Also, I added an example for global invoke https://3v4l.org/MpY9D https://3v4l.org/hjYJo link is temporary TASK DETAIL https://phabricator.wikimedia.org/T221949 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DannyS712, Art-Baltai Cc: Art-Baltai, Peter.ovchyn, daniel, DannyS712, Aklapper, Lucas_Werkmeister_WMDE, Simetrical, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, WDoranWMF, holger.knust, EvanProdromou, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Amorymeltzer, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, TheDragonFire, Adik2382, RazeSoldier, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Tuxxic, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Izno, MGChecker, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T221949: Remove uses of Title::moveTo
gerritbot added a comment. Change 566838 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai): [mediawiki/extensions/UserMerge@master] component: Refactofing of Title::moveTo to MovePageFactory->MovePage https://gerrit.wikimedia.org/r/566838 TASK DETAIL https://phabricator.wikimedia.org/T221949 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DannyS712, gerritbot Cc: Peter.ovchyn, daniel, DannyS712, Aklapper, Lucas_Werkmeister_WMDE, Simetrical, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Amorymeltzer, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, TheDragonFire, Adik2382, RazeSoldier, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Tuxxic, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Izno, MGChecker, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T221949: Remove uses of Title::moveTo
daniel added a comment. The sole remaining issue here is to add a test for UserMerge that tests the page move, so we can merge the respective patch with confidence: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UserMerge/+/560351 TASK DETAIL https://phabricator.wikimedia.org/T221949 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DannyS712, daniel Cc: daniel, DannyS712, Aklapper, Lucas_Werkmeister_WMDE, Simetrical, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Amorymeltzer, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, TheDragonFire, Adik2382, RazeSoldier, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Tuxxic, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Izno, MGChecker, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
