[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 540018 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Remove trailing . from fallback edit summary comments https://gerrit.wikimedia.org/r/540018 TASK DETAIL https://phabricator.wikimedia.org/T224010 EMAIL PREFERENCES https://ph

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 540018 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan): [mediawiki/extensions/Wikibase@master] Remove trailing . from fallback edit summary comments https://gerrit.wikimedia.org/r/540018 TASK DETAIL https://phabricator.wikimedi

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 535906 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Move new translations to correct file and keys https://gerrit.wikimedia.org/r/535906 TASK DETAIL https://phabricator.wikimedia.org/T224010 EMAIL PREFERENCES https://phabricat

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 535906 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan): [mediawiki/extensions/Wikibase@master] Move new translations to correct file and keys https://gerrit.wikimedia.org/r/535906 TASK DETAIL https://phabricator.wikimedia.org/T

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

alaa_wmde added a comment. When Testing on Beta, the summary message was not translated: F30299917: image.png https://m.wikidata.beta.wmflabs.org/w/index.php?title=Q432336&action=history TASK DETAIL https://phabricator.wikimedia.org/T224010

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 533261 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Generate fallback summary messages based on changed parts on entity https://gerrit.wikimedia.org/r/533261 TASK DETAIL https://phabricator.wikimedia.org/T224010 EMAIL PREFERENCE

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

alaa_wmde added a comment. In T224010#5456490 , @Lydia_Pintscher wrote: > As for the message: how about "Changed label, description and/or aliases in 3 languages, and other parts"? Sounds good to me! TASK DETAIL https://phabricat

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 534127 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add a service to count non-language-bound changes in ChangeOpResult tree. https://gerrit.wikimedia.org/r/534127 TASK DETAIL https://phabricator.wikimedia.org/T224010 EMAIL PREF

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 534127 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan): [mediawiki/extensions/Wikibase@master] Add a service to count language unbound changes in ChangeOpResult tree. https://gerrit.wikimedia.org/r/534127 TASK DETAIL https://ph

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 533898 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] GenericChangeOpResult: add tests https://gerrit.wikimedia.org/r/533898 TASK DETAIL https://phabricator.wikimedia.org/T224010 EMAIL PREFERENCES https://phabricator.wikimedia.or

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 533522 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Make all other ChangeOp implementations return GenericChangeOpResult https://gerrit.wikimedia.org/r/533522 TASK DETAIL https://phabricator.wikimedia.org/T224010 EMAIL PREFERENC

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 533898 had a related patch set uploaded (by Jakob; owner: Jakob): [mediawiki/extensions/Wikibase@master] GenericChangeOpResult: add tests https://gerrit.wikimedia.org/r/533898 TASK DETAIL https://phabricator.wikimedia.org/T224010 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

Lydia_Pintscher added a comment. In T224010#5453581 , @alaa_wmde wrote: > We want to go with the second one, but would love to confirm with you on the general idea, and perhaps if you have an opinion on the combined message wording.

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 533522 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan): [mediawiki/extensions/Wikibase@master] Make all other ChangeOp implementations return GenericChangeOpResult https://gerrit.wikimedia.org/r/533522 TASK DETAIL https://phabr

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

alaa_wmde added a comment. @Lydia_Pintscher @Lea_WMDE We have a question on this. `wbeditentity` can be used to edit all parts of an entity. When parts other than terms have been edited through it (currently, only through API as in UI the new termbox will only do one batch for terms),

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 533261 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan): [mediawiki/extensions/Wikibase@master] Use ChangedLanguagesCounter in EditEntity to generate fallback summary message https://gerrit.wikimedia.org/r/533261 TASK DETAIL htt

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 530116 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add service for counting distinct changed languages in a changeOpResults tree. https://gerrit.wikimedia.org/r/530116 TASK DETAIL https://phabricator.wikimedia.org/T224010 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 531296 abandoned by Alaa Sarhan: Introduce interfaces to enable visitor pattern for business logic on ChangeOpResult trees. Reason: went with simpler solution https://gerrit.wikimedia.org/r/531296 TASK DETAIL https://phabricator.wikimedia.org/

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 531296 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan): [mediawiki/extensions/Wikibase@master] Introduce interfaces to enable visitor pattern for business logic on ChangeOpResult trees. https://gerrit.wikimedia.org/r/531296 TASK

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 529956 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Introduce LanguageBoundChangeOpResult following ISP https://gerrit.wikimedia.org/r/529956 TASK DETAIL https://phabricator.wikimedia.org/T224010 EMAIL PREFERENCES https://phab

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

alaa_wmde added a comment. (mimicking gerrit 😄) Change 530116 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)): [mediawiki/extensions/Wikibase@master] Add service for counting distinct changed languages in a given changeOpResults tree. ht

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 529325 abandoned by Alaa Sarhan: [WIP]Make Summary class hold all languages of edit. Reason: Paired on a different approach with Rosalie, and agreed on abandoning this one https://gerrit.wikimedia.org/r/529325 TASK DETAIL https://phabricator.wi

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 529956 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)): [mediawiki/extensions/Wikibase@master] Introduce LanguageBoundChangeOpResult following ISP https://gerrit.wikimedia.org/r/529956 TASK DETAIL https://

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 529325 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)): [mediawiki/extensions/Wikibase@master] Make Summary class hold all languages of edit. https://gerrit.wikimedia.org/r/529325 TASK DETAIL https://phabr

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 526672 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Make ChangeOps::apply() return instance of changeOpResult Add Test for ChangeOps::apply() return value https://gerrit.wikimedia.org/r/526672 TASK DETAIL https://phabricator.wiki

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

alaa_wmde added a comment. In T224010#5376520 , @Rosalie_WMDE wrote: > @alaa_wmde For the next change, I guess we should count the languages from the changeOps array then another change will be to modify the edit summary based on the co

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 526672 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)): [mediawiki/extensions/Wikibase@master] Make ChangeOps::apply() return instance of changeOpResult https://gerrit.wikimedia.org/r/526672 TASK DETAIL ht

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

Rosalie_WMDE added a comment. @alaa_wmde For the next change, I guess we should count the languages from the changeOps array then another change will be to modify the edit summary based on the counts result. I am working on the language count now. Let me know if am missing something please

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 524498 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Implement ChangeOpResult for ChangeOpAliases, ChangeOpDescription and ChangeOpLabel https://gerrit.wikimedia.org/r/524498 TASK DETAIL https://phabricator.wikimedia.org/T224010

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 524498 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)): [mediawiki/extensions/Wikibase@master] [WIP]Implement ChangeOpResult for ChangeOpAliases, ChangeOpDescription and ChangeOpLabel https://gerrit.wikimedia

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

Rosalie_WMDE added a comment. waiting on patches from parent task. Also did not want to have it in Doing with the parent task. TASK DETAIL https://phabricator.wikimedia.org/T224010 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE Cc:

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

alaa_wmde added a comment. why is this in Stalled? TASK DETAIL https://phabricator.wikimedia.org/T224010 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE, alaa_wmde Cc: Lea_WMDE, Aklapper, Lydia_Pintscher, Lucas_Werkmeister_WMDE, alaa_

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 517454 abandoned by Rosalie Perside (WMDE): WIP. Add state concept to ChangeOp. Reason: New aproach: we will make changeOp return changeOpResult instead of giving changeOp states. See https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 519078 abandoned by Rosalie Perside (WMDE): [WIP] Add definition of getState() ChangeOp method to classes Implementing ChangeOP Reason: New aproach: we will make changeOp return changeOpResult instead of giving changeOp states. See https://gerrit.wi

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

Rosalie_WMDE added a comment. @alaa_wmde -- back to doing -- Does it mean there is available feedback please? TASK DETAIL https://phabricator.wikimedia.org/T224010 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE Cc: Lea_WMDE, Aklappe

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 519078 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)): [mediawiki/extensions/WikibaseLexeme@master] [WIP] Add definition of getState() ChangeOp method to classes Implementing ChangeOP https://gerrit.wikimedi

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 516497 abandoned by Alaa Sarhan: Implement Fallback version Reason: we have to use change ops to determine what have been applied https://gerrit.wikimedia.org/r/516497 TASK DETAIL https://phabricator.wikimedia.org/T224010 EMAIL PREFERENCES h

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 517454 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)): [mediawiki/extensions/Wikibase@master] WIP. Add state concept to ChangeOp. https://gerrit.wikimedia.org/r/517454 TASK DETAIL https://phabricator.wikim

[Wikidata-bugs] [Maniphest] [Commented On] T224010: Implement Fallback version

gerritbot added a comment. Change 516497 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)): [mediawiki/extensions/Wikibase@master] Implement Fallback version https://gerrit.wikimedia.org/r/516497 TASK DETAIL https://phabricator.wikimedia.org/