[Wikidata-bugs] [Maniphest] [Commented On] T227082: Show error in case of save attempt for a non-supported language

[alaa_wmde]

alaa_wmde added a comment.


  Do the checking as mentioned in {T227082#5353160 
} and decide afterwards 
where to move with this

TASK DETAIL
  https://phabricator.wikimedia.org/T227082

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde
Cc: alaa_wmde, Jakob_WMDE, Ladsgroup, Aklapper, Hanna_Petruschat_WMDE, 
Lea_WMDE, WMDE-leszek, gerritbot, Pablo-WMDE, Lydia_Pintscher, Addshore, 
Tarrow, noarave, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T227082: Show error in case of save attempt for a non-supported language

[WMDE-leszek]

WMDE-leszek added a comment.


  It might be that it is already handled as intended in all contexts (all API 
endpoints etc, all special pages) but then this task would at least about 
checking and ensuring it (e.g. automated tests) in a systematic way

TASK DETAIL
  https://phabricator.wikimedia.org/T227082

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: WMDE-leszek
Cc: Jakob_WMDE, Ladsgroup, Aklapper, Hanna_Petruschat_WMDE, Lea_WMDE, 
WMDE-leszek, gerritbot, Pablo-WMDE, Lydia_Pintscher, Addshore, Tarrow, noarave, 
darthmon_wmde, alaa_wmde, Nandana, Sario528, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T227082: Show error in case of save attempt for a non-supported language

[Ladsgroup]

Ladsgroup added a comment.


  In T227082#5303967 , 
@Jakob_WMDE wrote:
  
  > @Ladsgroup Yes, as far as I know showing / getting errors was not the 
issue, rather the fact that there were non-supported languages :)
  
  I know, the task has been broken down to three tasks, one of them is "avoid 
to save when the given language is unknown" (This task) but if I understand it 
correctly, it's already done:
  
amsa@amsa-Latitude-7480:~$ curl 'httpsxt/javascript, */*; q=0.01' -H 
'Accept-Language: en-US,en;q=0.5' --compressed -H 'Referer: 
https://www.wikidata.org/wiki/Q4115189' -H 'Content-Type: 
application/x-www-form-urlencoded; charset=UTF-8' -H 'X-Requested-With: 
XMLHttpRequest' -H 'Connection: keep-alive' --data 
'action=wbsetlabel=json=Q4115189=Foo=tokipona=974041385=1=Ladsgroup=youdontthinkIgiveoutmytokensoeasilyright'

{"error":{"code":"unknown_language","info":"Unrecognized value for 
parameter \"language\": tokipona.","*":"See https://www.wikidata.org/w/api.php 
for API usage. Subscribe to the mediawiki-api-announce mailing list at 
https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce; for 
notice of API deprecations and breaking changes."},"servedby":"mw1312"}

TASK DETAIL
  https://phabricator.wikimedia.org/T227082

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Jakob_WMDE, Ladsgroup, Aklapper, Hanna_Petruschat_WMDE, Lea_WMDE, 
WMDE-leszek, gerritbot, Pablo-WMDE, Lydia_Pintscher, Addshore, Tarrow, noarave, 
darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T227082: Show error in case of save attempt for a non-supported language

[Jakob_WMDE]

Jakob_WMDE added a comment.


  @Ladsgroup Yes, as far as I know showing / getting errors was not the issue, 
rather the fact that there were non-supported languages :)

TASK DETAIL
  https://phabricator.wikimedia.org/T227082

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jakob_WMDE
Cc: Jakob_WMDE, Ladsgroup, Aklapper, Hanna_Petruschat_WMDE, Lea_WMDE, 
WMDE-leszek, gerritbot, Pablo-WMDE, Lydia_Pintscher, Addshore, Tarrow, noarave, 
darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T227082: Show error in case of save attempt for a non-supported language

[Ladsgroup]

Ladsgroup added a comment.


  I have a feeling this is already done, I saw it when I tried saving some 
languages in the API. Can you elaborate @WMDE-leszek if I'm missing something 
here?

TASK DETAIL
  https://phabricator.wikimedia.org/T227082

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Ladsgroup, Aklapper, Hanna_Petruschat_WMDE, Lea_WMDE, WMDE-leszek, 
gerritbot, Pablo-WMDE, Lydia_Pintscher, Addshore, Tarrow, noarave, 
darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs