[Wikidata-bugs] [Maniphest] [Commented On] T227402: Wikimedia map does not display wikidata item (using Template:Maplink)

2019-08-02 Thread Evad37 
Evad37 added a comment.


  In T227402#5388976 , 
@Pikne wrote:
  
  > I doubt if there is a viable Kartographer/Kartotherian fix to your use 
case. If centre coordinates are entered (or retrieved from Wikidata) then these 
coordinates should probably still be respected as centre coordinates and map 
shouldn't be expected to centre differently.
  
  It would be nice if that could happen rather than the single red dot in the 
center of a white screen. The templates/modules should be able to take care of 
the rest (deciding when to set or not set coords in the tag attributes).

TASK DETAIL
  https://phabricator.wikimedia.org/T227402

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Evad37
Cc: Evad37, Pikne, ZONA2LORA, Aklapper, Kozuch, Liuxinyu970226, darthmon_wmde, 
Nabetaro, DannyS712, Nandana, MSantos, Lahi, Gq86, Looniverse, 
GoranSMilovanovic, QZanden, Orienteerix, LawExplorer, Ddproxy, _jensen, 
rosalieper, JGirault, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, 
Planemad, Wikidata-bugs, aude, Yurik, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T227402: Wikimedia map does not display wikidata item (using Template:Maplink)

2019-08-02 Thread Pikne 
Pikne added a comment.


  In T227402#5388845 , 
@Kozuch wrote:
  
  > After Kartographer is fixed this new template can be redirected to 
Template:Maplink (given the new template will remain compatible with Maplink's 
parameters).
  
  I doubt if there is a viable Kartographer/Kartotherian fix to your use case. 
If centre coordinates are entered (or retrieved from Wikidata) then these 
coordinates should probably still be respected as centre coordinates and map 
shouldn't be expected to centre differently.

TASK DETAIL
  https://phabricator.wikimedia.org/T227402

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pikne
Cc: Evad37, Pikne, ZONA2LORA, Aklapper, Kozuch, Liuxinyu970226, darthmon_wmde, 
Nabetaro, DannyS712, Nandana, MSantos, Lahi, Gq86, Looniverse, 
GoranSMilovanovic, QZanden, Orienteerix, LawExplorer, Ddproxy, _jensen, 
rosalieper, JGirault, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, 
Planemad, Wikidata-bugs, aude, Yurik, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T227402: Wikimedia map does not display wikidata item (using Template:Maplink)

2019-08-02 Thread Kozuch 
Kozuch added a comment.


  @Evad37 Thanks for your examples - they show the issue nicely. I agree that 
this should be solved in Kartographer. However as I am not willing to wait for 
such solution, I created a clone of your Module:Mapframe to work around this 
bug. The new module and template for its use are here:
  
  https://en.wikipedia.org/wiki/Module:MapframeForObjects
  https://en.wikipedia.org/wiki/Template:MapframeForObjects
  
  I created simple docs for both explaining the problem and linking to this bug.
  
  In the module code I simply commented out the lines where coords are being 
fetched from wikidata when no lat/lon is supplied. The comment begins with this 
line:
  
if not attribs.latitude and not attribs.longitude then
  
  I hope there will be no problems with using the new module/template. After 
Kartographer is fixed this new template can be redirected to Template:Maplink 
(given the new template will remain compatible with Maplink's parameters).
  Thank you both for your help.

TASK DETAIL
  https://phabricator.wikimedia.org/T227402

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Kozuch
Cc: Evad37, Pikne, ZONA2LORA, Aklapper, Kozuch, Liuxinyu970226, darthmon_wmde, 
Nabetaro, DannyS712, Nandana, MSantos, Lahi, Gq86, Looniverse, 
GoranSMilovanovic, QZanden, Orienteerix, LawExplorer, Ddproxy, _jensen, 
rosalieper, JGirault, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, 
Planemad, Wikidata-bugs, aude, Yurik, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T227402: Wikimedia map does not display wikidata item (using Template:Maplink)

2019-07-30 Thread Evad37 
Evad37 added a comment.


  Previously not specifying latitude/longitude/zoom used default values, which 
in most cases weren't appropriate, but at least showed a map that could be 
interacted with. In any case, the current behaviour is not desirable - either a 
default zoom should be used if latitude and longitude are provided without a 
specified zoom, or there should be an error message provide.

TASK DETAIL
  https://phabricator.wikimedia.org/T227402

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Evad37
Cc: Evad37, Pikne, ZONA2LORA, Aklapper, Kozuch, Liuxinyu970226, darthmon_wmde, 
Nabetaro, DannyS712, Nandana, MSantos, Lahi, Gq86, Looniverse, 
GoranSMilovanovic, QZanden, Orienteerix, LawExplorer, Ddproxy, _jensen, 
rosalieper, JGirault, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, 
Planemad, Wikidata-bugs, aude, Yurik, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T227402: Wikimedia map does not display wikidata item (using Template:Maplink)

2019-07-30 Thread Pikne 
Pikne added a comment.


  In T227402#5376546 , 
@Evad37 wrote:
  
  > https://en.wikipedia.org/wiki/User:Evad37/Sandbox/Mapframe_test
  > For the big maps available after clicking the thumbnails, specifying a 
latitude and longitude only works if a zoom is also specified, otherwise the 
white background with the red dot is shown.
  
  Isn't that the intended behaviour? Note here 

 suggests that without using auto-positioning (longitude/latitude specififed) 
zoom was required earlier as well.  If zoom isn't optional in this case then 
displaying an explicit error message would be nice, of course.

TASK DETAIL
  https://phabricator.wikimedia.org/T227402

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pikne
Cc: Evad37, Pikne, ZONA2LORA, Aklapper, Kozuch, Liuxinyu970226, darthmon_wmde, 
Nabetaro, DannyS712, Nandana, MSantos, Lahi, Gq86, Looniverse, 
GoranSMilovanovic, QZanden, Orienteerix, LawExplorer, Ddproxy, _jensen, 
rosalieper, JGirault, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, 
Planemad, Wikidata-bugs, aude, Yurik, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T227402: Wikimedia map does not display wikidata item (using Template:Maplink)

2019-07-30 Thread Evad37 
Evad37 added a comment.


  While the module could be updated to use the new auto positioning feature, 
this is definitely a bug in Kartographer per the following examples (which just 
use  tag directly, not the module):
  
  https://en.wikipedia.org/wiki/User:Evad37/Sandbox/Mapframe_test
  
  For the big maps available after clicking the thumbnails, specifying a 
latitude and longitude only works if a zoom is also specified, otherwise the 
white background with the red dot is shown.

TASK DETAIL
  https://phabricator.wikimedia.org/T227402

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Evad37
Cc: Evad37, Pikne, ZONA2LORA, Aklapper, Kozuch, Liuxinyu970226, darthmon_wmde, 
Nabetaro, DannyS712, Nandana, MSantos, Lahi, Gq86, Looniverse, 
GoranSMilovanovic, QZanden, Orienteerix, LawExplorer, Ddproxy, _jensen, 
rosalieper, JGirault, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, 
Planemad, Wikidata-bugs, aude, Yurik, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T227402: Wikimedia map does not display wikidata item (using Template:Maplink)

2019-07-27 Thread Kozuch 
Kozuch added a comment.


  And yes, I just identified a problem with the "zoom" parameter. When I leave 
it out for example in the map in https://en.wikipedia.org/wiki/Alabama, there 
is same problem (blank map with dot). I suspect again P625 
 is the problem.
  
  The same problem (after removing zoom): 
https://en.wikipedia.org/wiki/Pinelands_National_Reserve
  
  I want to leave zoom out because after clicking I dont want the same zoom in 
the big map. Without zoom parameter specified the big map zooms to the object.

TASK DETAIL
  https://phabricator.wikimedia.org/T227402

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Kozuch
Cc: Pikne, ZONA2LORA, Aklapper, Kozuch, Liuxinyu970226, darthmon_wmde, 
Nabetaro, DannyS712, Nandana, MSantos, Lahi, Gq86, Looniverse, 
GoranSMilovanovic, QZanden, Orienteerix, LawExplorer, Ddproxy, _jensen, 
rosalieper, JGirault, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, 
Planemad, Wikidata-bugs, aude, Yurik, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T227402: Wikimedia map does not display wikidata item (using Template:Maplink)

2019-07-27 Thread Kozuch 
Kozuch added a comment.


  @Pikne Thanks for your comment. The  code you suggest works for me. 
I am looking at the enwiki:Template:Maplink - it calls 
{{#invoke:Mapframe|main}} which passes all parameters to Mapframe's main 
function. I will not be able to fix this template and it is also locked for me. 
I will try to create my own template bypassing this Maplink's "bug" using your 
code.

TASK DETAIL
  https://phabricator.wikimedia.org/T227402

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Kozuch
Cc: Pikne, ZONA2LORA, Aklapper, Kozuch, Liuxinyu970226, darthmon_wmde, 
Nabetaro, DannyS712, Nandana, MSantos, Lahi, Gq86, Looniverse, 
GoranSMilovanovic, QZanden, Orienteerix, LawExplorer, Ddproxy, _jensen, 
rosalieper, JGirault, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, 
Planemad, Wikidata-bugs, aude, Yurik, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T227402: Wikimedia map does not display wikidata item (using Template:Maplink)

2019-07-11 Thread Pikne 
Pikne added a comment.


  That seems to be due to the way template/module is implemented on Wikipedia. 
The template apparently expects `frame-lat`, `frame-long` and `zoom` parameters 
to work properly. Template documentation 
 suggests that without these 
parameters it tries to something with coordinates from Wikidata, but it seems 
to fail for this specific use case.
  
  There is an auto-positioning feature which the template apparently doesn't 
implement. It was enabled in last November and doesn't seem to be documented on 
mediawiki.org  
either yet. Using this the following syntax should also result in the desired 
result:
  
  `{"type":"ExternalData","service":"geoline","ids":"Q515443"}`

TASK DETAIL
  https://phabricator.wikimedia.org/T227402

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pikne
Cc: Pikne, ZONA2LORA, Aklapper, Kozuch, Liuxinyu970226, darthmon_wmde, 
Nabetaro, Nandana, MSantos, Lahi, Gq86, Looniverse, GoranSMilovanovic, QZanden, 
Orienteerix, LawExplorer, Ddproxy, _jensen, rosalieper, JGirault, phabyogi, 
GAllegre, Susannaanas, ferdbold, lxbarth, Planemad, Wikidata-bugs, aude, Yurik, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T227402: Wikimedia map does not display wikidata item (using Template:Maplink)

2019-07-07 Thread ZONA2LORA 
ZONA2LORA added a comment.


  F29697735: [p pfxtvый.png 

TASK DETAIL
  https://phabricator.wikimedia.org/T227402

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ZONA2LORA
Cc: ZONA2LORA, Aklapper, Kozuch, Liuxinyu970226, darthmon_wmde, Nabetaro, 
Nandana, MSantos, Lahi, Gq86, Looniverse, GoranSMilovanovic, QZanden, 
Orienteerix, LawExplorer, Ddproxy, _jensen, rosalieper, JGirault, phabyogi, 
GAllegre, Susannaanas, ferdbold, lxbarth, Planemad, Wikidata-bugs, aude, Yurik, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T227402: Wikimedia map does not display wikidata item (using Template:Maplink)

2019-07-07 Thread ZONA2LORA 
ZONA2LORA added a comment.


`` привет

TASK DETAIL
  https://phabricator.wikimedia.org/T227402

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ZONA2LORA
Cc: ZONA2LORA, Aklapper, Kozuch, Liuxinyu970226, darthmon_wmde, Nabetaro, 
Nandana, MSantos, Lahi, Gq86, Looniverse, GoranSMilovanovic, QZanden, 
Orienteerix, LawExplorer, Ddproxy, _jensen, rosalieper, JGirault, phabyogi, 
GAllegre, Susannaanas, ferdbold, lxbarth, Planemad, Wikidata-bugs, aude, Yurik, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs