[Wikidata-bugs] [Maniphest] [Commented On] T228734: Hook automatically fixing js formatting issues into git precommit

2019-08-15 Thread noarave
noarave added a comment. @Tarrow @Lucas_Werkmeister_WMDE @Michael Thank you for your input. I think we'll keep this task in the JS scope for now and go with something similar to what we did in EntitySchema. A separate task will be opened to explore similar options for PHP linting. TASK

[Wikidata-bugs] [Maniphest] [Commented On] T228734: Hook automatically fixing js formatting issues into git precommit

2019-08-15 Thread Michael
Michael added a comment. Yes, we had a good experience with this as EntitySchema. Do note, that in these pre-commit hooks, we did not use grunt , but the linters directly. The reason is that you

[Wikidata-bugs] [Maniphest] [Commented On] T228734: Hook automatically fixing js formatting issues into git precommit

2019-08-12 Thread Tarrow
Tarrow added a comment. This sounds like a good plan. To me we should be also running the php linting/fixing at the same time in this case though. TASK DETAIL https://phabricator.wikimedia.org/T228734 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/