[Wikidata-bugs] [Maniphest] [Commented On] T231728: Show warning icon if statement value is changed but reference is not changed in the same edit

Tarrow added a comment. Woo Hoo! I'll move it to done and resolve it :) TASK DETAIL https://phabricator.wikimedia.org/T231728 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Sarai-WMDE, Lucas_Werkmeister_WMDE, Jan_Dittrich,

[Wikidata-bugs] [Maniphest] [Commented On] T231728: Show warning icon if statement value is changed but reference is not changed in the same edit

Sarai-WMDE added a comment. In T231728#5652594 , @Tarrow wrote: > @Sarai-WMDE https://wikidata.beta.wmflabs.org/wiki/Q112 is link you can follow to see if the story looks done to you :) Hey, @Tarrow. I just finished checking the

[Wikidata-bugs] [Maniphest] [Commented On] T231728: Show warning icon if statement value is changed but reference is not changed in the same edit

Jan_Dittrich added a comment. > Is that intentional or an oversight? Not intentional. The mid of the e and the longest horizontal cut through the of the circle should be about on the same vertical position. TASK DETAIL https://phabricator.wikimedia.org/T231728 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T231728: Show warning icon if statement value is changed but reference is not changed in the same edit

Lydia_Pintscher added a comment. Wohoo! This looks good from my side. One minor thing I noticed when comparing to constraints is that the horizontal alignment is different between text and icon. Comparison screenshots: tainted reference: F30917132:

[Wikidata-bugs] [Maniphest] [Commented On] T231728: Show warning icon if statement value is changed but reference is not changed in the same edit

Lucas_Werkmeister_WMDE added a comment. I’m worried that users might be confused if the constraint violation icons now mean something potentially different… but I have no idea how they’re currently perceived, perhaps users already think of them as general problem indicators. That said

[Wikidata-bugs] [Maniphest] [Commented On] T231728: Show warning icon if statement value is changed but reference is not changed in the same edit

Jan_Dittrich added a comment. > good idea to reuse the same icons, though. good point. What would would be the problems in your eyes? TASK DETAIL https://phabricator.wikimedia.org/T231728 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Commented On] T231728: Show warning icon if statement value is changed but reference is not changed in the same edit

Lucas_Werkmeister_WMDE added a comment. suggestion , non-mandatory