[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

gerritbot added a comment. Change 550479 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Update termbox version on wikibase https://gerrit.wikimedia.org/r/550479 TASK DETAIL https://phabricator.wikimedia.org/T232595 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

gerritbot added a comment. Change 550479 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan): [mediawiki/extensions/Wikibase@master] Update termbo version on wikibase https://gerrit.wikimedia.org/r/550479 TASK DETAIL https://phabricator.wikimedia.org/T232595 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

Addshore added a comment. I guess this is still just in beta? TASK DETAIL https://phabricator.wikimedia.org/T232595 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde, Addshore Cc: Addshore, Jan_Dittrich, alaa_wmde, Aklapper, Lea_WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

gerritbot added a comment. Change 542431 **merged** by jenkins-bot: [wikibase/termbox@master] Scroll to and focus on "All entered languages" after collapsing https://gerrit.wikimedia.org/r/542431 TASK DETAIL https://phabricator.wikimedia.org/T232595 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

Hanna_Petruschat_WMDE added a comment. I saw that as well already but am hoping that these gaps are filled little by little rather than making things more complicated on our side by trying to hide one of these buttons if there is no entry at all. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

Pablo-WMDE added a comment. Observation: two "fewer languages" buttons can look funny if there are no "more languages" at all. (observed with latest termbox on my dev system) F30811091: Bildschirmfoto von 2019-10-17 17-44-49.png TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

gerritbot added a comment. Change 534766 abandoned by Pablo Grass (WMDE): AllEnteredLanguagesExpandable: button below list Reason: I6a7e672d07c649c39adf8e0a1783ce2623f950d4 solved this (I believe) https://gerrit.wikimedia.org/r/534766 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

Hanna_Petruschat_WMDE added a comment. No apologies needed @alaa_wmde I just like to explain UX decisions so everyone following or stumbling upon this task later has the chance to understand. Thanks for adding it to the AC! TASK DETAIL https://phabricator.wikimedia.org/T232595 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

gerritbot added a comment. Change 542431 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan): [wikibase/termbox@master] Scroll to and focus on "All entered languages" after collapsing https://gerrit.wikimedia.org/r/542431 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

alaa_wmde added a comment. @Hanna_Petruschat_WMDE yeap apologies I forgot to add this AC eventhough we talked about it before. Adding it to task description now and will work on it asap TASK DETAIL https://phabricator.wikimedia.org/T232595 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

Hanna_Petruschat_WMDE added a comment. @alaa_wmde I would really like to add the "jumping back to the termbox" after collapsing "all entered languages" by clicking on the lower "fewer languages" button as an AC. Otherwise the meaning of the lower button is redundant as it is meant to keep

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

alaa_wmde added a comment. Talked to @Hanna_Petruschat_WMDE and we decided to include in this task scope: [ ] white background for input fields [ ] fix vertical spacing according to Figma mockups TASK DETAIL https://phabricator.wikimedia.org/T232595 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

alaa_wmde added a comment. Applying white backgrounds to input fields would look like this. F30614691: image.png Will follow up with a patch, in case UX decides it looks good TASK DETAIL https://phabricator.wikimedia.org/T232595 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

gerritbot added a comment. Change 542068 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan): [wikibase/termbox@master] Apply white background to input fields in edit mode https://gerrit.wikimedia.org/r/542068 TASK DETAIL https://phabricator.wikimedia.org/T232595

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

Pablo-WMDE added a comment. Personal opinion: in edit mode, form fields inside the grayed-out areas look like they are read-only now. F30592702: Bildschirmfoto von 2019-10-08 18-50-51.png TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

alaa_wmde added a comment. @Hanna_Petruschat_WMDE this can be tested on beta now TASK DETAIL https://phabricator.wikimedia.org/T232595 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde Cc: alaa_wmde, Aklapper, Lea_WMDE, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

gerritbot added a comment. Change 541238 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Pull restyling and "fewer languages" in termbox into Wikibase https://gerrit.wikimedia.org/r/541238 TASK DETAIL https://phabricator.wikimedia.org/T232595 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

gerritbot added a comment. Change 541238 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan): [mediawiki/extensions/Wikibase@master] Pull restyling and "fewer languages" in termbox into Wikibase https://gerrit.wikimedia.org/r/541238 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

gerritbot added a comment. Change 540420 **merged** by jenkins-bot: [wikibase/termbox@master] Support 'Fewer Languages' button in All Entered Languages section https://gerrit.wikimedia.org/r/540420 TASK DETAIL https://phabricator.wikimedia.org/T232595 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

gerritbot added a comment. Change 540420 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan): [wikibase/termbox@master] Support 'Fewer Languages' button in All Entered Languages section https://gerrit.wikimedia.org/r/540420 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

alaa_wmde added a comment. In T232595#5529181 , @alaa_wmde wrote: > @Hanna_Petruschat_WMDE > //from AC// > >> When the "All entered languages" section is collapsed the button used to expand becomes a collapsing button, labeled

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

alaa_wmde added a comment. @Hanna_Petruschat_WMDE " When the "All entered languages" section is collapsed the button used to expand becomes a collapsing button, labeled "Fewer languages" and styled like in mocks." not sure I get this correctly. Does it mean that the same button at the

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

alaa_wmde added a comment. @Lydia_Pintscher https://www.figma.com/file/g86G4bYOcUoIPwEbN041nq/180607_Termbox-Mobile-Sprint?node-id=1741%3A2211 contains the "^ Fewer Languages" in the mock up, so I'll rely on that unless @Hanna_Petruschat_WMDE says that's not it @Pablo-WMDE thanks for

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

Pablo-WMDE added a comment. https://gerrit.wikimedia.org/r/534766 was done when this issue was first discussed and may or may not help with resolving this, now that there is a formal ticket for it. TASK DETAIL https://phabricator.wikimedia.org/T232595 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

gerritbot added a comment. Change 534766 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)): [wikibase/termbox@master] AllEnteredLanguagesExpandable: button below list https://gerrit.wikimedia.org/r/534766 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

Lydia_Pintscher added a comment. Ping @Hanna_Petruschat_WMDE for the mockup. TASK DETAIL https://phabricator.wikimedia.org/T232595 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Aklapper, Lea_WMDE, Lydia_Pintscher,