[Wikidata-bugs] [Maniphest] [Commented On] T241050: Investigate if FormatterCache is actually used everywhere it should be when rendering an entity

gerritbot added a comment. Change 573311 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] wbterms: Use caching for prefetching item lookup in PerRepositoryServiceWiring https://gerrit.wikimedia.org/r/573311 TASK DETAIL https://phabricator.wikimedia.org/T241050

[Wikidata-bugs] [Maniphest] [Commented On] T241050: Investigate if FormatterCache is actually used everywhere it should be when rendering an entity

gerritbot added a comment. Change 573260 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Cache item terms lookup the similar way they are cached in properties https://gerrit.wikimedia.org/r/573260 TASK DETAIL https://phabricator.wikimedia.org/T241050 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T241050: Investigate if FormatterCache is actually used everywhere it should be when rendering an entity

gerritbot added a comment. Change 573285 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Allow terms caching in the diff visualizer integration test https://gerrit.wikimedia.org/r/573285 TASK DETAIL https://phabricator.wikimedia.org/T241050 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T241050: Investigate if FormatterCache is actually used everywhere it should be when rendering an entity

gerritbot added a comment. Change 573311 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/Wikibase@master] wbterms: Use caching for prefetching item lookup in PerRepositoryServiceWiring https://gerrit.wikimedia.org/r/573311 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T241050: Investigate if FormatterCache is actually used everywhere it should be when rendering an entity

gerritbot added a comment. Change 573285 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/WikibaseLexeme@master] Make caching better in the diff visualizer integration test https://gerrit.wikimedia.org/r/573285 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T241050: Investigate if FormatterCache is actually used everywhere it should be when rendering an entity

gerritbot added a comment. Change 573260 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/Wikibase@master] Cache item terms lookup the similar way they are cached in properties https://gerrit.wikimedia.org/r/573260 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T241050: Investigate if FormatterCache is actually used everywhere it should be when rendering an entity

Ladsgroup added a comment. After deploying this fix : F31607338: image.png

[Wikidata-bugs] [Maniphest] [Commented On] T241050: Investigate if FormatterCache is actually used everywhere it should be when rendering an entity

Ladsgroup added a comment. After deploying this fix : F31607338: image.png

[Wikidata-bugs] [Maniphest] [Commented On] T241050: Investigate if FormatterCache is actually used everywhere it should be when rendering an entity

WMDE-leszek added a comment. Anything left do here? Or is the idea to wait with closing this until the change is deployed and live? TASK DETAIL https://phabricator.wikimedia.org/T241050 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: WMDE-leszek

[Wikidata-bugs] [Maniphest] [Commented On] T241050: Investigate if FormatterCache is actually used everywhere it should be when rendering an entity

Addshore added a comment. In T241050#5838312 , @Ladsgroup wrote: > In T241050#5838248 , @gerritbot wrote: > >> Change 565258 **merged** by jenkins-bot: >>

[Wikidata-bugs] [Maniphest] [Commented On] T241050: Investigate if FormatterCache is actually used everywhere it should be when rendering an entity

Ladsgroup added a comment. In T241050#5838248 , @gerritbot wrote: > Change 565258 **merged** by jenkins-bot: > [mediawiki/extensions/Wikibase@master] Pass term type and language to TermIdsResolver in PrefetchingTermLookup >

[Wikidata-bugs] [Maniphest] [Commented On] T241050: Investigate if FormatterCache is actually used everywhere it should be when rendering an entity

gerritbot added a comment. Change 565258 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Pass term type and language to TermIdsResolver in PrefetchingTermLookup https://gerrit.wikimedia.org/r/565258 TASK DETAIL https://phabricator.wikimedia.org/T241050 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T241050: Investigate if FormatterCache is actually used everywhere it should be when rendering an entity

Ladsgroup added a comment. Using XHGui to anlayze rendering of Q7251, it showed that 60% of time for rendering the page is being spent on PrefetchingPropertyTermsLookup, this is crazy: F31538723: image.png (From:

[Wikidata-bugs] [Maniphest] [Commented On] T241050: Investigate if FormatterCache is actually used everywhere it should be when rendering an entity

gerritbot added a comment. Change 566730 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Narrow prefetching of the entities on two special pages https://gerrit.wikimedia.org/r/566730 TASK DETAIL https://phabricator.wikimedia.org/T241050 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T241050: Investigate if FormatterCache is actually used everywhere it should be when rendering an entity

gerritbot added a comment. Change 566730 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/Wikibase@master] Narrow prefetching of the entities on two special pages https://gerrit.wikimedia.org/r/566730 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T241050: Investigate if FormatterCache is actually used everywhere it should be when rendering an entity

Addshore added a comment. Will leave on peer-review for T241050#5809929 to quickly be reviewed by the @WMDE-leszek TASK DETAIL https://phabricator.wikimedia.org/T241050 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T241050: Investigate if FormatterCache is actually used everywhere it should be when rendering an entity

Addshore added a comment. In T241050#5809929 , @Ladsgroup wrote: > The FormatterCache is being used for items but not properties (the left hand side of statements to be exact. If you render an entity with statement value of a property,

[Wikidata-bugs] [Maniphest] [Commented On] T241050: Investigate if FormatterCache is actually used everywhere it should be when rendering an entity

gerritbot added a comment. Change 565258 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/Wikibase@master] Pass term type and language to TermIdsResolver in PrefetchingTermLookup https://gerrit.wikimedia.org/r/565258 TASK DETAIL