[Wikidata-bugs] [Maniphest] [Commented On] T241947: Stop using $wgUser in Wikibase

gerritbot added a comment. Change 564975 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Replace $wgUser with user from RequestContext https://gerrit.wikimedia.org/r/564975 TASK DETAIL https://phabricator.wikimedia.org/T241947 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T241947: Stop using $wgUser in Wikibase

gerritbot added a comment. Change 564975 had a related patch set uploaded (by Silvan Heintze; owner: Silvan Heintze): [mediawiki/extensions/Wikibase@master] Replace global $wgUser with same user info from RequestContext https://gerrit.wikimedia.org/r/564975 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T241947: Stop using $wgUser in Wikibase

Daimona added a comment. In T241947#5802594 , @Addshore wrote: > Well, RequestContext::getMain is slightly less evil that the global probably. Yeah, well, a little bit... I believe the only difference is that, when using

[Wikidata-bugs] [Maniphest] [Commented On] T241947: Stop using $wgUser in Wikibase

Addshore added a comment. Well, RequestContext::getMain is slightly less evil that the global probably. So I'd go for lets just make that patch and hen resolve this task for now :) If someone wants to get rid of RequestContext::getMain then that is a whole different kettle of fish to

[Wikidata-bugs] [Maniphest] [Commented On] T241947: Stop using $wgUser in Wikibase

Daimona added a comment. In T241947#5802562 , @Addshore wrote: > In T241947#5776623 , @Daimona wrote: > >> Note: there are two usages in the entry point which I'm unsure how to fix.

[Wikidata-bugs] [Maniphest] [Commented On] T241947: Stop using $wgUser in Wikibase

gerritbot added a comment. Change 562066 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] tests: Stop using $wgUser https://gerrit.wikimedia.org/r/562066 TASK DETAIL https://phabricator.wikimedia.org/T241947 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T241947: Stop using $wgUser in Wikibase

Daimona added a comment. Note: there are two usages in the entry point which I'm unsure how to fix. TASK DETAIL https://phabricator.wikimedia.org/T241947 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, Aklapper, Hook696,

[Wikidata-bugs] [Maniphest] [Commented On] T241947: Stop using $wgUser in Wikibase

gerritbot added a comment. Change 562066 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy): [mediawiki/extensions/Wikibase@master] tests: Stop using $wgUser https://gerrit.wikimedia.org/r/562066 TASK DETAIL https://phabricator.wikimedia.org/T241947 EMAIL