[Wikidata-bugs] [Maniphest] [Commented On] T246676: Step 1: anonymous edit warning (impact: high)

gerritbot added a comment. Change 595902 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: Remove erroneous margin from anon warning message https://gerrit.wikimedia.org/r/595902 TASK DETAIL https://phabricator.wikimedia.org/T246676 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T246676: Step 1: anonymous edit warning (impact: high)

gerritbot added a comment. Change 595902 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] bridge: Remove erroneous margin from anon warning message https://gerrit.wikimedia.org/r/595902 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T246676: Step 1: anonymous edit warning (impact: high)

Lucas_Werkmeister_WMDE added a comment. Okay, then I think that’s what my current changes already do. Thanks! TASK DETAIL https://phabricator.wikimedia.org/T246676 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc:

[Wikidata-bugs] [Maniphest] [Commented On] T246676: Step 1: anonymous edit warning (impact: high)

Charlie_WMDE added a comment. okay, that is indeed unfortunate. I would still keep this order then 1. warning 2. error 3. bridge loading screen where necessary but none of the screens above should be "interrupted" by any other screen (including the loading screen) TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T246676: Step 1: anonymous edit warning (impact: high)

Lucas_Werkmeister_WMDE added a comment. > ideally the error would be shown before anything else. that should be possible for repo protection etc, no? No, unfortunately. We only know if the page is protected on the repo after making an API request, which takes a while. On the other hand,

[Wikidata-bugs] [Maniphest] [Commented On] T246676: Step 1: anonymous edit warning (impact: high)

Charlie_WMDE added a comment. hey @Lucas_Werkmeister_WMDE those are all very good questions. warning should take precedence over the loading screen = yes loading still happens in the background = yes what's more important, the warning or the error = the error which brings me to

[Wikidata-bugs] [Maniphest] [Commented On] T246676: Step 1: anonymous edit warning (impact: high)

Lucas_Werkmeister_WMDE added a comment. I assume the warning should take precedence over the loading screen, but the loading should still happen in the background. What happens, then, if there is an error (e. g. page protected on repo) while loading, before the user has dismissed the

[Wikidata-bugs] [Maniphest] [Commented On] T246676: Step 1: anonymous edit warning (impact: high)

Sarai-WMDE added a comment. For the record, I made some suggested copy changes in the mocks (will only update them in case the new copy is agreed upon). F31699989: Warning_IP_Edit.png What changed: - The primary button label now