[Wikidata-bugs] [Maniphest] [Commented On] T249715: Add capability to provoke generic save error to browser tests

2020-04-27 Thread gerritbot
gerritbot added a comment. Change 592257 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: Add capability to provoke generic save error to browser tests https://gerrit.wikimedia.org/r/592257 TASK DETAIL https://phabricator.wikimedia.org/T249715 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T249715: Add capability to provoke generic save error to browser tests

2020-04-23 Thread Pablo-WMDE
Pablo-WMDE added a comment. > not sure whether it will ever acquire more functions than those two. At least it will have an intuitive, easy to discover file name then. I can totally see this functionality in wdio-mediawiki as well (it also has a `Util` already). Maybe we can suggest

[Wikidata-bugs] [Maniphest] [Commented On] T249715: Add capability to provoke generic save error to browser tests

2020-04-23 Thread Michael
Michael added a comment. In T249715#6079408 , @Pablo-WMDE wrote: > Hmm, I see a `canSave.js` patch landed. Was about to add such a test to the (new) errorHandling test, using network outage as the reason for the initial loading to fail

[Wikidata-bugs] [Maniphest] [Commented On] T249715: Add capability to provoke generic save error to browser tests

2020-04-23 Thread Pablo-WMDE
Pablo-WMDE added a comment. Hmm, I see a `canSave.js` patch landed. Was about to add such a test to the (new) errorHandling test, using network outage as the reason for the initial loading to fail (retry does hardly make sense on in invalid entity id [the only pre-existing case]). I'd be

[Wikidata-bugs] [Maniphest] [Commented On] T249715: Add capability to provoke generic save error to browser tests

2020-04-23 Thread gerritbot
gerritbot added a comment. Change 592257 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] bridge: Add capability to provoke generic save error to browser tests https://gerrit.wikimedia.org/r/592257 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T249715: Add capability to provoke generic save error to browser tests

2020-04-22 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. > I'm not sure that this needs to be wrapped in a helper function on its own. If it does - where would that helper function live? Since we’ll likely only need it for the save tests, I’d put it in `specs/canSave.js`. TASK DETAIL