[Wikidata-bugs] [Maniphest] [Commented On] T252841: Update the method Wikibase uses to inject edit language links into the language portal

gerritbot added a comment. Change 603543 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] WikibaseClient: Use SkinAfterPortlet hook to add languages action links https://gerrit.wikimedia.org/r/603543 TASK DETAIL https://phabricator.wikimedia.org/T252841 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T252841: Update the method Wikibase uses to inject edit language links into the language portal

Jdlrobson added a comment. Verified the above patch on Monobook, Vector and the link shows on all Wikimedia deployed skins when there are or are not languages. Here's Vector: F31861964: Screen Shot 2020-06-11 at 1.10.17 PM.png F31861970:

[Wikidata-bugs] [Maniphest] [Commented On] T252841: Update the method Wikibase uses to inject edit language links into the language portal

Ammarpad added a comment. In T252841#6208016 , @Jdlrobson wrote: > @Ammarpad , BaseTemplateAfterPortal has now been deprecated for SkinAfterPortlet so we should use that now (in turned out to be easier to deprecate that then I first

[Wikidata-bugs] [Maniphest] [Commented On] T252841: Update the method Wikibase uses to inject edit language links into the language portal

Jdlrobson added a comment. @Ammarpad , BaseTemplateAfterPortal has now been deprecated for SkinAfterPortlet so we should use that now (in turned out to be easier to deprecate that then I first thought). TASK DETAIL https://phabricator.wikimedia.org/T252841 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T252841: Update the method Wikibase uses to inject edit language links into the language portal

gerritbot added a comment. Change 603543 had a related patch set uploaded (by Ammarpad; owner: Ammarpad): [mediawiki/extensions/Wikibase@master] WIP: Wikibase should use only BaseTemplateAfterPortlet hook to add languages action links https://gerrit.wikimedia.org/r/603543 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T252841: Update the method Wikibase uses to inject edit language links into the language portal

Jdlrobson added a comment. @ammarpad that hook will be deprecated in 1.36. It is fine for 1.35 TASK DETAIL https://phabricator.wikimedia.org/T252841 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Ammarpad, Ladsgroup, Addshore,

[Wikidata-bugs] [Maniphest] [Commented On] T252841: Update the method Wikibase uses to inject edit language links into the language portal

gerritbot added a comment. Change 596518 abandoned by Jdlrobson: WIP: SkinTemplateOutputPageBeforeExecHandler is deprecated Reason: I can't get wikibase setup locally right now, but just to note - I do need to get a fix for this in for the July release branch cut!

[Wikidata-bugs] [Maniphest] [Commented On] T252841: Update the method Wikibase uses to inject edit language links into the language portal

gerritbot added a comment. Change 601483 **merged** by jenkins-bot: [mediawiki/skins/MonoBook@master] Show after portal links when languages is empty https://gerrit.wikimedia.org/r/601483 TASK DETAIL https://phabricator.wikimedia.org/T252841 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T252841: Update the method Wikibase uses to inject edit language links into the language portal

gerritbot added a comment. Change 601483 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson): [mediawiki/skins/MonoBook@master] Show after portal links when languages is empty. https://gerrit.wikimedia.org/r/601483 TASK DETAIL https://phabricator.wikimedia.org/T252841

[Wikidata-bugs] [Maniphest] [Commented On] T252841: Update the method Wikibase uses to inject edit language links into the language portal

gerritbot added a comment. Change 596522 abandoned by Jdlrobson: BaseTemplate: language_urls property should always reflect true emptiness Reason: Okay, I'm going to move this decision into the skins themselves. It seems like the path of least resistance right now.

[Wikidata-bugs] [Maniphest] [Commented On] T252841: Update the method Wikibase uses to inject edit language links into the language portal

Jdlrobson added a comment. I need support from one of the Wikidata maintainers to make this change. Right now I am targeting the 1.35 release for deprecating this change. Your help meeting that goal is appreciated! TASK DETAIL https://phabricator.wikimedia.org/T252841 EMAIL PREFERENCES