[Wikidata-bugs] [Maniphest] [Commented On] T255108: Figure out what to do with autoload entries for repo maintenance scripts

gerritbot added a comment. Change 604784 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Remove the last autoload.php https://gerrit.wikimedia.org/r/604784 TASK DETAIL https://phabricator.wikimedia.org/T255108 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T255108: Figure out what to do with autoload entries for repo maintenance scripts

Lucas_Werkmeister_WMDE added a comment. > a handful of tests probably also need their test subject classes to be autoloadable (though I suppose they could `require_once` the files). I just realized that `TestAutoloadClasses` would probably be better for that. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T255108: Figure out what to do with autoload entries for repo maintenance scripts

gerritbot added a comment. Change 605184 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Move Maintenance to PSR-4 Style NS https://gerrit.wikimedia.org/r/605184 TASK DETAIL https://phabricator.wikimedia.org/T255108 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T255108: Figure out what to do with autoload entries for repo maintenance scripts

gerritbot added a comment. Change 605184 had a related patch set uploaded (by Tarrow; owner: Tarrow): [mediawiki/extensions/Wikibase@master] Move Maintenance to PSR-4 Style NS https://gerrit.wikimedia.org/r/605184 TASK DETAIL https://phabricator.wikimedia.org/T255108 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T255108: Figure out what to do with autoload entries for repo maintenance scripts

Tarrow added a comment. List of files that need to be moved to PSR-4 namespace (i.e. not in \Wikibase\Repo\Maintenance) extensions/Wikibase/repo/maintenance/addUnitConversions.php extensions/Wikibase/repo/maintenance/changePropertyDataType.php

[Wikidata-bugs] [Maniphest] [Commented On] T255108: Figure out what to do with autoload entries for repo maintenance scripts

gerritbot added a comment. Change 604784 had a related patch set uploaded (by Tarrow; owner: Tarrow): [mediawiki/extensions/Wikibase@master] Remove WikibaseRepo Maintenance Scripts Autoload https://gerrit.wikimedia.org/r/604784 TASK DETAIL https://phabricator.wikimedia.org/T255108

[Wikidata-bugs] [Maniphest] [Commented On] T255108: Figure out what to do with autoload entries for repo maintenance scripts

Lucas_Werkmeister_WMDE added a comment. Hmph, yeah. Looking at code search , a handful of tests probably also need their test subject classes to be autoloadable (though I suppose they could

[Wikidata-bugs] [Maniphest] [Commented On] T255108: Figure out what to do with autoload entries for repo maintenance scripts

Tarrow added a comment. and I imagine the same thing is needed for RebuildTermsSearchKey TASK DETAIL https://phabricator.wikimedia.org/T255108 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Addshore, Ladsgroup, WMDE-leszek, Aklapper,

[Wikidata-bugs] [Maniphest] [Commented On] T255108: Figure out what to do with autoload entries for repo maintenance scripts

Tarrow added a comment. Having just ripped them out spinning up a mediawiki-docker-dev environment throws Cannot spawn child: Wikibase\Repo\Maintenance\PopulateTermFullEntityId [d0c07525d42cb2059d632688] [no req] Error from line 715 of

[Wikidata-bugs] [Maniphest] [Commented On] T255108: Figure out what to do with autoload entries for repo maintenance scripts

Lucas_Werkmeister_WMDE added a comment. > AFAIK the ain't scripts that use that base class should all load it directly anyway, which would still need to happen even if everything were using PSR4, as there is no autoloader at the start of maintenance script currently. Well,

[Wikidata-bugs] [Maniphest] [Commented On] T255108: Figure out what to do with autoload entries for repo maintenance scripts

Ladsgroup added a comment. I want to add even if we need to load them somewhere, they still don't need to be fully PSR-4 compliant, you can just put them in AutoLoadClasses in the extension.json file, that would get rid of autoload.php and makes loading the extension though extension

[Wikidata-bugs] [Maniphest] [Commented On] T255108: Figure out what to do with autoload entries for repo maintenance scripts

Addshore added a comment. > I’m not sure if the maintenance scripts need to be autoloadable at all Indeed they probably don't need to be, as they should be run directly. And DumpEntities afaik is the only exception, although it in itself isn't really a maintenance script. AFAIK

[Wikidata-bugs] [Maniphest] [Commented On] T255108: Figure out what to do with autoload entries for repo maintenance scripts

Lucas_Werkmeister_WMDE added a comment. To recap: the problem is that the maintenance script file starts lowercase, but the file starts uppercase, therefore PSR-4 can’t be used to autoload e. g. `\Wikibase\Repo\Maintenance\DumpRdf` from `repo/maintenance/dumpRdf.php`, it would have to be