Jan_Dittrich added a comment.
That is what it currently looks like.
F4329457: Screenshot from 2016-08-02 15-10-00.png
So it might make sense to change it to
An error occurred
Make the detail text look like the other (sans-serif, "An error occ…") text.
TASK DETAILhttps://phabricator.wikimedia.org/
thiemowmde added a comment.
We picked this for the current sprint. We said we want to split this into two very small tickets:
Remove collapsing.
Reword the unspecific default message and make it very short and to the point.
TASK DETAILhttps://phabricator.wikimedia.org/T54843EMAIL PREFERENCEShttps
Jan_Dittrich added a comment.
@daniel OK, that we can investigate.TASK DETAILhttps://phabricator.wikimedia.org/T54843EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jan_DittrichCc: Charlie_WMDE, Jan_Dittrich, Jonas, Wikidata-bugs, thiemowmde, adrianheine, Snat
daniel added a comment.
@Jan_Dittrich it's easy to distinguish them, but I don't know how easy it is to pass this distinction on to the bit of code that actually shows the message.TASK DETAILhttps://phabricator.wikimedia.org/T54843EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/em
Jan_Dittrich added a comment.
does this mean that is easy to find out which type of message was received (as frontened) and that triggering the collapsed vs. expanded based on this (or anything else) it not a problem?TASK DETAILhttps://phabricator.wikimedia.org/T54843EMAIL PREFERENCEShttps://phabri
thiemowmde added a comment.
There are three code paths that extract a "detailed message" from the API response, see https://github.com/wikimedia/mediawiki-extensions-WikibaseJavaScriptApi/blob/master/src/RepoApiError.js#L93. The last two should stay as they are. Technical, untranslated, maybe not e
daniel added a comment.
@thiemowmde Translated and untranslated error messages are returned from the API using different mechanisms. They are easy to distinguish.
There is basically three cases:
delivery failure: the API response is not even valid JSON, it's HTML or soemthing.
technical error: t
thiemowmde added a comment.
As far as I'm aware of what I said still applies in many cases: Not all error messages (below the expand button) are translated. I suggest to remove the expand button but keep the (tiny) visual difference between the two. Maybe make it a bit prettier?TASK DETAILhttps://p
Jan_Dittrich added a comment.
I wonder if we need the in-the-interface split between normal and expanded anyway – currently, most errors I know have the useful and short stuff in the expand part so we could try to show normal and expanded part without a visible division.TASK DETAILhttps://phabricat
