[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-02-22 Thread gerritbot
gerritbot added a comment. Change 338806 merged by jenkins-bot: Replace assertTag() with Hamcrest assertions https://gerrit.wikimedia.org/r/338806TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-02-21 Thread gerritbot
gerritbot added a comment. Change 338796 merged by jenkins-bot: Replace assertTag() with Hamcrest assertions https://gerrit.wikimedia.org/r/338796TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-02-21 Thread gerritbot
gerritbot added a comment. Change 338799 merged by jenkins-bot: Replace assertTag() with Hamcrest assertions https://gerrit.wikimedia.org/r/338799TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-02-21 Thread gerritbot
gerritbot added a comment. Change 338807 merged by jenkins-bot: Replace assertTag() with Hamcrest assertions https://gerrit.wikimedia.org/r/338807TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-02-20 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. Ups. Missed part about creating tickets for each separate extension. Anyway, there are patches removing assertTag() usages in extensions: WikibaseQualityConstraints Capiunto WikibaseQualityExternalValidation TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PR

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-02-20 Thread gerritbot
gerritbot added a comment. Change 338807 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE)): Replace assertTag() with Hamcrest assertions https://gerrit.wikimedia.org/r/338807TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia.org/setting

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-02-20 Thread gerritbot
gerritbot added a comment. Change 338806 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE)): Replace assertTag() with Hamcrest assertions https://gerrit.wikimedia.org/r/338806TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia.org/setting

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-02-20 Thread gerritbot
gerritbot added a comment. Change 338799 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE)): Replace assertTag() with Hamcrest assertions https://gerrit.wikimedia.org/r/338799TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia.org/setting

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-02-20 Thread gerritbot
gerritbot added a comment. Change 338796 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE)): Replace assertTag() with Hamcrest assertions https://gerrit.wikimedia.org/r/338796TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia.org/setting

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-02-16 Thread WMDE-leszek
WMDE-leszek added a comment. So if only I did my grepping right it looks like there is no longer any assertTag being used in core Wikibase. Well done @Aleksey_WMDE! I believe before we say this task is resolved, we should take a look at other Wikibase-related extensions and make sure there's no ass

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-02-15 Thread gerritbot
gerritbot added a comment. Change 335666 merged by jenkins-bot: Removed assertTag from SpecialModifyTermTestCase https://gerrit.wikimedia.org/r/335666TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WM

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-02-15 Thread gerritbot
gerritbot added a comment. Change 335443 merged by jenkins-bot: Removed assertTag usages from ChangeLineFormatterTest https://gerrit.wikimedia.org/r/335443TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleks

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-02-15 Thread gerritbot
gerritbot added a comment. Change 335663 merged by jenkins-bot: Removed assertTag from SpecialItemByTitleTest https://gerrit.wikimedia.org/r/335663TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-02-15 Thread gerritbot
gerritbot added a comment. Change 335650 merged by jenkins-bot: Removed assertTag from SpecialSetSiteLinkTest https://gerrit.wikimedia.org/r/335650TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-02-15 Thread gerritbot
gerritbot added a comment. Change 335671 merged by jenkins-bot: Removed assertTag from SpecialSetLabelDescriptionAliasesTest https://gerrit.wikimedia.org/r/335671TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-02-02 Thread gerritbot
gerritbot added a comment. Change 270278 abandoned by Ricordisamoa: Add DOMTestTrait to replace deprecated assertTag() Reason: @Aleksey_WMDE is working on a better solution at T69122 https://gerrit.wikimedia.org/r/270278TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://p

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-02-02 Thread gerritbot
gerritbot added a comment. Change 234291 abandoned by Ricordisamoa: Replace deprecated assertTag() with DOMTestTrait::assertTagSimple() Reason: @Aleksey_WMDE is working on a better solution at T69122 https://gerrit.wikimedia.org/r/234291TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PRE

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-02-02 Thread gerritbot
gerritbot added a comment. Change 335671 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE)): Removed assertTag from SpecialSetLabelDescriptionAliasesTest https://gerrit.wikimedia.org/r/335671TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikim

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-02-02 Thread gerritbot
gerritbot added a comment. Change 335666 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE)): Removed assertTag from SpecialModifyTermTestCase https://gerrit.wikimedia.org/r/335666TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia.org/set

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-02-02 Thread gerritbot
gerritbot added a comment. Change 335663 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE)): Removed assertTag from SpecialItemByTitleTest https://gerrit.wikimedia.org/r/335663TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settin

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-02-02 Thread gerritbot
gerritbot added a comment. Change 335650 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE)): Removed assertTag from SpecialSetSiteLinkTest https://gerrit.wikimedia.org/r/335650TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settin

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-02-02 Thread gerritbot
gerritbot added a comment. Change 334333 merged by jenkins-bot: Refactoring SpecialItemByTitleTest https://gerrit.wikimedia.org/r/334333TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDE, gerritbotC

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-02-01 Thread gerritbot
gerritbot added a comment. Change 335443 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE)): Removed assertTag usages from ChangeLineFormatterTest https://gerrit.wikimedia.org/r/335443TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia.or

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-02-01 Thread gerritbot
gerritbot added a comment. Change 335027 merged by jenkins-bot: Refactor SpecialSetLabelDescriptionAliasesTest to remove assertTag usages https://gerrit.wikimedia.org/r/335027TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailp

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-02-01 Thread gerritbot
gerritbot added a comment. Change 335021 merged by jenkins-bot: Refactor SpecialRedirectEntityTest to remove assertTag usages https://gerrit.wikimedia.org/r/335021TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/T

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-02-01 Thread gerritbot
gerritbot added a comment. Change 335020 merged by jenkins-bot: Refactor SpecialMergeItemsTest to remove assertTag usage https://gerrit.wikimedia.org/r/335020TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Al

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-01-30 Thread gerritbot
gerritbot added a comment. Change 335027 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE)): Refactor SpecialSetLabelDescriptionAliasesTest to remove assertTag usages https://gerrit.wikimedia.org/r/335027TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phab

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-01-30 Thread gerritbot
gerritbot added a comment. Change 335021 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE)): Refactor SpecialRedirectEntityTest to remove assertTag usages https://gerrit.wikimedia.org/r/335021TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wiki

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-01-30 Thread gerritbot
gerritbot added a comment. Change 335020 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE)): Refactor SpecialMergeItemsTest to remove assertTag usage https://gerrit.wikimedia.org/r/335020TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-01-27 Thread gerritbot
gerritbot added a comment. Change 334169 merged by jenkins-bot: Simplified html assertion in SpecialGoToLinkedPageTest https://gerrit.wikimedia.org/r/334169TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Alek

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-01-27 Thread gerritbot
gerritbot added a comment. Change 334165 merged by jenkins-bot: Refactoring SpecialModifyTermTestCase https://gerrit.wikimedia.org/r/334165TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDE, gerritb

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-01-26 Thread gerritbot
gerritbot added a comment. Change 334333 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE)): WIP Refactoring SpecialItemByTitleTest https://gerrit.wikimedia.org/r/334333TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/pane

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-01-25 Thread gerritbot
gerritbot added a comment. Change 334169 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE)): Simplified html assertion in SpecialGoToLinkedPageTest https://gerrit.wikimedia.org/r/334169TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia.o

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-01-25 Thread gerritbot
gerritbot added a comment. Change 334165 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE)): Refactoring SpecialModifyTermTestCase https://gerrit.wikimedia.org/r/334165TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel