Lydia_Pintscher added a comment.
\o/
Looks good!
{icon thumbs-up}
TASK DETAIL
https://phabricator.wikimedia.org/T98014
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine, Lydia_Pintscher
Cc: Liuxinyu970226, gerritbot, Sjoerddebruin,
adrianheine added a comment.
@Lydia_Pintscher Please test current master and decide whether that's good
enough :)
TASK DETAIL
https://phabricator.wikimedia.org/T98014
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: gerritbot,
gerritbot added a comment.
Change 288024 merged by jenkins-bot:
Apply language fallback to terms in header
https://gerrit.wikimedia.org/r/288024
TASK DETAIL
https://phabricator.wikimedia.org/T98014
EMAIL PREFERENCES
adrianheine added a comment.
My first take at this does not take editing into account at all. It seems to
me like this could be sufficient. There are only two cases I can think of that
would lead to inconsistent behavior between what you see after leaving edit
mode and after reloading the
gerritbot added a comment.
Change 288024 had a related patch set uploaded (by Adrian Heine):
Apply language fallback to terms in header
https://gerrit.wikimedia.org/r/288024
TASK DETAIL
https://phabricator.wikimedia.org/T98014
EMAIL PREFERENCES
Lydia_Pintscher added a comment.
"Aliases' empty message will specify in which language there are no aliases
defined (»No aliases defined in Lakota«)" <- I think we should get rid of the
no alias defined message in the top header. We don't show it in the term box
either because we don't
adrianheine added a comment.
I'm starting to work on this. My understanding:
- Label and description will fall back separately according to standard fall
back chains and each have a language hint
- Aliases will not fall back
- Aliases' empty message will specify in which language
Lydia_Pintscher added a comment.
Yeah.
TASK DETAIL
https://phabricator.wikimedia.org/T98014
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lydia_Pintscher
Cc: adrianheine, daniel, Aklapper, Lydia_Pintscher, Wikidata-bugs, aude, Mbch331
adrianheine added a subscriber: adrianheine.
adrianheine added a comment.
I suppose it also shouldn't apply to the edit box below.
TASK DETAIL
https://phabricator.wikimedia.org/T98014
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc:
