[Wikidata-bugs] [Maniphest] [Created] T172015: wikibase-addUsagesForPage doesn't batch properly

[Ladsgroup]

Ladsgroup created this task. Ladsgroup added projects: Wikidata, MediaWiki-extensions-WikibaseClient, Wikidata-Sprint, Wikimedia-log-errors, DBA. Herald added subscribers: PokestarFan, Aklapper.

TASK DESCRIPTION

I found lots of errors like this in logstash:

	{"@timestamp":"2017-07-28T18:44:15.000000+00:00","@version":1,"host":"mw1300","message":"wikibase-addUsagesForPage Wikidata:Database_reports/Complex_constraint_violations/P649 pageId=26771074 usages=array(6069) requestId=863520b6cd1c34bc69340d25 (uuid=bd663414a68d45999e25258957afa0ce,timestamp=1501267444,QueuePartition=rdb1-6380) t=329 error=Wikimedia\\Rdbms\\DBQueryError: A database query error has occurred. Did you forget to run your application's database schema updater after upgrading? \nQuery: (SELECT  eu_entity_id  FROM `wbc_entity_usage`    WHERE eu_entity_id = 'P649'  LIMIT 1  ) UNION ALL (SELECT  eu_entity_id  FROM `wbc_entity_usage`    WHERE eu_entity_id = 'Q19558910'  LIMIT 1  ) UNION ALL (SELECT  eu_entity_id  FROM `wbc_entity_usage`    WHERE eu_entity_id = 'Q20856087'  LIMIT 1  ) UNION ALL (SELECT  eu_entity_id  FROM `wbc_entity_usage`    WHERE eu_entity_id = 'P1435'  LIMIT 1  ) UNION ALL (SELECT  eu_entity_id  FROM `wbc_entity_usage`    WHERE eu_entity_id = 'Q737517'  LIMIT 1  ) UNION ALL (SELECT  eu_entity_id  FROM `wbc_entity_usage`    WHERE eu_entity_id = 'Q1026700'  LIMIT 1  ) UNION ALL (SELECT  eu_entity_id  FROM `wbc_entity_usage`    WHERE eu_entity_id = 'Q4885127'  LIMIT 1  ) UNION ALL (SELECT  eu_entity_id  FROM `wbc_entity_usage`    WHERE eu_entity_id = 'Q14705267'  LIMIT 1  ) UNION ALL (SELECT  eu_entity_id  FROM 
<lots of lines like that>

What seems to happen here is that wikibase-addUsagesForPage doesn't properly batch updates and do them all in one batch which obviously causes disruptions when entity usage is too big.

I might be very wrong, will investigate this tomorrow.

TASK DETAIL

https://phabricator.wikimedia.org/T172015

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Aklapper, Ladsgroup, PokestarFan, GoranSMilovanovic, QZanden, Marostegui, Minhnv-2809, Izno, Luke081515, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair

_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs