thiemowmde created this task. thiemowmde claimed this task. thiemowmde added a subscriber: thiemowmde. thiemowmde added projects: Wikidata, DataValues. Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION Actual problems with these methods: * Hiding class names in strings and relying on PHP's dark magic to turn strings into objects makes it hard to find usages of these classes. * Abstract base classes for tests are considered evil. These patches are a step towards getting rid of the abstract base classes. * It's just not necessary. Just override the `getInstance` method. Done. This is //sooo// much simpler. `SerializerBaseTest::getClass` patches: * https://gerrit.wikimedia.org/r/#/c/195295/ * https://gerrit.wikimedia.org/r/#/c/195558/ `ValueFormatterTestBase::getFormatterClass` base patch: * Base: https://github.com/DataValues/Interfaces/pull/9 * https://github.com/DataValues/Common/pull/24 * https://github.com/DataValues/Geo/pull/46 * https://github.com/DataValues/Number/pull/28 * https://github.com/DataValues/Time/pull/46 `ValueParserTestBase::getParserClass` patches: * Base: https://github.com/DataValues/Common/pull/23 * https://github.com/DataValues/Geo/pull/44 * https://github.com/DataValues/Number/pull/26 * https://github.com/DataValues/Time/pull/44 * https://gerrit.wikimedia.org/r/#/c/194531/ TASK DETAIL https://phabricator.wikimedia.org/T92268 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, Aklapper, Wikidata-bugs, aude _______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
