[Wikidata-bugs] [Maniphest] [Edited] T173332: [Story] remove a Form

2018-03-14 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...Then I don't see Form's edit button 



Tasks (remove after tasks created)

- Create "remove form" API action
action: wblremoveform
formId: L1-F2
- Ensure wbeditentity allows removing a form and uses the same business logic.
- Add remove button to UI which performs removal (makes API call and updates the UI after the change)
- Rename wblexemeaddform and wblexemeeditformelements to wbl-prefixed
- Set up the "Hello World" JS browser test (possibly not a subtask of story ticket)

TASK DETAILhttps://phabricator.wikimedia.org/T173332EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Liuxinyu970226, WMDE-leszek, Aklapper, PokestarFan, Bugreporter, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Lydia_Pintscher, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T173332: [Story] remove a Form

2018-03-14 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...Then I don't see Form's edit button 



Tasks (remove after tasks created)

- Create "remove form" API action
action: wblremoveform
formId: L1-F2
- Ensure wbeditentity allows removing a form and uses the same business logic.
- Add remove button to UI which performs removal (makes API call and updates the UI after the change)
- Rename wblexemeaddform and wblexemeeditformelements to wbl-prefixed
- Set up the "Hello World" JS browser test (possibly not a subtask of story ticket)

TASK DETAILhttps://phabricator.wikimedia.org/T173332EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Liuxinyu970226, WMDE-leszek, Aklapper, PokestarFan, Bugreporter, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Lydia_Pintscher, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T173332: [Story] remove a Form

2018-03-14 Thread RazShuty
RazShuty updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...And I see the Error Message bubble next !!TODO: define where it is!!to the save button
And the Error Message says ERROR MESSAGE FOR EACH ERROR...TASK DETAILhttps://phabricator.wikimedia.org/T173332EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: RazShutyCc: Liuxinyu970226, WMDE-leszek, Aklapper, PokestarFan, Bugreporter, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T173332: [Story] remove a Form

2018-03-13 Thread Lydia_Pintscher
Lydia_Pintscher updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...And SUMMARY NEEDS TO BE DEFINED BY PRODUCTthe summary says // Removed form: Leitern (Dativ, Plural) //

**Error Flows:**...TASK DETAILhttps://phabricator.wikimedia.org/T173332EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Liuxinyu970226, WMDE-leszek, Aklapper, PokestarFan, Bugreporter, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T173332: [Story] remove a Form

2018-03-12 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...And I see the Error Message bubble next !!TODO: define where it is!!
And the Error Message says ERROR MESSAGE FOR EACH ERROR...TASK DETAILhttps://phabricator.wikimedia.org/T173332EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Liuxinyu970226, WMDE-leszek, Aklapper, PokestarFan, Bugreporter, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T173332: [Story] remove a Form

2018-03-12 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...UX - to prepare a style guide components for Wikidata
Click Here [TODO: add link[[https://drive.google.com/file/d/11CYtkbS5YGlt4_edXY5yp9vTeuFDcmNz/view|Click Here]] for Wireframe...TASK DETAILhttps://phabricator.wikimedia.org/T173332EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Liuxinyu970226, WMDE-leszek, Aklapper, PokestarFan, Bugreporter, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T173332: [Story] remove a Form

2018-03-12 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...| Error Type | Error message |
| Error Message | !!TODO!! |
| Edit Conflict | !!TODO!! |
| Rate Limit | !!TODO!! |
| Read Only | !!TODO!! |
| Token failure/Session Failure | !!TODO!! |
| Abuse filter failure | !!TODO!! |
| Unexpected exceptions | !!TODO!! |
| Permissions | !!TODO!! |
| Protected | !!TODO!! |
 |...TASK DETAILhttps://phabricator.wikimedia.org/T173332EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Liuxinyu970226, WMDE-leszek, Aklapper, PokestarFan, Bugreporter, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T173332: [Story] remove a Form

2018-03-12 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...**Acceptance criteria:**
A form can be removed via the UI
* A form can be removed via the API
Tracking that needs to be done is specifiedUI

**Wireframes**...TASK DETAILhttps://phabricator.wikimedia.org/T173332EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Liuxinyu970226, WMDE-leszek, Aklapper, PokestarFan, Bugreporter, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T173332: [Story] remove a Form

2018-03-12 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...Tracking that needs to be done is specified

**Wireframes**

Wireframes for individuals features referencing the style guide components ...Click Here [TODO: add link] for Wireframe


**Happy Path:**

Given I am on the Lexeme page...And SUMMARY NEEDS TO BE DEFINED BY PRODUCT

**Error Flows:**

Given I am on a Lexeme page...And the Error Message says ERROR MESSAGE FOR EACH ERROR
And the Delete button is still shown and can be clicked


Error List 1:...TASK DETAILhttps://phabricator.wikimedia.org/T173332EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Liuxinyu970226, WMDE-leszek, Aklapper, PokestarFan, Bugreporter, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T173332: [Story] remove a Form

2018-03-12 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONAs an editor I want to be able to remove a wrong form.editor, I want to remove a form

**Acceptance criteria:**
A form can be removed via the UI
A form can be removed via the API
Tracking that needs to be done is specified


Wireframes for individuals features referencing the style guide components 
UX - to prepare a style guide components for Wikidata
Click Here for Wireframe


Happy Path:

Given I am on the Lexeme page
And I have permissions to edit Lexeme
And a Form for the Lexeme exists
When I click on the Form’s edit button 
And I see a delete button in the edit form block
Then I click delete
And I see //Removing...// message
And the form is deleted
And the removal shows up in the edit history with the summary
And SUMMARY NEEDS TO BE DEFINED BY PRODUCT

Error Flows:

Given I am on a Lexeme page
And I have permissions to edit Lexeme
And a Form for the Lexeme exists
When I click on the Form’s edit button 
And I see a delete button in the edit form block
And I click delete
And I see //Removing...// message
And an error from error list 1 occurred  
Then The Removing... message is hidden
And I see the Form is still there
And I see the Error Message bubble next TODO: define where it is
And the Error Message says ERROR MESSAGE FOR EACH ERROR


Error List 1:

Acceptance criteria:| Error Type
| Error Message
| Edit Conflict
| Rate Limit
| Read Only
| Token failure/Session Failure
| Abuse filter failure
| Unexpected exceptions
| Permissions
| Protected
 |





Given I am on a Lexeme page
When I don’t have permissions to edit Lexeme
And a Form for the Lexeme exists
Then I don't see Form's edit button 

Given I am on a Lexeme page
* a form can be removed via the UIWhen The Lexeme is protected
* a fAnd a Form can be removed via the APIfor the Lexeme exists
* the removal shows up in theThen I don't see Form's edit historybutton 

TASK DETAILhttps://phabricator.wikimedia.org/T173332EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Liuxinyu970226, WMDE-leszek, Aklapper, PokestarFan, Bugreporter, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs