[Wikidata-bugs] [Maniphest] [Edited] T189593: Replace CachingResultsBuilder with CachingResultsSource, (de)serializing CheckResults
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [ ] [remove `ResultsBuilder` and implementationss](https://gerrit.wikimedia.org/r/421875) - [ ] [update API help message of `status` parameter](https://gerrit.wikimedia.org/r/421873)TASK DETAILhttps://phabricator.wikimedia.org/T189593EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Ladsgroup, gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Versusxo, Majesticalreaper22, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T189593: Replace CachingResultsBuilder with CachingResultsSource, (de)serializing CheckResults
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [ ] [update API help message of the `status` parameter, because some more requests now benefit from caching](https://gerrit.wikimedia.org/r/421873)TASK DETAILhttps://phabricator.wikimedia.org/T189593EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Ladsgroup, gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Versusxo, Majesticalreaper22, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T189593: Replace CachingResultsBuilder with CachingResultsSource, (de)serializing CheckResults
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [x] [add `CachedCheckResults`](https://gerrit.wikimedia.org/r/420706) (simple wrapper object) - [x] [`ResultsSource`, `CheckingResultsSource`](https://gerrit.wikimedia.org/r/420707) (half of `CheckingResultsBuilder`) - [x] [`CheckResultsRenderer`](https://gerrit.wikimedia.org/r/420708) (other half of `CheckingResultsBuilder`) - [x] [make the `"v2.1"` part of the cache key in `ResultsCache` configurable](https://gerrit.wikimedia.org/r/420719) – we need `"v2.1"` for `CachingResultsBuilder` but `"v2.2"` for `CachingResultsSource` - [ ] [`CachingResultsSource`](https://gerrit.wikimedia.org/r/420834) - [ ] [change `CheckConstraints` API to use `ResultsSource`+`CheckResultsRenderer` instead of `ResultsBuilder`](https://gerrit.wikimedia.org/r/420835) - [ ] remove `ResultsBuilder` and implementations - [ ] update API help message of the `status` parameter, because some more requests now benefit from cachingTASK DETAILhttps://phabricator.wikimedia.org/T189593EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Ladsgroup, gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Versusxo, Majesticalreaper22, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T189593: Replace CachingResultsBuilder with CachingResultsSource, (de)serializing CheckResults
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [change `CheckConstraints` API to use `ResultsSource`+`CheckResultsRenderer` instead of `ResultsBuilder`](https://gerrit.wikimedia.org/r/420835) – API tests not updated yet but can already be tested manually - remove `ResultsBuilder` and implementations...TASK DETAILhttps://phabricator.wikimedia.org/T189593EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Versusxo, Majesticalreaper22, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T189593: Replace CachingResultsBuilder with CachingResultsSource, (de)serializing CheckResults
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [make the `"v2.1"` part of the cache key in `ResultsCache` configurable](https://gerrit.wikimedia.org/r/420719) – we need `"v2.1"` for `CachingResultsBuilder` but `"v2.2"` for `CachingResultsSource` - - [`CachingResultsSource`](https://gerrit.wikimedia.org/r/420834) - [change `CheckConstraints` API to use `ResultsSource`+`CheckResultsRenderer` instead of `ResultsBuilder` (don’t forget to change the format version in `ResultsCache::getDefaultInstance()`)](https://gerrit.wikimedia.org/r/420835) – API tests not updated yet but can already be tested manually - remove `ResultsBuilder` and implementations...TASK DETAILhttps://phabricator.wikimedia.org/T189593EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Versusxo, Majesticalreaper22, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T189593: Replace CachingResultsBuilder with CachingResultsSource, (de)serializing CheckResults
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- remove `ResultsBuilder` and implementations - update API help message of the `status` parameter, because some more requests now benefit from cachingTASK DETAILhttps://phabricator.wikimedia.org/T189593EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Versusxo, Majesticalreaper22, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T189593: Replace CachingResultsBuilder with CachingResultsSource, (de)serializing CheckResults
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [make the `"v2.1"` part of the cache key in `ResultsCache` configurable](https://gerrit.wikimedia.org/r/420719) – we need `"v2.1"` for `CachingResultsBuilder` but `"v2.2"` for `CachingResultsSource`...- change `CheckConstraints` API to use `ResultsSource`+`CheckResultsRenderer` instead of `ResultsBuilder` (don’t forget to change the format version in `ResultsCache::getDefaultInstance()`) - remove `ResultsBuilder` and implementationsTASK DETAILhttps://phabricator.wikimedia.org/T189593EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Versusxo, Majesticalreaper22, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
