[Wikidata-bugs] [Maniphest] [Edited] T190670: Unclear behavior of grammatical feature diff headers
Pablo-WMDE updated the task description. (Show Details)Pablo-WMDE set the point value for this task to "2". CHANGES TO TASK DESCRIPTION...WHEN a diff of grammatical features on a lexeme is presented THEN no "grammatical feature" id is shown in the diff "breadcrumb" ...TASK DETAILhttps://phabricator.wikimedia.org/T190670EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: Aklapper, WMDE-leszek, Pablo-WMDE, Lydia_Pintscher, Jakob_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T190670: Unclear behavior of grammatical feature diff headers
Pablo-WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...{F16099963}
Additional question: Did we decide on the "/"-separator for the diff header breadcrumbs? Should they be translatable? It is currently hardcoded in `BasicDiffView` and `GrammaticalFeatureDiffVisualizer`.```
GIVEN I am on a diff page
WHEN a diff of grammatical features on a lexeme is presented
THEN no "grammatical feature" id is shown in the diff "breadcrumb"
```
TASK DETAILhttps://phabricator.wikimedia.org/T190670EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: Aklapper, WMDE-leszek, Pablo-WMDE, Lydia_Pintscher, Jakob_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T190670: Unclear behavior of grammatical feature diff headers
Pablo-WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONWhen looking at a diff of a lexeme where a form's grammatical features have been changed, each grammatical feature addition or deletion has a breadcrumb-like header e.g. "Form / L3-F1 / grammatical feature / 0" that ends with an index **of the diff operation** that has been performed on the grammatical feature list. This is confusing since it looks like it is showing IDs of grammatical features, while not showing the entirety of the grammatical features of the form (i.e. This is confusing since it looks like it is showing IDs of grammatical features.showing a hypothetical second grammatical feature just added as "id" 0). The following two screenshots show how the indexes are reversed when reversing a previous editTASK DETAILhttps://phabricator.wikimedia.org/T190670EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: Aklapper, WMDE-leszek, Pablo-WMDE, Lydia_Pintscher, Jakob_WMDE, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T190670: Unclear behavior of grammatical feature diff headers
Jakob_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...{F16099963}
Additional question: Did we decide on the "/"-separator for the diff header breadcrumbs? Should they be translatable? It is currently hardcoded in `BasicDiffView` and `GrammaticalFeatureDiffVisualizer`.TASK DETAILhttps://phabricator.wikimedia.org/T190670EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDECc: Aklapper, WMDE-leszek, Pablo-WMDE, Lydia_Pintscher, Jakob_WMDE, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
