[Wikidata-bugs] [Maniphest] [Edited] T194048: Introduce RevisionRenderer (baseline)

2018-08-01 Thread daniel
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...In later iterations, SlotRoleHandlers should provide layout hints that can cause the output for some slots to be placed differently.

NOTE: One seemingly trivial aspect of this that should not be underestimated is the need for code that merges one ParserOutput into another.TASK DETAILhttps://phabricator.wikimedia.org/T194048EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tgr, danielCc: gerritbot, Aklapper, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T194048: Introduce RevisionRenderer (baseline)

2018-08-01 Thread daniel
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...* renderRevision( RevisionRecord $revRec, ParserOptions $options ): ParserOutput;RenderedRevison;

RenderedRevision would in turn support at least:
* getCombinedParserOutput()
* getRevision()
* maybe also getSlotParserOutput( $role ).

All ParserOutputs should be cached locally. The ParserOptions to be used would be injected into the constructor of RenderedRevision by RevisionRenderer::renderRevision().

For the first version, it's sufficient for RevisionRenderergetCombinedParserOutput to concatenate the output for all slots, with the main slot going first, possibly with a heading for all but the main slot.

In later iterations, SlotRoleHandlers should provide layout hints that can cause the output for some slots to be placed differently.TASK DETAILhttps://phabricator.wikimedia.org/T194048EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tgr, danielCc: gerritbot, Aklapper, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs