[Wikidata-bugs] [Maniphest] [Edited] T195315: Lexemes mentioned in constraint reports only show entity ID

2018-07-01 Thread CommunityTechBot
CommunityTechBot updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION26570726f6475636520796f757220627567207573696e67206120726563656e742076657273696f6e206f662074686520736f6674776172652c20746f2068652077696b6920636f6e74656e74206c616e67756167652e0a0a5468616e6b20796f752e0a546167730a436865636b557365720ad70a436f6e6e65637465642d4f70656e2d48657269746167652d42617463682d75706c6f61647320285241c42d4b4d425f315f323031372d3032290ad70a54616d696c2d53697465730ad70a47616d6570726573730ad70a48617368746167730ad70a4a4144450ad70a4b6172746f456469746f720ad70a4c616e67756167652d323031382d4170722d4a756e650ad70a4e65772d456469746f722d457870657269656e6365730ad70a4d61696c0ad70a5443422d5465616d0ad70a53756273637269626572730a4465736372697074696f6e20507265766965770a436f6e74656e77a6f6e652073657474696e6720696e20796f75722070726f66696c652c20636c69636b20746f207265636f6e63696c652eAs an editor I want to easily understand what a constraint violation that involves a Lexeme is saying in order to be able to fix the constraint violation.

**Problem:**
When a lexeme is mentioned in the violation message of a constraint report, the link text is only the lexeme ID, instead of the lemma(s).

**Example:**
https://www.wikidata.org/w/index.php?title=Lexeme:L123=704111533#P123

**Screenshots:**
{F23072557}

**BDD**
GIVEN a statement has a constraint violation
AND the constraint violation explanation contains a reference to a Lexeme
THEN the link to that Lexeme should show the Lemma(s) as link text

**Acceptance criteria:**
* The Lexeme ID is no longer shown but instead the Lemma(s)

**Open questions:**
* Are there places where this is also happening for Forms?

**Technical notes:**

WikibaseQualityConstraints initializes entity ID rendering like this:
```lang=php
$languageFallbackLabelDescriptionLookupFactory = $repo->getLanguageFallbackLabelDescriptionLookupFactory();
$labelDescriptionLookup = $languageFallbackLabelDescriptionLookupFactory->newLabelDescriptionLookup( $language );
$entityIdHtmlLinkFormatterFactory = $repo->getEntityIdHtmlLinkFormatterFactory();
$entityIdHtmlLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter( $labelDescriptionLookup );
```
It looks like the `EntityIdHtmlLinkFormatter` doesn’t support entities without labels correctly…?TASK DETAILhttps://phabricator.wikimedia.org/T195315EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CommunityTechBotCc: Pablo-WMDE, WMDE-leszek, Lucas_Werkmeister_WMDE, Mringgaard, AndyTan, Zylc, 1978Gage2001, Lahi, Gq86, herron, GoranSMilovanovic, Chicocvenancio, alanajjar, QZanden, Tbscho, merbst, LawExplorer, Lea_WMDE, Mattias_Ostmar-WMSE, JJMC89, Jseddon, Agabi10, Ryuch, Mkdw, RuyP, JEumerus, Trizek-WMF, KasiaWMDE, 0x010C, srodlund, Luke081515, grin, Bsadowski1, mys_721tx, Wikidata-bugs, Snowolf, aude, Huji, Gryllida, jayvdb, Tobi_WMDE_SW, Darkdadaah, revi, scfc, He7d3r, Romaine, Mbch331, Jay8g, Glaisher, Krenair, chasemp___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T195315: Lexemes mentioned in constraint reports only show entity ID

2018-06-29 Thread Lydia_Pintscher
Lydia_Pintscher updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...**Screenshots/mockups:**...TASK DETAILhttps://phabricator.wikimedia.org/T195315EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Aklapper, Pablo-WMDE, WMDE-leszek, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, merbst, LawExplorer, Agabi10, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T195315: Lexemes mentioned in constraint reports only show entity ID

2018-06-29 Thread Lydia_Pintscher
Lydia_Pintscher updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONAs an editor I want to easily understand what a constraint violation that involves a Lexeme is saying in order to be able to fix the constraint violation.

**Problem:**
When a lexeme is mentioned in the violation message of a constraint report, the link text is only the lexeme ID, instead of the lemma(s).

**Example:**
https://www.wikidata.org/w/index.php?title=Lexeme:L123=704111533#P123

**Screenshots/mockups:**
{F23072557}

**BDD**
GIVEN a statement has a constraint violation
AND the constraint violation explanation contains a reference to a Lexeme
THEN the link to that Lexeme should show the Lemma(s) as link text

**Acceptance criteria:**
* The Lexeme ID is no longer shown but instead the Lemma(s)

**Open questions:**
* Are there places where this is also happening for Forms?

**Technical notes:**

WikibaseQualityConstraints initializes entity ID rendering like this:...TASK DETAILhttps://phabricator.wikimedia.org/T195315EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Aklapper, Pablo-WMDE, WMDE-leszek, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, merbst, LawExplorer, Agabi10, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs